1467814 - The empty "Email" field has no highlight and the wrong message is displayed when the "Continue" button is clicked on "about:welcome"

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: empty email field no highlight effect and wrong message.gif

[Affected versions]:
- Nightly 62.0a1 Build ID 20180607220114

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the Browser and navigate to the about:welcome page.
2. Click the "Continue" button and observe the behavior.

[Expected results]:
- The "Email" field is highlighted with red and the "Valid email required" message appears in a red bubble towards the top of the page.

[Actual results]:
- The "Email" field is not highlighted and the "Please fill out this filed" message appears in a white bubble towards the bottom of the page.

[Notes]:
- Attached a screenshot of the issue.

Comment 1

[Erica Wright [:ewright]]

We're aiming to change this for 63, because of the string change needed.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4215

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/6e2b5e3900d2ddc38dbe7dfaa7878a93ad6979ee
Bug 1467814 - Invalid email field has custom styling and message.

https://github.com/mozilla/activity-stream/commit/7591b9f208bc7b1c07533450f9828e266956e4cf
Merge pull request #4215 from ericawright/validation

Fix Bug 1467814 - Invalid email field has custom styling and message.

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/0ef1451e9411

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly (63.0a1) on Windows 10 x64, Mac 10.13.5 and Arch Linux x64. 

I did, however, observe that we no longer focus the "Email" field when the "Continue" button is clicked and the field is empty. I've logged a separate issue for this in bug 1472642.

Comment 6

[Pascal Chevrel:pascalc]

(In reply to Erica Wright [:ewright] from comment #1)
> We're aiming to change this for 63, because of the string change needed.

Marking as wontfix for 62 then.