1472642 - The empty "Email" field is not focused when the "Continue" button is clicked on about:welcome

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: email field not focused when empty .gif

[Affected versions]:
- Nightly 63.0a1 Build ID 20180701220749

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the Browser and navigate to the about:welcome page.
2. Click the "Continue" button and observe the behavior.

[Expected results]:
- The "Email" field is focused.

[Actual results]:
- The "Email" field is highlighted with red and the "Valid email required" message appears in a red bubble towards the top of the page, but the field is not focused.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4226

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b294fc8440b5b70ec1cb948e51e11f2f472364e6
Fix Bug 1472642: focus email field on invalid input in about:welcome (#4226)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This is marked as blocking a bug which was fixed in 62, but this bug has 62 marked as unaffected. Is that correct?

Comment 4

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I treated bug 1448918 as a sort of meta bug for the about:welcome feature. 
Yes, that is correct. 62 is unaffected because we're blocked by bug 1467814, which still is reproducible on that version, but fixed in 63.

Comment 5

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly build (63.0a1, Build ID 20180708220048) on Windows 10 x64, Mac 10.13.6 and Arch Linux x64.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c8abaff6bcae

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c8abaff6bcae