1467827 - Port raptor firefox tp6 to linux

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement)

Comment 1

[Robert Wood [:rwood]]

Note: The TC configs to add Raptor tp6 to linux64 and win10 on try as tier3 are included in Bug 1467823

Comment 2

[Robert Wood [:rwood]]

Try run to see latest status of Raptor tests on all platforms (only OSX is green so far):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54dde805af6faeac619af64144b0310ce0f8ea75&filter-tier=1&filter-tier=2&filter-tier=3

Comment 3

[Robert Wood [:rwood]]

Attachment: Bug 1467827 - Port raptor firefox tp6 to linux;

Review commit: https://reviewboard.mozilla.org/r/250862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250862/

Comment 4

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/1-2/

Comment 5

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dd35580d19c6bb0e1ca5bdcf8f06ea73f4ccb9d

Comment 6

[Robert Wood [:rwood]]

Making this bug for porting raptor tp6 firefox to linux64 (filed Bug 1468865 for porting to Win10).

Comment 7

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=637cfdaf82ce073b427785a6e1cb815fe5100805

Comment 8

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/2-3/

Comment 9

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98aa378c78346ebc442221986c3c22b4cc7495c8

Comment 10

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fa889b7c88b90fdb4b41b5f64ea7a5930bacf24

Comment 11

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/3-4/

Comment 12

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7db00275065b6f30d620d42eb33daf902e24ee41

Comment 13

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/4-5/

Comment 14

[Code Review Bot [:reviewbot]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

https://reviewboard.mozilla.org/r/250862/#review257704


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: testing/raptor/raptor/playback/mitmproxy.py:133
(Diff revision 5)
> +    def transform_platform(str_to_transform):
> +        # transform platform name i.e. 'mitmproxy-rel-bin-{platform}.manifest'
> +        # transforms to 'mitmproxy-rel-bin-osx.manifest'
> +        if '{platform}' not in str_to_transform:
> +            return str_to_transform
> +        if 'win' in self.config['platform']:

Error: Undefined name 'self' [flake8: F821]

::: testing/raptor/raptor/playback/mitmproxy.py:135
(Diff revision 5)
> +        # transforms to 'mitmproxy-rel-bin-osx.manifest'
> +        if '{platform}' not in str_to_transform:
> +            return str_to_transform
> +        if 'win' in self.config['platform']:
> +            platform_id = 'win'
> +        elif self.config['platform'] == 'mac':

Error: Undefined name 'self' [flake8: F821]

Comment 15

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/5-6/

Comment 16

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1a1677f3771245457909998c526b6fea2d0e381

Comment 17

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/6-7/

Comment 18

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea89e3abf457564d1dbbc5b27c98cd44d06df0df

Comment 19

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/7-8/

Comment 20

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

https://reviewboard.mozilla.org/r/250862/#review257730

a few nits/optional things to consider.

::: taskcluster/ci/test/raptor.yml:35
(Diff revision 8)
>      try-name: raptor-firefox-tp6
>      treeherder-symbol: Rap(tp6)
>      run-on-projects:
>          by-test-platform:
>              macosx.*: ['try', 'mozilla-central']
> +            linux64.*: ['try', 'mozilla-central']

can we just make this:
win.*: []

::: taskcluster/taskgraph/transforms/tests.py:412
(Diff revision 8)
>              test['mozharness']['set-moz-node-path'] = True
>              test.setdefault('e10s', True)
>  
>          # software-gl-layers is only meaningful on linux unittests, where it defaults to True
> -        if test['test-platform'].startswith('linux') and test['suite'] != 'talos':
> +        if test['test-platform'].startswith('linux') and test['suite'] != 'talos' and \
> +                test['suite'] != 'raptor':

maybe:
and test['suite'] not in ['talos', 'raptor']

::: testing/raptor/raptor/playback/mitmproxy.py:139
(Diff revision 8)
> +            platform_id = 'win'
> +        elif self.config['platform'] == 'mac':
> +            platform_id = 'osx'
> +        else:
> +            platform_id = 'linux64'
> +        return str_to_transform.replace('{platform}', platform_id)

this might be useful in other parts of raptor- consider refactoring to a 'utils' section

Comment 21

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

https://reviewboard.mozilla.org/r/250862/#review257730

> can we just make this:
> win.*: []

Not sure what you mean here. Remove mac and linux64 lines and just have win to []? Then have default on try and central? But then any new or other platforms will auto be added to central... ?

> maybe:
> and test['suite'] not in ['talos', 'raptor']

Ah yes thanks

> this might be useful in other parts of raptor- consider refactoring to a 'utils' section

Good idea thanks will do

Comment 22

[Joel Maher ( :jmaher ) (UTC -8)]

all platforms is:
linux
win
osx

and soon to be android, we can solve this later.

Comment 23

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/8-9/

Comment 24

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cacd29519c7871151dc5bf251a3082cb9a95c058

Comment 25

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/9-10/

Comment 26

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25b2dbf0ba802dca0fa996561447297357b0f916

Comment 27

[Robert Wood [:rwood]]

Comment on attachment 8985234 [details]
Bug 1467827 - Port raptor firefox tp6 to linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250862/diff/10-11/

Comment 28

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c74a2a31c0fdac89b9fd0950e5a53cd64e2d7f5

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f424be1fb4a
Port raptor firefox tp6 to linux; r=jmaher

Comment 30

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7f424be1fb4a