Closed
Bug 146797
Opened 23 years ago
Closed 23 years ago
bullet-proof RDF containers from script [@ RDFContainerUtilsImpl::IndexOf]
Categories
(Core Graveyard :: RDF, defect, P1)
Core Graveyard
RDF
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: waterson, Assigned: waterson)
References
Details
(Keywords: crash, topcrash+, Whiteboard: [ADT1 RTM][FIXED ON TRUNK])
Crash Data
Attachments
(1 file, 1 obsolete file)
|
4.45 KB,
patch
|
tingley
:
review+
|
Details | Diff | Splinter Review |
It's possible to construct an RDF container via (trusted) script and leave it
uninitialized. This is causing a topcrash in AIM for the commercial release (cf.
Netscape internal URL <http://bugscape.netscape.com/show_bug.cgi?id=15942>).
Attaching a patch to bullet-proof the container object as well as the container
utils service.
|
Assignee | |
Comment 1•23 years ago
|
||
I also removed some unnecessary null checks; e.g., for valid out-param slots.
|
|
Assignee | |
Comment 2•23 years ago
|
||
rjc or tingley, could you r=? thanks!
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.0.1
|
||
Comment 3•23 years ago
|
||
Comment on attachment 84924 [details] [diff] [review]
bullet-proofing for RDF container and container-utils
sr=shaver without the PRECONDITION noise for cases that may not indicate a bug
to be fixed in the scripted caller.
Attachment #84924 -
Flags: superreview+
|
|
Assignee | |
Comment 4•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Attachment #84924 -
Attachment is obsolete: true
|
||
Comment 5•23 years ago
|
||
Comment on attachment 84928 [details] [diff] [review]
as above, sans noise.
In RemoveElementAt(), do you really want to remove the null out ptr check for
_retval?
Other than that r=tingley
I'm getting on a plane shortly (and will be internet-less for the weekend), so
rjc will need to re-review if anything changes.
Attachment #84928 -
Flags: review+
|
|
Assignee | |
Comment 6•23 years ago
|
||
Yes, I do. The out parameter is set by the XPConnect engine, and will not be null.
|
||
Updated•23 years ago
|
|
||
Comment 8•23 years ago
|
||
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
Driver's approval. Pls check this in tonight, and add the fixed1.0.1 keyword.
|
|
Assignee | |
Comment 9•23 years ago
|
||
Fix checked in on the trunk. Leaving the bug open for branch approval.
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: [ADT1 RTM] → [ADT1 RTM][FIXED ON TRUNK]
|
||
Comment 10•23 years ago
|
||
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
|
|
Assignee | |
Comment 11•23 years ago
|
||
Fix checked in on branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: mozilla1.0.1+ → fixed1.0.1
Resolution: --- → FIXED
|
||
Comment 12•23 years ago
|
||
*** Bug 146529 has been marked as a duplicate of this bug. ***
|
||
Comment 13•23 years ago
|
||
verified trunk and branch - 07/18/2002 builds, win NT4, linux rh6, mac osX
Status: RESOLVED → VERIFIED
|
||
Updated•14 years ago
|
Crash Signature: [@ RDFContainerUtilsImpl::IndexOf]
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•