Closed Bug 1468053 Opened 6 years ago Closed 6 years ago

Live toolbar dropdown menu disappears on second click (macOS Mojave Beta)

Categories

(Core :: Widget: Cocoa, defect, P1)

Product:
Core
Component:
Widget: Cocoa
Version:
61 Branch
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 62+ verified
firefox61 - wontfix
firefox62 + verified
firefox63 + verified

People

(Reporter: carl, Assigned: spohl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Patch (removes workaround completely)
4.38 KB, patch
spohl
: review+
Details | Diff | Splinter Review
Patch (removes workaround on 10.14+)
4.94 KB, patch
spohl
: review+
ritu
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr60+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 Firefox for Android Steps to reproduce: I can reproduce using the following steps: 1. Prepare Firefox to subscribe to an RSS feed using live bookmarks 2. Show bookmarks toolbar 3. Click the subscribed feed icon to show the drop-down menu with subscription items 4. Click any item to show the linked web page 5. Repeat step 3. Actual results: The drop-down menu is showing Expected results: The drop-down menu is not showing Side-note: Items are still clickable in the invisible drop-down menu.
The bug appeared on macOS 10.14 Mojave developer beta build 18A293u
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86
Summary: Live toolbar dropdown menu disappears on second click → Live toolbar dropdown menu disappears on second click (macOS Mojave Beta)
Seems like a graphics issue to me, but not clear how anyone would exploit this...
Blocks: mojave
Group: firefox-core-security
This issue is reproducible for me on Build ID 20180611100116 User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:62.0) Gecko/20100101 Firefox/62.0 After step#5, subscribed feed icon is grayed out/not clickable, instead there is option to subscribe to the feed as below https://testing-1.tinytake.com/sf/MjY4MjgzN184MDUxMDY3
Status: UNCONFIRMED → NEW
Component: Untriaged → RSS Discovery and Preview
Ever confirmed: true
(In reply to Kanchan Kumari QA from comment #3) > This issue is reproducible for me on > > Build ID 20180611100116 > User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:62.0) > Gecko/20100101 Firefox/62.0 > > After step#5, subscribed feed icon is grayed out/not clickable, instead > there is option to subscribe to the feed as below > > https://testing-1.tinytake.com/sf/MjY4MjgzN184MDUxMDY3 I'm really confused. Reading comment #0, AFAIK the reporter is reporting an issue with the dropdown from the live bookmarks folder in the bookmarks toolbar. Your screenshot doesn't show the dropdown (and it's not a screencast so I have no idea if you clicked it or not), and the state of the feed icon when opening the feed isn't relevant here... This was also reported specifically on mojave (macOS 10.14 which is in beta), and I can't reproduce on 10.13 with the steps from comment #0.
Flags: needinfo?(kkumari)
Seems I misunderstood it. I didn't see any issue in drop down menu. Please see below the screen cast of steps I performed. https://drive.google.com/file/d/1TtI43iZPeTyUSulQWrNRSML1j4oX7aqT/view?usp=sharing I will try installing macOS 10.14 and verify this issue.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(kkumari)
(In reply to Kanchan Kumari QA from comment #5) > Seems I misunderstood it. I didn't see any issue in drop down menu. Please > see below the screen cast of steps I performed. > > https://drive.google.com/file/d/1TtI43iZPeTyUSulQWrNRSML1j4oX7aqT/ > view?usp=sharing > > I will try installing macOS 10.14 and verify this issue. Hey Kanchan, any luck?
Flags: needinfo?(kkumari)
No luck so far. I tried it on Mac OS 10.14 Beta with the latest Nightly (Build ID 20180619102337) User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:62.0) Gecko/20100101 Firefox/62.0
Flags: needinfo?(kkumari)
Hi, I am meet the same bug.Click on bookmark toolbar folder icon, dropdown menu not showing. macOS console show errors: error 10:26:31.583690 +0800 firefox CGContextSetFillColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.583754 +0800 firefox CGContextSetStrokeColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.583801 +0800 firefox CGContextGetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.583846 +0800 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.583890 +0800 firefox CGContextFillRects: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.583933 +0800 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.584039 +0800 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.584086 +0800 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.586918 +0800 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.586988 +0800 firefox CGContextTranslateCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.587024 +0800 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.587058 +0800 firefox CGContextSetBlendMode: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.587090 +0800 firefox CGContextDrawImage: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.587138 +0800 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:31.587176 +0800 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 10:26:33.851799 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.851836 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.851872 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.851894 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.851926 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.851958 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.851980 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.852025 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.852052 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window error 10:26:33.852162 +0800 WindowServer _CGXPackagesSetWindowConstraints: Invalid window tested on macOS 10.14 beta2, firefox 56.0.2, firefox 62.0
I think this is probably the same issue as bug 1469722, but we'll see. Definitely looks like a widget issue rather than frontend at this point. :haik/:spohl/:mstange, maybe the errors in comment 8 help...
Component: RSS Discovery and Preview → Widget: Cocoa
Product: Firefox → Core
(In reply to :Gijs (he/him) from comment #9) > I think this is probably the same issue as bug 1469722, but we'll see. > Definitely looks like a widget issue rather than frontend at this point. > :haik/:spohl/:mstange, maybe the errors in comment 8 help... It may because the Mojave add whole dark mode,I test switch from Dark mode to Light mode,this bug still happen. See https://developer.apple.com/documentation/appkit/supporting_dark_mode_in_your_interface
(In reply to :Gijs (he/him) from comment #9) > Definitely looks like a widget issue rather than frontend at this point. > :haik/:spohl/:mstange, maybe the errors in comment 8 help... I agree, this is a widget issue. The errors indicate that painting fails, so it's possible that we have a window but are just not painting to it. We need to find out why the CGContext is null. One reason for a null context could be that we have a zero size somewhere.
I can reproduce this issue. Build ID: 20180709100247 User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0 macOS Mojave 10.14 Beta (18A326g) (DP 3) All you need to do is click the down arrow in the address bar more than once in a session. error 11:13:06.602996 -0400 firefox CGContextSetFillColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603058 -0400 firefox CGContextSetStrokeColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603092 -0400 firefox CGContextGetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603123 -0400 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603170 -0400 firefox CGContextFillRects: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603216 -0400 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603490 -0400 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.603546 -0400 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604529 -0400 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604597 -0400 firefox CGContextTranslateCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604643 -0400 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604685 -0400 firefox CGContextSetBlendMode: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604725 -0400 firefox CGContextDrawImage: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604770 -0400 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.604817 -0400 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636195 -0400 firefox CGContextClipToRect: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636290 -0400 firefox CGContextSetFillColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636364 -0400 firefox CGContextSetStrokeColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636428 -0400 firefox CGContextGetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636487 -0400 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636545 -0400 firefox CGContextFillRects: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636600 -0400 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636812 -0400 firefox CGContextClipToRect: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636886 -0400 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.636944 -0400 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637145 -0400 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637201 -0400 firefox CGContextTranslateCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637252 -0400 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637299 -0400 firefox CGContextSetBlendMode: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637346 -0400 firefox CGContextDrawImage: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637399 -0400 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.637451 -0400 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.648917 -0400 firefox CGContextClipToRect: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649020 -0400 firefox CGContextSetFillColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649095 -0400 firefox CGContextSetStrokeColorWithColor: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649161 -0400 firefox CGContextGetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649222 -0400 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649293 -0400 firefox CGContextFillRects: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649359 -0400 firefox CGContextSetCompositeOperation: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649608 -0400 firefox CGContextClipToRect: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649681 -0400 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649738 -0400 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.649962 -0400 firefox CGContextSaveGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.650018 -0400 firefox CGContextTranslateCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.650067 -0400 firefox CGContextScaleCTM: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.650114 -0400 firefox CGContextSetBlendMode: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.650161 -0400 firefox CGContextDrawImage: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.650215 -0400 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable. error 11:13:06.650265 -0400 firefox CGContextRestoreGState: invalid context 0x0. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable.
Here is a backtrace from one of these errors: * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 9.1 * frame #0: 0x00007fff40880e09 CoreGraphics`handle_invalid_context frame #1: 0x00007fff3dae454f AppKit`_setColorWithFillAndStroke + 152 frame #2: 0x00007fff3d7e4641 AppKit`-[NSNextStepFrame drawRect:] + 95 frame #3: 0x00007fff3ded6c69 AppKit`_NSViewDrawRect + 66 frame #4: 0x00007fff3d7a3082 AppKit`-[NSView _drawRect:clip:] + 1753 frame #5: 0x00007fff3d7e397b AppKit`-[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] + 1400 frame #6: 0x00007fff3d7a0fda AppKit`-[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] + 938 frame #7: 0x00007fff3ded78c2 AppKit`-[NSView _oldDisplayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 1887 frame #8: 0x00007fff3d79fdcf AppKit`-[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] + 253 frame #9: 0x00007fff3d79d70b AppKit`-[NSView displayIfNeeded] + 1326 frame #10: 0x00007fff3d79d1ae AppKit`-[NSWindow displayIfNeeded] + 270 frame #11: 0x00007fff3de4ecf1 AppKit`__NSWindowGetDisplayCycleObserverForDisplay_block_invoke + 746 frame #12: 0x00007fff3dc3e9fa AppKit`NSDisplayCycleObserverInvoke + 177 frame #13: 0x00007fff3df20b4c AppKit`NSDisplayCycleFlush + 1094 frame #14: 0x00007fff4b678a93 QuartzCore`CA::Transaction::run_commit_handlers(CATransactionPhase) + 49 frame #15: 0x00007fff4b677156 QuartzCore`CA::Transaction::commit() + 186 frame #16: 0x00007fff3df1fe19 AppKit`__65+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayRefresh]_block_invoke + 274 frame #17: 0x00007fff4010dcb5 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 frame #18: 0x00007fff4010dbe0 CoreFoundation`__CFRunLoopDoObservers + 454 frame #19: 0x00007fff400f4758 CoreFoundation`__CFRunLoopRun + 1172 frame #20: 0x00007fff400f40a7 CoreFoundation`CFRunLoopRunSpecific + 463 frame #21: 0x00007fff3f38614b HIToolbox`RunCurrentEventLoopInMode + 293 frame #22: 0x00007fff3f385d8e HIToolbox`ReceiveNextEventCommon + 371 frame #23: 0x00007fff3f385c02 HIToolbox`_BlockUntilNextEventMatchingListInModeWithFilter + 64 frame #24: 0x00007fff3d67219e AppKit`_DPSNextEvent + 1000 frame #25: 0x00007fff3ddbdaa6 AppKit`-[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1356 frame #26: 0x000000011297c6cc XUL`::-[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:](self=<unavailable>, _cmd=<unavailable>, mask=18446744073709551615, expiration=2001-01-01 00:00:00 UTC, mode=<unavailable>, flag=YES) at nsAppShell.mm:178 [opt] frame #27: 0x00007fff3d66788e AppKit`-[NSApplication run] + 699 frame #28: 0x000000011297d7eb XUL`nsAppShell::Run(this=0x000000011cb991f0) at nsAppShell.mm:735 [opt] frame #29: 0x0000000113c815b9 XUL`nsAppStartup::Run(this=0x000000011cbf0290) at nsAppStartup.cpp:290 [opt] frame #30: 0x0000000113d3a354 XUL`XREMain::XRE_mainRun(this=0x00007ffedfc2a380) at nsAppRunner.cpp:4746 [opt] frame #31: 0x0000000113d3acac XUL`XREMain::XRE_main(this=0x00007ffedfc2a380, argc=<unavailable>, argv=<unavailable>, aConfig=0x00007ffedfc2a530) at nsAppRunner.cpp:4891 [opt] frame #32: 0x0000000113d3b351 XUL`XRE_main(argc=<unavailable>, argv=<unavailable>, aConfig=<unavailable>) at nsAppRunner.cpp:4983 [opt] frame #33: 0x000000010ffd616a firefox`main [inlined] do_main(argc=<unavailable>, argv=<unavailable>, envp=<unavailable>) at nsBrowserApp.cpp:233 [opt] frame #34: 0x000000010ffd6150 firefox`main(argc=<unavailable>, argv=0x00007ffedfc2a988, envp=0x00007ffedfc2a9b8) at nsBrowserApp.cpp:311 [opt] frame #35: 0x00007fff6d211b11 libdyld.dylib`start + 1 frame #36: 0x00007fff6d211b11 libdyld.dylib`start + 1
This is no longer reproducible im my local build when building against the macOS 10.14 SDK.
(In reply to Tim Nguyen :ntim from comment #17) > This is no longer reproducible im my local build when building against the > macOS 10.14 SDK. This is certainly interesting, but a word of caution: To make this build run (instead of crash on startup), some painting code had to be disabled. This could equally explain this. I will continue to look into this.
Assignee: nobody → spohl.mozilla.bugs
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
(In reply to Stephen A Pohl [:spohl] from comment #18) > (In reply to Tim Nguyen :ntim from comment #17) > > This is no longer reproducible im my local build when building against the > > macOS 10.14 SDK. > > This is certainly interesting, but a word of caution: To make this build run > (instead of crash on startup), some painting code had to be disabled. This > could equally explain this. I will continue to look into this. I've been able to confirm that the 10.14 SDK indeed does not exhibit the bug reported here. Using the 10.13 SDK, with the same code disabled to make the 10.14 build run, the issue continues to occur.
Quick update: I have been able to isolate the issue and I'm working on a fix.
Severity: normal → critical
Status: NEW → ASSIGNED
This disables a workaround for an Apple bug described in bug 378645 that got fixed by Apple in 10.14. The workaround caused the issue described in this bug.
Attachment #8993877 - Flags: review?(mstange)
Comment on attachment 8993877 [details] [diff] [review] Patch (removes workaround on 10.14+) Great find! Do you know if the bug is still present on 10.13 on below or is there a chance that we can remove this workaround entirely?
Attachment #8993877 - Flags: review?(mstange) → review+
> // Unless it's explicitly removed from NSApp's "window cache", a popup > // window will keep receiving mouse-moved events even after it's been > // "ordered out" (instead of the browser window that was underneath it, > // until you click on that window). I think this description isn't even right. Mouse move events were sent to the *focused* window, so maybe the problem at the time was that the hidden window was still focused, somehow. We've switch to using NSTrackingAreas for mouse move events since then, which only receive mouse events when the mouse is inside the tracking area, so I think this hasn't been a problem in a long time.
(In reply to Markus Stange [:mstange] from comment #27) > Comment on attachment 8993877 [details] [diff] [review] > Patch > > Great find! Do you know if the bug is still present on 10.13 on below or is > there a chance that we can remove this workaround entirely? I was going the safe route by making the patch 10.14+ specific in case we had to land a fix quickly, and/or if we ran into issues on lower versions of macOS. However, I'll try to request some QA coverage of this patch here on 10.9 and above that removes this workaround completely. I did not encounter any problems on 10.13 in my testing. The test results will tell us which patch to land.
Attachment #8993955 - Flags: review?(mstange)
Attachment #8993877 - Attachment description: Patch → Patch (removes workaround on 10.14+)
Comment on attachment 8993955 [details] [diff] [review] Patch (removes workaround completely) Review of attachment 8993955 [details] [diff] [review]: ----------------------------------------------------------------- Your hesitation is justified. We could land the conservative approach on Beta and this one one Nightly.
Attachment #8993955 - Flags: review?(mstange) → review+
(In reply to Markus Stange [:mstange] from comment #31) > Your hesitation is justified. We could land the conservative approach on > Beta and this one one Nightly. Let's do this. Thanks, Markus!
https://hg.mozilla.org/integration/mozilla-inbound/rev/0df7fb702b9318710488853822f179001e59f5b3 Bug 1468053: Disable a workaround on macOS 10.14+ for an Apple bug involving popup windows that was fixed by Apple in macOS 10.14. r=mstange
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3c7401b4277de9d310c22735d3b2695fd020490 Bug 1468053: Disable a workaround for an Apple bug described in bug 378645 involving popup windows that was fixed by Apple. r=mstange
Improved commit message. Carrying over r+.
Attachment #8993955 - Attachment is obsolete: true
Attachment #8994366 - Flags: review+
Improved commit message. Carrying over r+.
Attachment #8994367 - Flags: review+
Attachment #8993877 - Attachment is obsolete: true
Comment on attachment 8994367 [details] [diff] [review] Patch (removes workaround on 10.14+) Approval Request Comment [Feature/Bug causing the regression]: macOS 10.14 [User impact if declined]: On macOS 10.14, popup windows, such as the address bar, will stop working and not display anymore shortly after being displayed for the first time (sometimes as early as the second time that they should display). [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: Yes, using local builds off of Nightly. [Needs manual test from QE? If yes, steps to reproduce]: Yes. Type in the address bar, go to website, type in address bar again and repeat. Ensure that the popup window, displaying search suggestions and search history, continues to display as expected. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No [Why is the change risky/not risky?]: This patch was intentionally restricted to 10.14 and above to allow for thorough testing of a patch on Nightly that completely disables the workaround on all supported versions of macOS. If there is unexpected fallout from this patch, it will be restricted to 10.14 (which would have a completely broken popup window experience without this patch anyway). [String changes made/needed]: none
Attachment #8994367 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/c3c7401b4277
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(In reply to Raul Gurzau (:RaulGurzau) from comment #38) > https://hg.mozilla.org/mozilla-central/rev/c3c7401b4277 Is Firefox 62 patch coming?
(In reply to Daniel from comment #39) > (In reply to Raul Gurzau (:RaulGurzau) from comment #38) > > https://hg.mozilla.org/mozilla-central/rev/c3c7401b4277 > > Is Firefox 62 patch coming? See comment 37.
Comment on attachment 8994367 [details] [diff] [review] Patch (removes workaround on 10.14+) Fixes a recent regression in 62, makes sense to stabilize in beta for a few weeks before go live, Beta62+
Attachment #8994367 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Hi Andrei, I marked this one as qe_verify+ with the hopes that the QA team will get a chance to test this fix on Nightly63 and Beta62.
Flags: qe-verify+
Flags: needinfo?(andrei.vaida)
Hi Stephen, are we planning to uplift this fix to ESR60.2?
Flags: needinfo?(spohl.mozilla.bugs)
Comment on attachment 8994367 [details] [diff] [review] Patch (removes workaround on 10.14+) (In reply to Ritu Kothari (:ritu) from comment #43) > Hi Stephen, are we planning to uplift this fix to ESR60.2? Yes, I think we should. [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: See "User impact if declined" User impact if declined: On macOS 10.14, popup windows, such as the address bar, will stop working and not display anymore shortly after being displayed for the first time (sometimes as early as the second time that they should display). Fix Landed on Version: Will land in 62 shortly. Risk to taking this patch (and alternatives if risky): Minimal. QA has tested the patch that disables this workaround on all versions of macOS on Nightly and has not found any issues. To further limit the risk, this patch was intentionally restricted to 10.14. If there is unexpected fallout from this patch, it will be restricted to 10.14 (which would have a completely broken popup window experience without this patch anyway). String or UUID changes made by this patch: none
Flags: needinfo?(spohl.mozilla.bugs)
Attachment #8994367 - Flags: approval-mozilla-esr60?
Verified fixed on macOS 10.14 (Beta 4 build - 18A336e) using latest Nightly 63.0a1 (2018-07-26). Scenarios: - Pop-up windows work as expected - Bookmarks toolbar isn't affected after dismissing pop up windows - Search suggestions, browser history bars work as expected - About:preferences Fonts Proportional drop-downs - Menus and buttons are functional, highlighted and clickable when hovered after being covered by pop up windows - Live Feeds notification and drop-down for subscribed feed work as expected
status-firefox63: fixed → verified
Flags: needinfo?(andrei.vaida)
Verified as fixed on macOS 10.14 (Beta build - 18A336e) using Beta 62.0b12(64-bit)(2018-07-27).
Status: RESOLVED → VERIFIED
Comment on attachment 8994367 [details] [diff] [review] Patch (removes workaround on 10.14+) Fixes a serious popup window rendering regression in OSX 10.14. Approved for ESR 60.2 also.
Attachment #8994367 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Verified fixed on macOS 10.14 (Beta build - 18A365a) using the taskcluster build from 2018-08-17 (60.1.1esr).
status-firefox-esr60: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: