1468178 - [Staging] Cannot Save/Publish rollback type recipe

Status: VERIFIED FIXED

(Firefox :: Normandy Server, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]

This relates to the current inability to use Normandy Staging server administration for recipe type rollback.


[Steps:]
1. Login to Normandy Staging. (https://normandy-admin.stage.mozaws.net) - VPN + VPN group required
2. Create/Edit a rollback recipe type, filling in all required info with the expected data.
-the json blob:
{
  "rolloutSlug": "na"
}

3. Press Save.

[Actual Result:]
Recipe cannot be updated. The server failed to respond. Please try again. (JSON.parse: unexpected character at line 1 column 1 of the JSON data)



[Additional Details:]
I. Seems this is similar to bug 1456784 and it is a new regression on staging server.
II. Unknown if the behaviour affects production server environment.

Comment 1

[Michael Cooper [:mythmon]]

This was caused by some older revisions with unexpected data on the stage server. These types of recipes don't exist on prod, so they problem shouldn't show up there.

I've deleted the revisions that were causing problems.

I'm additionally going to work on some extra server validation to prevent this in the future.

Comment 2

[Adrian Florinescu [:aflorinescu]]

(In reply to Michael Cooper [:mythmon] from comment #1)
> This was caused by some older revisions with unexpected data on the stage
> server. These types of recipes don't exist on prod, so they problem
> shouldn't show up there.

I would assume that it was something QA created, can you elaborate what we did wrong?

Comment 3

[Adrian Florinescu [:aflorinescu]]

Problem verified as fixed on staging side, from the rollback recipes point of view;

Comment 4

[Michael Cooper [:mythmon]]

(In reply to Adrian Florinescu [:adrian_sv] from comment #2)
> I would assume that it was something QA created, can you elaborate what we
> did wrong?

It was something that QA created, but you didn't do anything wrong. Specifically, we had a bug on the frontend that sent invalid data to the server, and a bug on the server that didn't validate the data correctly. Both were fixed in https://github.com/mozilla/normandy/pull/1229

The extra work I mentioned in comment 1 is covered by the server side fixes from #1229. I think we're all done here.