Closed Bug 1468197 Opened 8 years ago Closed 8 years ago

remove remaining references in manifests to windows xp

Categories

(Testing :: General, enhancement)

Product:
Testing
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: jmaher, Assigned: nataliaCs)

References

Details

Attachments

(1 file, 3 obsolete files)

Removed win xp reference in manifest files
2.77 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
there are 2 files (5 instances) where we have skip-if conditions in manifests for window xp (5.1) which we can remove: https://searchfox.org/mozilla-central/search?q=os_version.*5.1&case=false&regexp=true&path=*.ini
Assignee: nobody → ncsoregi
Attached patch bug1468197.patch (obsolete) — — Splinter Review
Attachment #8984926 - Flags: review?(jmaher)
Comment on attachment 8984926 [details] [diff] [review] bug1468197.patch Review of attachment 8984926 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8984926 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
When trying to apply the patch, I get the error: applying bug1468197.patch patching file accessible/tests/browser/browser.ini Hunk #1 FAILED at 10 Hunk #2 FAILED at 21 2 out of 2 hunks FAILED -- saving rejects to file accessible/tests/browser/browser.ini.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh bug1468197.patch Do we have to remove the tests name as well?
Flags: needinfo?(jmaher)
I had changed this file and it made it to mozilla-central yesterday: https://hg.mozilla.org/mozilla-central/log/tip/accessible/tests/browser/browser.ini you can see my changes: https://hg.mozilla.org/mozilla-central/diff/b7974b9e7221/accessible/tests/browser/browser.ini in this case we will need to update the source and redo the patch.
Flags: needinfo?(jmaher)
I think we can wait for Natalia, or if there is someone on the current shift who wants some practice.
Attached patch patch redone with specifications (obsolete) — — Splinter Review
Attachment #8984926 - Attachment is obsolete: true
Attachment #8985046 - Flags: review?(jmaher)
Comment on attachment 8985046 [details] [diff] [review] patch redone with specifications Review of attachment 8985046 [details] [diff] [review]: ----------------------------------------------------------------- thanks
Attachment #8985046 - Flags: review?(jmaher) → review+
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/da4e49603752 remove remaining references in manifests to windows xp r=jmaher
Keywords: checkin-needed
Backed out changeset da4e49603752 (bug 1468197) for mochitest ParseError failures on a CLOSED TREE Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb7f17d5496feada5770f25f61d20701060289d Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=da4e49603752ddf885f7561e8268f7aaecacddc7 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=182992571&repo=mozilla-inbound&lineNumber=1379 Log snippet: [task 2018-06-13T03:44:36.003Z] 03:44:36 INFO - 'TEST_SUITE': 'browser-chrome-chunked', [task 2018-06-13T03:44:36.004Z] 03:44:36 INFO - 'USER': 'worker'} [task 2018-06-13T03:44:36.005Z] 03:44:36 INFO - Calling ['/builds/worker/workspace/build/venv/bin/python', '-u', '/builds/worker/workspace/build/tests/mochitest/runtests.py', '--total-chunks', '7', '--this-chunk', '3', '--appname=/builds/worker/workspace/build/application/firefox/firefox', '--utility-path=tests/bin', '--extra-profile-file=tests/bin/plugins', '--symbols-path=https://queue.taskcluster.net/v1/task/K_mFSD5-R1mkRt-1LyO0pQ/artifacts/public/build/target.crashreporter-symbols.zip', '--certificate-path=tests/certs', '--setpref=webgl.force-enabled=true', '--quiet', '--log-raw=/builds/worker/workspace/build/blobber_upload_dir/browser-chrome-chunked_raw.log', '--log-errorsummary=/builds/worker/workspace/build/blobber_upload_dir/browser-chrome-chunked_errorsummary.log', '--use-test-media-devices', '--screenshot-on-fail', '--cleanup-crashes', '--marionette-startup-timeout=180', '--sandbox-read-whitelist=/builds/worker/workspace/build', '--log-raw=-', '--flavor=browser', '--chunk-by-runtime'] with output_timeout 1000 [task 2018-06-13T03:44:36.299Z] 03:44:36 INFO - Checking for ssltunnel processes... [task 2018-06-13T03:44:36.315Z] 03:44:36 INFO - Checking for xpcshell processes... [task 2018-06-13T03:44:36.427Z] 03:44:36 INFO - Traceback (most recent call last): [task 2018-06-13T03:44:36.428Z] 03:44:36 INFO - File "/builds/worker/workspace/build/tests/mochitest/runtests.py", line 3106, in <module> [task 2018-06-13T03:44:36.430Z] 03:44:36 INFO - sys.exit(cli()) [task 2018-06-13T03:44:36.431Z] 03:44:36 INFO - File "/builds/worker/workspace/build/tests/mochitest/runtests.py", line 3102, in cli [task 2018-06-13T03:44:36.432Z] 03:44:36 INFO - return run_test_harness(parser, options) [task 2018-06-13T03:44:36.433Z] 03:44:36 INFO - File "/builds/worker/workspace/build/tests/mochitest/runtests.py", line 3081, in run_test_harness [task 2018-06-13T03:44:36.434Z] 03:44:36 INFO - result = runner.runTests(options) [task 2018-06-13T03:44:36.435Z] 03:44:36 INFO - File "/builds/worker/workspace/build/tests/mochitest/runtests.py", line 2581, in runTests [task 2018-06-13T03:44:36.437Z] 03:44:36 INFO - tests = self.getActiveTests(options) [task 2018-06-13T03:44:36.438Z] 03:44:36 INFO - File "/builds/worker/workspace/build/tests/mochitest/runtests.py", line 1485, in getActiveTests [task 2018-06-13T03:44:36.439Z] 03:44:36 INFO - exists=False, disabled=disabled, filters=filters, **info) [task 2018-06-13T03:44:36.440Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/manifestparser.py", line 795, in active_tests [task 2018-06-13T03:44:36.442Z] 03:44:36 INFO - tests = fn(tests, values) [task 2018-06-13T03:44:36.443Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/filters.py", line 277, in __call__ [task 2018-06-13T03:44:36.444Z] 03:44:36 INFO - tests = list(tests) [task 2018-06-13T03:44:36.445Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/filters.py", line 131, in __call__ [task 2018-06-13T03:44:36.446Z] 03:44:36 INFO - for test in tests: [task 2018-06-13T03:44:36.448Z] 03:44:36 INFO - File "/builds/worker/workspace/build/tests/mochitest/runtests.py", line 1437, in <genexpr> [task 2018-06-13T03:44:36.449Z] 03:44:36 INFO - return (t for t in tests [task 2018-06-13T03:44:36.450Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/filters.py", line 56, in fail_if [task 2018-06-13T03:44:36.451Z] 03:44:36 INFO - for test in tests: [task 2018-06-13T03:44:36.453Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/filters.py", line 44, in run_if [task 2018-06-13T03:44:36.454Z] 03:44:36 INFO - for test in tests: [task 2018-06-13T03:44:36.455Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/filters.py", line 33, in skip_if [task 2018-06-13T03:44:36.457Z] 03:44:36 INFO - if tag in test and parse(test[tag], **values): [task 2018-06-13T03:44:36.458Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/expression.py", line 327, in parse [task 2018-06-13T03:44:36.458Z] 03:44:36 INFO - return ExpressionParser(text, values).parse() [task 2018-06-13T03:44:36.458Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/expression.py", line 313, in parse [task 2018-06-13T03:44:36.459Z] 03:44:36 INFO - (self.text, formatted, self.valuemapping)), None, tb) [task 2018-06-13T03:44:36.459Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/expression.py", line 308, in parse [task 2018-06-13T03:44:36.459Z] 03:44:36 INFO - return self.expression() [task 2018-06-13T03:44:36.461Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/expression.py", line 296, in expression [task 2018-06-13T03:44:36.461Z] 03:44:36 INFO - left = t.led(self, left) [task 2018-06-13T03:44:36.462Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/expression.py", line 134, in led [task 2018-06-13T03:44:36.463Z] 03:44:36 INFO - right = parser.expression(self.lbp) [task 2018-06-13T03:44:36.463Z] 03:44:36 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/manifestparser/expression.py", line 291, in expression [task 2018-06-13T03:44:36.464Z] 03:44:36 INFO - self.token = self.iter.next() [task 2018-06-13T03:44:36.464Z] 03:44:36 INFO - manifestparser.expression.ParseError: could not parse: !e10s || [task 2018-06-13T03:44:36.465Z] 03:44:36 INFO - exception: StopIteration [task 2018-06-13T03:44:36.466Z] 03:44:36 INFO - variables: {u'allow_legacy_extensions': True, u'pgo': False, u'sync': True, u'buildapp': u'browser', u'crashreporter': True, u'addon_signing': True, u'devedition': False, u'require_signing': False, u'platform_guess': u'linux', 'has_sandbox': True, u'appname': u'firefox', u'stylo': True, u'mozconfig': u'/builds/worker/workspace/build/src/.mozconfig', u'topsrcdir': u'/builds/worker/workspace/build/src', u'telemetry': False, 'os_version': StringVersion ('16.04'), 'version': 'Ubuntu 16.04', u'datareporting': True, u'buildtype_guess': u'opt', 'bits': 32, u'bin_suffix': u'', 'webrender': False, u'artifact': False, u'toolkit': u'gtk3', u'healthreport': True, u'updater': True, u'cc_type': u'gcc', u'asan': False, u'release_or_beta': False, u'ccov': False, u'ubsan': False, u'tests_enabled': True, 'linux_distro': 'Ubuntu', u'official': True, u'tsan': False, u'nightly_build': True, 'headless': False, 'e10s': True, u'debug': False, 'nested_oop': False, 'os': u'linux', 'processor': u'x86'} [task 2018-06-13T03:44:36.481Z] 03:44:36 ERROR - Return code: 1 [task 2018-06-13T03:44:36.483Z] 03:44:36 ERROR - No checks run. [task 2018-06-13T03:44:36.483Z] 03:44:36 ERROR - No suite end message was emitted by this harness. [task 2018-06-13T03:44:36.484Z] 03:44:36 INFO - TinderboxPrint: mochitest-browser-chrome-chunked<br/><em class="testfail">T-FAIL</em> [task 2018-06-13T03:44:36.484Z] 03:44:36 ERROR - # TBPL FAILURE # [task 2018-06-13T03:44:36.485Z] 03:44:36 WARNING - setting return code to 2 [task 2018-06-13T03:44:36.486Z] 03:44:36 ERROR - The mochitest suite: browser-chrome-chunked ran with return status: FAILURE
Flags: needinfo?(jmaher)
Flags: needinfo?(apavel)
Comment on attachment 8985046 [details] [diff] [review] patch redone with specifications Review of attachment 8985046 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/tests/browser/browser.ini @@ +26,2 @@ > [browser_shutdown_remote_only.js] > +skip-if = !e10s || # e10s specific test for a11y start/shutdown between parent and content. this is what broke- the extra || note: there is another one below here.
Flags: needinfo?(jmaher)
Attached patch deleted extra characters (obsolete) — — Splinter Review
Attachment #8985046 - Attachment is obsolete: true
Flags: needinfo?(apavel)
Attachment #8985111 - Flags: review?(jmaher)
(In reply to Raul Gurzau (:RaulGurzau) from comment #9) > Backed out changeset da4e49603752 (bug 1468197) for mochitest ParseError > failures on a CLOSED TREE > Removed the extra characters and uploaded the patch, thanks!
Comment on attachment 8985111 [details] [diff] [review] deleted extra characters Review of attachment 8985111 [details] [diff] [review]: ----------------------------------------------------------------- since the original patch was backed out, you will need to land it and this one, thanks for fixing this.
Attachment #8985111 - Flags: review?(jmaher) → review+
mozilla@ubuntu:~/mozilla-unified$ hg qimport bz://1468197 Fetching... done Parsing... done adding 1468197 to series file renamed 1468197 -> bug_correction.patch mozilla@ubuntu:~/mozilla-unified$ hg qpush applying bug_correction.patch patching file accessible/tests/browser/browser.ini Hunk #1 FAILED at 23 1 out of 1 hunks FAILED -- saving rejects to file accessible/tests/browser/brows er.ini.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh bug_correction.patch mozilla@ubuntu:~/mozilla-unified$ nano accessible/tests/browser/browser.ini :joel before the patch got landed without any problems. I looked at line 23 and i didn't change it. Can you take a look please and tell me why it's not working?
Flags: needinfo?(jmaher)
did you apply the first patch and then this patch? The patch you have here requires the first one- I think it is marked as obsolete now and the qimport script fails.
Flags: needinfo?(jmaher)
In the previous patch, testing/firefox-ui/tests/functional/security/manifest.ini was missing. Made a single patch.
Attachment #8985111 - Attachment is obsolete: true
Attachment #8985338 - Flags: review?(jmaher)
Comment on attachment 8985338 [details] [diff] [review] Removed win xp reference in manifest files Review of attachment 8985338 [details] [diff] [review]: ----------------------------------------------------------------- nice
Attachment #8985338 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/07cda954e328 remove remaining references in manifests to windows xp. r=jmaher
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/07cda954e328
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: