Closed
Bug 1468200
Opened 8 years ago
Closed 8 years ago
remove references to 'mulet' in manifest files
Categories
(Testing :: General, enhancement)
Testing
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: noemi_erli)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.86 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
we have 20 references to Mulet in .ini files that we can remove:
https://searchfox.org/mozilla-central/search?q=mulet&path=*.ini
please remove these and related comments.
| Assignee | ||
Comment 1•8 years ago
|
||
Flags: needinfo?(jmaher)
Attachment #8985126 -
Flags: review?(jmaher)
| Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8985126 [details] [diff] [review]
Bug1468200.patch - removed all mulet references from .ini files
Review of attachment 8985126 [details] [diff] [review]:
-----------------------------------------------------------------
I think you went for the easy line deletion instead of just the mulet removal, please see my comments below.
::: accessible/tests/mochitest/events/a11y.ini
@@ -47,4 @@
> [test_scroll.xul]
> [test_scroll_caret.xul]
> [test_selection.html]
> -skip-if = buildapp == 'mulet' || os == 'mac'
we need to keep os == 'mac'
::: dom/canvas/test/webgl-conf/generated-mochitest.ini
@@ -4,4 @@
>
> [DEFAULT]
> subsuite = webgl
> -skip-if = (os == 'linux') && (buildapp == 'mulet')
we need to keep os == 'linux'
::: dom/canvas/test/webgl-conf/mochitest-errata.ini
@@ -23,5 @@
>
> [DEFAULT]
> subsuite = webgl
> -# Bug 1136181 disabled on Mulet for intermittent failures
> -skip-if = (os == 'linux') && (buildapp == 'mulet')
we need to keep os == 'linux'
@@ -199,4 @@
> [generated/test_conformance__misc__type-conversion-test.html]
> fail-if = (os == 'linux')
> # Resets device on Android 2.3.
> -# Crashes on desktop Linux, and Mulet Linux x64.
we need to keep the comment regarding linux
@@ -362,4 @@
>
> ########################################################################
> # "tst-linux{32,64}-spot-NNN" Slaves:
> -# Android 2.3, Linux, and Mulet.
please keep the comment and jus tremove the Mulet part.
::: layout/forms/test/mochitest.ini
@@ -55,4 @@
> skip-if = toolkit == 'android' # Bug 1021644 - Fails when pushed into a different chunk on Android
> [test_bug1111995.html]
> [test_bug1301290.html]
> -skip-if = buildapp == 'mulet' || toolkit == 'android'
please keep toolkit == 'android'
Attachment #8985126 -
Flags: review?(jmaher) → review-
| Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(jmaher)
| Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8985126 -
Attachment is obsolete: true
Attachment #8985147 -
Flags: review?(jmaher)
| Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8985147 [details] [diff] [review]
bug1468200.patch - removed all mulet references from .ini files
Review of attachment 8985147 [details] [diff] [review]:
-----------------------------------------------------------------
looks good
Attachment #8985147 -
Flags: review?(jmaher) → review+
| Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4e6978b9f7
remove references to 'mulet' in manifest files. r=jmaher
Keywords: checkin-needed
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•8 years ago
|
Assignee: nobody → nerli
You need to log in
before you can comment on or make changes to this bug.
Description
•