Closed Bug 1468201 Opened 6 years ago Closed 6 years ago

remove old references in manifests to windows 8 since we don't run tests on there anymore

Categories

(Core :: Graphics, enhancement)

54 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jmaher, Assigned: ccoroiu)

References

Details

Attachments

(1 file, 5 obsolete files)

Assignee: nobody → ccoroiu
Attachment #8984966 - Flags: review?(jmaher)
Comment on attachment 8984966 [details] [diff] [review] Removed old references in manifests to win8 Review of attachment 8984966 [details] [diff] [review]: ----------------------------------------------------------------- we need to keep the win 7 (7.1.7601) reference, otherwise this would be r+. Since we will be redoing this, please feel free to remove the old win10 references mentioned. ::: testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_004.html.ini @@ -4,5 @@ > - [drawFocusIfNeeded does draw a focus ring if the element is in focus.] > - expected: > - if not debug and (os == "win") and (version == "6.2.9200") and (processor == "x86_64") and (bits == 64): FAIL > - if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL > - if not debug and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL we till need the 6.1.7601 clause here ::: testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.gradient.interpolate.overlap.html.ini @@ -6,2 @@ > if debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL > if not debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL if you are redoing this patch, lets remove the 10.0.10240 references ::: testing/web-platform/meta/2dcontext/path-objects/2d.path.arc.selfintersect.1.html.ini @@ -2,5 @@ > - [arc() with lineWidth > 2*radius is drawn sensibly] > - expected: > - if (os == "win") and (version == "6.2.9200") and (processor == "x86_64") and (bits == 64): FAIL > - if debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL > - if not debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL this bug isn't about old windows 10 versions, but in this case it is ok. ::: testing/web-platform/meta/2dcontext/path-objects/2d.path.rect.zero.3.html.ini @@ -6,2 @@ > if debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL > if not debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL if you are redoing this patch, lets remove the 10.0.10240 references ::: testing/web-platform/meta/2dcontext/path-objects/2d.path.stroke.scale2.html.ini @@ -6,2 @@ > if debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL > if not debug and (os == "win") and (version == "10.0.10240") and (processor == "x86_64") and (bits == 64): FAIL if you are redoing this patch, lets remove the 10.0.10240 references
Attachment #8984966 - Flags: review?(jmaher) → review-
Attached patch removed old references (obsolete) — Splinter Review
Attachment #8984966 - Attachment is obsolete: true
Attachment #8985085 - Flags: review?(jmaher)
Comment on attachment 8985085 [details] [diff] [review] removed old references Review of attachment 8985085 [details] [diff] [review]: ----------------------------------------------------------------- if you want to do a bit more, there are some suggestions and I am happy review again. otherwise, lets land this :) ::: testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini @@ -7,2 @@ > if not debug and (os == "mac") and (version == "OS X 10.6.8") and (processor == "x86_64") and (bits == 64): FAIL > if not debug and (os == "mac") and (version == "OS X 10.9") and (processor == "x86_64") and (bits == 64): FAIL oh, these two osx lines (10.6.8 and 10.9) could be removed if you want to; @@ -10,1 @@ > if not debug and (os == "mac") and (version == "OS X 10.8") and (processor == "x86_64") and (bits == 64): FAIL this osx line could be removed as well.
Attachment #8985085 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4) > Comment on attachment 8985085 [details] [diff] [review] > removed old references > > Review of attachment 8985085 [details] [diff] [review]: > ----------------------------------------------------------------- > > if you want to do a bit more, there are some suggestions and I am happy > review again. otherwise, lets land this :) > > ::: > testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.pattern.image. > broken.html.ini > @@ -7,2 @@ > > if not debug and (os == "mac") and (version == "OS X 10.6.8") and (processor == "x86_64") and (bits == 64): FAIL > > if not debug and (os == "mac") and (version == "OS X 10.9") and (processor == "x86_64") and (bits == 64): FAIL > > oh, these two osx lines (10.6.8 and 10.9) could be removed if you want to; > > @@ -10,1 @@ > > if not debug and (os == "mac") and (version == "OS X 10.8") and (processor == "x86_64") and (bits == 64): FAIL > > this osx line could be removed as well. Will make the modifications you mentioned.
Attached patch updated patch (obsolete) — Splinter Review
:jmaher: there were no mac references in any of these files, are you referring to another manifest edit?
Attachment #8985085 - Attachment is obsolete: true
Attachment #8985110 - Flags: review?(jmaher)
Comment on attachment 8985110 [details] [diff] [review] updated patch Review of attachment 8985110 [details] [diff] [review]: ----------------------------------------------------------------- I think there are 2 different patches on this bug in progress- there are more files found in the original link than are in this patch. ::: testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini @@ +4,3 @@ > expected: > if not debug and (os == "linux") and (version == "Ubuntu 12.04") and (processor == "x86_64") and (bits == 64): FAIL > if not debug and (os == "linux") and (version == "Ubuntu 12.04") and (processor == "x86") and (bits == 32): FAIL we could also get rid of the two ubuntu 12.04 references here.
Attachment #8985110 - Flags: review?(jmaher) → review+
Attachment #8985110 - Attachment is obsolete: true
Attachment #8985562 - Flags: review?(jmaher)
Comment on attachment 8985562 [details] [diff] [review] Removed old references in manifests to win8 and win10 Review of attachment 8985562 [details] [diff] [review]: ----------------------------------------------------------------- looks good
Attachment #8985562 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/20ab1c225917 Removed old references in manifests to win8 and win10. r=jmaher
Keywords: checkin-needed
(In reply to Eliza Balazs [:ebalazs_] from comment #11) > Backed out changeset 20ab1c225917 (bug 1468201) for perma failures in > /2dcontext/fill-and-stroke-style/2d.pattern.image.broken.html > > Push with failures: > https://treeherder.mozilla.org/#/jobs?repo=mozilla- > inbound&revision=20ab1c2259176b005113156759fc455aa4501258&selectedJob=1833097 > 33 > > Failure log: > https://treeherder.mozilla.org/logviewer.html#?job_id=183309733&repo=mozilla- > inbound&lineNumber=2914 > > Backout: > https://treeherder.mozilla.org/#/jobs?repo=mozilla- > inbound&revision=6bfed2badaa331c483c731fe4ae2d4c999341f3e :joel this failed on 2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html with the error message being "Canvas test: 2d.pattern.image.broken - assert_throws: function "function() { ctx.createPattern(img, 'repeat'); }" did not throw" and in the patch testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini was completely deleted because there were no conditions left after updating the manifest. How should we redo this patch in order for this permafail to no longer appear?
Flags: needinfo?(jmaher)
thanks for backing this out :apavel, I see the problem there was a 'disabled' clause in the manifest that I overlooked. So we need to fix the patch to have the one file added back with the subtest/condition removed.
Attachment #8985562 - Attachment is obsolete: true
Attachment #8985826 - Flags: review?(jmaher)
Comment on attachment 8985826 [details] [diff] [review] Removed old references in manifests to win8 and win10. Review of attachment 8985826 [details] [diff] [review]: ----------------------------------------------------------------- 2 small things here. ::: testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_004.html.ini @@ -7,1 @@ > if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL odd, there is a remaining 5.1.2600 reference here, we really should remove that as well. ::: testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini @@ -1,3 @@ > [2d.pattern.image.broken.html] > [Canvas test: 2d.pattern.image.broken] > - disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1016482 we are removing this disabled line, this needs to stay in.
Attachment #8985826 - Flags: review?(jmaher) → review-
Flags: needinfo?(jmaher)
Attachment #8985826 - Attachment is obsolete: true
Attachment #8986230 - Flags: review?(jmaher)
Comment on attachment 8986230 [details] [diff] [review] bug_1468201.patch Review of attachment 8986230 [details] [diff] [review]: ----------------------------------------------------------------- thanks
Attachment #8986230 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: