Closed
Bug 1468202
Opened 6 years ago
Closed 6 years ago
remove references to old platforms (windows 8) in manifest files
Categories
(Core :: Storage: IndexedDB, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: ccoroiu)
References
Details
Attachments
(1 file, 1 obsolete file)
3.19 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
There are 7 instances found here:
https://searchfox.org/mozilla-central/search?q=version.*6.2&case=false®exp=true&path=testing%2Fweb-platform%2Fmeta%2FindexedDB
please include these in a single patch.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8984961 -
Flags: review?(jmaher)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 8984961 [details] [diff] [review]
Removed references to old win8 in manifest files
Review of attachment 8984961 [details] [diff] [review]:
-----------------------------------------------------------------
for the 3 cases where we are removing the only condition, lets remove the entire file.
::: testing/web-platform/meta/IndexedDB/fire-error-event-exception.html.ini
@@ -1,3 @@
> [fire-error-event-exception.html]
> - disabled:
> - if not debug and (os == "win") and (version == "6.2.9200"): https://bugzilla.mozilla.org/show_bug.cgi?id=1347505
in this case we want to remove the entire file, so:
hg rm testing/web-platform/meta/IndexedDB/fire-error-event-exception.html.ini
::: testing/web-platform/meta/IndexedDB/idbindex_getAll.html.ini
@@ -1,3 @@
> [idbindex_getAll.html]
> - disabled:
> - if (os == "win") and (version == "6.2.9200") and not debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1364124
we can remove the entire file
::: testing/web-platform/meta/IndexedDB/idbindex_getAllKeys.html.ini
@@ -1,3 @@
> [idbindex_getAllKeys.html]
> - disabled:
> - if (os == "win") and (version == "6.2.9200") and not debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1364124
we can remove the entire file
Attachment #8984961 -
Flags: review?(jmaher) → review-
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8984961 -
Attachment is obsolete: true
Attachment #8984963 -
Flags: review?(jmaher)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ccoroiu
Updated•6 years ago
|
Priority: -- → P2
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8984963 [details] [diff] [review]
Removed references to old win8 in manifest files
Review of attachment 8984963 [details] [diff] [review]:
-----------------------------------------------------------------
nice
Attachment #8984963 -
Flags: review?(jmaher) → review+
Reporter | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/208b95ffd520
Removed references to old win8 in manifest files. r=jmaher
Keywords: checkin-needed
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•