remove references to old platforms (windows 8) in manifest files

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P2
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jmaher, Assigned: ccoroiu)

Tracking

54 Branch
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

11 months ago
Attachment #8984961 - Flags: review?(jmaher)
(Reporter)

Comment 2

11 months ago
Comment on attachment 8984961 [details] [diff] [review]
Removed references to old win8 in manifest files

Review of attachment 8984961 [details] [diff] [review]:
-----------------------------------------------------------------

for the 3 cases where we are removing the only condition, lets remove the entire file.

::: testing/web-platform/meta/IndexedDB/fire-error-event-exception.html.ini
@@ -1,3 @@
>  [fire-error-event-exception.html]
> -  disabled:
> -    if not debug and (os == "win") and (version == "6.2.9200"): https://bugzilla.mozilla.org/show_bug.cgi?id=1347505

in this case we want to remove the entire file, so:
hg rm testing/web-platform/meta/IndexedDB/fire-error-event-exception.html.ini

::: testing/web-platform/meta/IndexedDB/idbindex_getAll.html.ini
@@ -1,3 @@
>  [idbindex_getAll.html]
> -  disabled:
> -    if (os == "win") and (version == "6.2.9200") and not debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1364124

we can remove the entire file

::: testing/web-platform/meta/IndexedDB/idbindex_getAllKeys.html.ini
@@ -1,3 @@
>  [idbindex_getAllKeys.html]
> -  disabled:
> -    if (os == "win") and (version == "6.2.9200") and not debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1364124

we can remove the entire file
Attachment #8984961 - Flags: review?(jmaher) → review-
(Assignee)

Comment 3

11 months ago
Attachment #8984961 - Attachment is obsolete: true
Attachment #8984963 - Flags: review?(jmaher)
(Assignee)

Updated

11 months ago
Assignee: nobody → ccoroiu

Updated

11 months ago
Priority: -- → P2
(Reporter)

Comment 4

11 months ago
Comment on attachment 8984963 [details] [diff] [review]
Removed references to old win8 in manifest files

Review of attachment 8984963 [details] [diff] [review]:
-----------------------------------------------------------------

nice
Attachment #8984963 - Flags: review?(jmaher) → review+
(Reporter)

Updated

11 months ago
Keywords: checkin-needed

Comment 5

11 months ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/208b95ffd520
Removed references to old win8 in manifest files. r=jmaher
Keywords: checkin-needed

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/208b95ffd520
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.