1468492 - Enhance handling of mail attachments in SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1468079 +++

We are somewhat behind Thunderbird in handling attachements. A few bugs should be ported for a better user experience and to provide enhanced security. See user story.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1468492-part1-feedsimages-257.patch

Part 1 good for 2.57+

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1468492-part1-feedsimages.patch

Part 1 good for 2.49 and patched up 2.53

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1468492-part2-picturefeeds.patch

Part 2 good for all versions

The feed from Bug 953165 now shows the picture

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1468492-part3-externalattachments1.patch

Part 3. Port Bug 1284004 part 1 only.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1468492-part4-attachmentname.patch

Part 4. Port Bug 1411732. See the testmessage there. Do not add it here or this bug needs to locked down afterwards.

Comment 6

[Ian Neal]

Comment on attachment 8985182 [details] [diff] [review]
1468492-part1-feedsimages-257.patch

>+          img.addEventListener("load", function(event) {
>+            if (this.clientWidth > this.parentNode.clientWidth) {
>+              img.setAttribute("overflowing", "true");
>+              img.setAttribute("shrinktofit", "true");
>+            }
>+          });

This includes part of Bug 534083 - Provide image scaling for embedded images, shouldn't the rest of it be ported into suite's mailWindow.js (messagePaneOnResize and messagePaneOnClick functions)?
Are there other partial ports?

>+  let match = GlodaUtils.PART_RE.exec(url);
>+  this.partID = match && match[1];

Currently partID is not used, do you have patches for porting Bug 736881 - Improve calculation of attached message size and previous related patches?

Comment 7

[Ian Neal]

Comment on attachment 8985183 [details] [diff] [review]
1468492-part1-feedsimages.patch

Same questions as before

Comment 8

[Ian Neal]

Comment on attachment 8985184 [details] [diff] [review]
1468492-part2-picturefeeds.patch

LGTM r/a=me

Comment 9

[Ian Neal]

Comment on attachment 8985185 [details] [diff] [review]
1468492-part3-externalattachments1.patch

r/a=me assuming previous questions are resolved

Comment 10

[Ian Neal]

Comment on attachment 8985186 [details] [diff] [review]
1468492-part4-attachmentname.patch

LGTM r/a=me

Comment 11

[Frank-Rainer Grahl (:frg)]

>  img.addEventListener("load", function(event) {

Thanks. You are right wrt the event listener. Copied too much here. I will rip it out and retest. We already have a bug for the size code. If I find some time I will look at it.

> Currently partID is not used

This is now also needed for setting the correct image source:
> img.src = attachment.url;

I am a bit unfamiliar with mailnews code flow and just wanted to be sure I didn't miss anything and stay as close as possible to mail. Looked also at the size code then and decided not to port the other parts for size in this bug. These are not relevant here.

Comment 12

[Frank-Rainer Grahl (:frg)]

partID also needed for part 2.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c77311a28429
Part 1. Port Bug 873872 [Feed messages with image attachments and Display Inline set should show the remote image] to SeaMonkey. r=IanN
https://hg.mozilla.org/comm-central/rev/25106ab79502
Part 2. Port Bug 953165 [Picture in feed not showing] to SeaMonkey. r=IanN
https://hg.mozilla.org/comm-central/rev/af303b1b2f3e
Part 3. Port Bug 1284004 [Improve remote attachment handling, Part 1] to SeaMonkey. r=IanN
https://hg.mozilla.org/comm-central/rev/e884168fb695
Part 4. Port Bug 1411732 [prevent file name tricks for external http attachments] to SeaMonkey. r=IanN

Comment 14

[Frank-Rainer Grahl (:frg)]

2.49.4 / ESR52 part 1 to part 4:
https://hg.mozilla.org/releases/comm-esr52/rev/251973ed8f779f930137a4b7195471e8a70db53c
https://hg.mozilla.org/releases/comm-esr52/rev/6dbea26cd8da41b13204abc6fb92f8436f956959
https://hg.mozilla.org/releases/comm-esr52/rev/292aa6de4ff3f7677b95d1d9986610a495970f09
https://hg.mozilla.org/releases/comm-esr52/rev/cd762a183d3be8e0e18a883fe9599a08368c8120

2.57 / ESR60 part 1 to part 4:
https://hg.mozilla.org/releases/comm-esr60/rev/c5b6694800a75d997f7e9d5a3e2410e5393d7a2a
https://hg.mozilla.org/releases/comm-esr60/rev/774b3482506b979ecff7b0d5c1f9a4201aef6797
https://hg.mozilla.org/releases/comm-esr60/rev/d371734c7390fdc0926bf87958be7e9cc783ceb6
https://hg.mozilla.org/releases/comm-esr60/rev/876cea63d34d1c2989037d514cc55f57fdb7e03d