The default bug view has changed. See this FAQ.

Feed messages with image attachments and Display Inline set should show the remote image

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Message Reader UI
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

4 years ago
The mime parser creates an <img> element with a src of a mailbox:// url, which doesn't apply as feed attachments are always remote links and there's nothing valid in that there part to stream.  The src should be set with the link url.
(Assignee)

Comment 1

4 years ago
Created attachment 751503 [details] [diff] [review]
patch
Assignee: nobody → alta88
Attachment #751503 - Flags: review?(mkmelin+mozilla)
Attachment #751503 - Flags: feedback?(mconley)
(Assignee)

Comment 2

4 years ago
Also, I had expected Filelink image attachments to also display inline.  Is there a reason they don't (unless it's a business agreement reason).  It would be easy enough to extract a X-Mozilla-Cloud-Part url and do the same..
(Assignee)

Comment 3

4 years ago
Created attachment 751722 [details] [diff] [review]
updated


robustness tweak for GlodaUtils.PART_RE regex failing to take into account a ? in a url.
Attachment #751503 - Attachment is obsolete: true
Attachment #751503 - Flags: review?(mkmelin+mozilla)
Attachment #751503 - Flags: feedback?(mconley)
Attachment #751722 - Flags: review?(mkmelin+mozilla)
Attachment #751722 - Flags: feedback?(mconley)

Comment 4

4 years ago
Do you have a sample feed url?
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 5

4 years ago
Since file:// urls can't be loaded in a messagepane doc, I use these; a recent guardian item had 19 media (.jpg) attachments:

http://feeds.guardian.co.uk/theguardian/sport/rss
http://news.nationalgeographic.com/index.rss
(Assignee)

Comment 6

4 years ago
Created attachment 752220 [details] [diff] [review]
shrinktofit update


tweak to ensure shrink to fit works nicely.
Attachment #751722 - Attachment is obsolete: true
Attachment #751722 - Flags: review?(mkmelin+mozilla)
Attachment #751722 - Flags: feedback?(mconley)
Attachment #752220 - Flags: review?(mkmelin+mozilla)
Attachment #752220 - Flags: feedback?(mconley)

Comment 7

4 years ago
Comment on attachment 752220 [details] [diff] [review]
shrinktofit update

Review of attachment 752220 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. r=mkmelin

::: mail/base/content/msgHdrViewOverlay.js
@@ +684,5 @@
>        if (!currentAttachments.length && this.mSaveHdr)
>          this.mSaveHdr.markHasAttachments(false);
> +
> +      let browser = getBrowser();
> +      let inlineAttachments = Services.prefs.getBoolPref("mail.inline_attachments");

you could just inline inlineAttachments since it's used only once

@@ +698,5 @@
> +              break;
> +            }
> +            else {
> +              // GlodaUtils.PART_RE fails to extract a partID for urls with
> +              // an embedded ?, at least.  So, check the filename too.  Frontend

please don't double space for new sentences
Attachment #752220 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 8

4 years ago
Created attachment 753283 [details] [diff] [review]
for checkin


updated for comments.
Attachment #752220 - Attachment is obsolete: true
Attachment #752220 - Flags: feedback?(mconley)
Attachment #753283 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5b57f54e2cb0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.