1468654 - Firefox 60.0.2 not rendering columns in list correctly

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[bd.edelman]

Attachment: purposes.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce:

I have a ul to which I am applying columns: 3 to. Each li has an input/custom label. The custom label has the following relevant css. Note the custom label checkbox is being made with FontAwesome5

input[type="checkbox"] + label:before {
  content: '';
  display: block;
  width: 16px;
  height: 16px;
  border: 1px solid black;
  border-radius: 2px;
  position: absolute;
  background-color: white;
  left: 0;
  top: 5px;
}



Actual results:

The height 16px is still being applied to the element, but is actually getting rendered as over 18px when I inspect the element. All others are exactly 16px. This only seems to happen at the top of the last column. If I go in to the inspector and click on the height to disable it and then reenable it, it renders perfectly. Have tried adding !important (god help us) to the height, and adding a min-height.


Expected results:

No visual bug on the last column should appear.

Comment 1

[Andre Klapper]

Could you please attach a self-contained minimal testcase as HTML including CSS? Thanks.

Comment 2

[Alice0775 White]

I can reproduce the layout problem on Windows10 Noghtly62.0a1 x64. And this has been regressed since 56.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e6e712904806da25a9c8f48ea4533abe7c6ea8f4&tochange=d6bf703c5deaf1e328babd03d5e68ff2a4ffe10e

Via local build,
Last good : 395b6c53e42b
First bad : 1e3130e96f03

Regressed by: 	1e3130e96f03	L. David Baron — Bug 1308876 - Mark child frames as dirty before starting reflow of the parent, so that if we reflow a child twice, it's only dirty the first time. r=dholbert

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Current steps to reproduce seem to be to check the "PC Exhibition Prep" checkbox at the bottom of the first column of https://codepen.io/bedelman851/pen/oyWpGq , and then the columns move around and I see the glitch at the top of the third column.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Appears to be fixed by the patches in bug 1420528.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Will be fixed by bug 1420528.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fixed by landing of bug 1420528.

Comment 8

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 62.0a1 (2018.06.13) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 70.0b9 on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.13.6.