floated element is missing, after column-break in multicol
Categories
(Core :: Layout, defect, P3)
Tracking
()
People
(Reporter: ivan.kuckir, Assigned: dbaron)
References
(Regression)
Details
(Keywords: regression)
Attachments
(5 files)
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce: Go to https://www.photopea.com/ . Press More - Keyboard Shortcuts Actual results: You should see the list of shortcuts in this program. Each item contains the name of the shortcut on the left, and the actual shortcut (bold) on the right. Expected results: In firefox, some shortcuts (<span> elements) are missing: https://i.imgur.com/cqooghL.png . But they do exist in HTML and are rendered by other browsers (e.g. by Chrome).
Comment 1•7 years ago
|
||
Not yet investigated deeply but this is the same symptom as what I've encountered on my site and explained here: https://www.fxsitecompat.com/en-CA/docs/2017/certain-multi-column-layouts-may-balance-unevenly-or-lack-elements-randomly/
Updated•7 years ago
|
Comment 2•7 years ago
|
||
[Tracking Requested - why for this release]: regression in 57
Comment 3•7 years ago
|
||
I can't test it now but this should actually be a regression in 56.
Comment 4•7 years ago
|
||
Oh, you're right.
Reporter | ||
Comment 5•7 years ago
|
||
So is it a bug or not? Maybe "floats" are forbidden in columns by W3C, or something ... If it is not a bug, can you recommend me some elegant solution?
Comment 6•7 years ago
|
||
It's just a bug in Firefox 56 and later.
Comment 7•7 years ago
|
||
If it helps, I just ran mozregression and received this range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e6e712904806da25a9c8f48ea4533abe7c6ea8f4&tochange=d6bf703c5deaf1e328babd03d5e68ff2a4ffe10e
Comment 8•7 years ago
|
||
Ah, silly me. I now see that you had already done so in the other bug.
Comment 9•7 years ago
|
||
OK so, a regression from 56 from bug 1308876. Is this something we think might be widespread? Tracking for 58/59 to make sure we have a chance to uplift any fix. David, can you help find someone to investigate?
Updated•7 years ago
|
Updated•7 years ago
|
Comment 10•7 years ago
|
||
Here's a reduced testcase (reduced from photopea.com). It just involves a float being pushed to the second column of a multicol, basically -- and the float doesn't end up painting.
Updated•7 years ago
|
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Too late to fix for 58 but I'll leave this open for 59.
Comment 12•6 years ago
|
||
We can still take a patch for 59 but I'll make this fix optional based on the priority, and since it isn't a new regression.
Updated•6 years ago
|
Comment 13•6 years ago
|
||
Not going to make 59 at this point.
Comment 14•6 years ago
|
||
Not a new regression, I'll call this fix-optional for 60.
Updated•6 years ago
|
Assignee | ||
Comment 15•6 years ago
|
||
Gerald has been looking into some of these; I think the analysis from bug bug 1459937 that has led to bug 1474771 will likely help with many.
Updated•5 years ago
|
Assignee | ||
Comment 17•5 years ago
|
||
This is not fixed by bug 1474771, so it needs further investigation.
Assignee | ||
Comment 18•5 years ago
|
||
Here's a try run with a fix.
Assignee | ||
Comment 19•5 years ago
|
||
Note that I introduced a blank line to make the intent of the NOTE
clearer, which I had to research. I think it's clear it covers the
three tests below it based on
https://hg.mozilla.org/mozilla-central/rev/53489b3e14f1 and
https://bugzilla.mozilla.org/show_bug.cgi?id=967311#c0 .
Co-authored-by: L. David Baron <dbaron@dbaron.org>
Co-authored-by: Daniel Holbert <dholbert@cs.stanford.edu>
Assignee | ||
Comment 20•5 years ago
|
||
Assignee | ||
Comment 21•5 years ago
|
||
Interestingly, my current patch fixes the test when loaded in the browser, but not when loaded in the reftest harness.
Assignee | ||
Comment 22•5 years ago
|
||
While in the browser, the previous patch was sufficient to fix this
reftest, in the reftest harness both the previous patch and this patch are
needed. (I'm not sure why.) This patch alone doesn't fix the test in either
the browser or the reftest harness.
Assignee | ||
Comment 23•5 years ago
|
||
Here's a new try run.
Assignee | ||
Comment 24•5 years ago
•
|
||
So this patch series fixes this bug and three other regressions from bug 1308876.
I did a little more testing; it turns out that this bug is the only one of the four that behaves differently as a function of whether column-span
is enabled. In particular:
- this bug's testcase, with
column-span
enabled, is fixed by patch 2 on its own - this bug's testcase, with
column-span
disabled, is fixed by the combination of patch 2 and patch 3 (both are needed) - bug 1406291 is fixed by patch 3 on its own
- bug 1411799 is fixed by patch 2 and patch 3 (both are needed)
- bug 1468654 is fixed by patch 2 on its own
At a minimum I'll add more comments to the commit messages, although really I should probably add reftests for the other three bugs as well.
Assignee | ||
Comment 25•5 years ago
|
||
And I should also note I have additional patches on top of these to fix bug 1404868 (and hopefully other regressions as well).
Assignee | ||
Comment 26•5 years ago
|
||
Assignee | ||
Comment 27•5 years ago
|
||
Here's a new try run with additional tests (and revised commit messages).
Comment 28•5 years ago
|
||
Pushed by dbaron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df63a9466390 Add reftest. r=TYLin https://hg.mozilla.org/integration/autoland/rev/0e809359904a Add reftests for other bugs fixed by this bug. r=TYLin https://hg.mozilla.org/integration/autoland/rev/9d335538cabc When a frame that was incomplete doesn't fit, make sure we reflow it again. r=TYLin https://hg.mozilla.org/integration/autoland/rev/a5d545e31781 As with constrained block-size, reflow lines with floats when block-size was *previously* constrained. r=TYLin
Comment 29•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df63a9466390
https://hg.mozilla.org/mozilla-central/rev/0e809359904a
https://hg.mozilla.org/mozilla-central/rev/9d335538cabc
https://hg.mozilla.org/mozilla-central/rev/a5d545e31781
Assignee | ||
Comment 30•5 years ago
|
||
For what it's worth, I suspect both of these fixes may have been too specific. I think bug 1404868 probably did a better job of fixing the issues with floats; bug 1406163 probably covers at least part of doing a better job of the problem of incomplete frames that didn't fit.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•2 years ago
|
Description
•