1468755 - Cardbook issue between TB 60 beta 4 and beta 5

Status: RESOLVED DUPLICATE of bug 1468912

(Thunderbird :: Untriaged, defect)

Description

[Sisim Biva]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180605171542

Steps to reproduce:

We are investigating an issue with the add-on Cardbook: TB60 beta4 does not show this problem, while beta5 shows the problem. In order to investigate, where can we find the exact and full changelog between these 2 version?

See issue here: https://gitlab.com/CardBook/CardBook/issues/306

Thanks

Comment 1

[Sisim Biva]

Hello,

We really need help from your team. We might have found a cause of the bug, but we're not sure. We made a diff between beta 4 and beta 5 and the file thunderbird-60.0b5\mozilla\netwerk\protocol\http\HttpBaseChannel.cpp has changed a little, replacing :

mLoadInfo->SetAllowInsecureRedirectToDataURI(false);

with 

if (mLoadInfo) {
    mLoadInfo->SetAllowInsecureRedirectToDataURI(false);
  }

maybe it's the cause.

Any idea in order the add-on can work? 

In addition, we are not able to compile (not enough space on our disk): could you compile a beta version reverting this change in order we can test CardBook?

Thank you

Comment 2

[Philippe VIGNEAU]

here is one CardBook log :

2018.06.18 14:56:39:204 : Validation module : Discovering phase 1 request on https://webcloud7.zaclys.com/.well-known/carddav …
2018.06.18 14:56:39:206 : Validation module : debug mode : method : (new String("PROPFIND"))
2018.06.18 14:56:39:206 : Validation module : debug mode : headers : (new String("depth: \"0\", content-type: \"application/xml; charset=utf-8\", User-Agent: \"Thunderbird CardBook/29.6\", Authorization: \"Basic \"*****\""))
2018.06.18 14:56:39:206 : Validation module : debug mode : body : (new String("<?xml version=\"1.0\" encoding=\"utf-8\"?><D:propfind xmlns:D=\"DAV:\"><D:prop><D:current-user-principal/></D:prop></D:propfind>"))
2018.06.18 14:56:39:207 : Validation module : debug mode : username : (new String("11152"))
2018.06.18 14:56:39:207 : Validation module : debug mode : url : (new String("https://webcloud7.zaclys.com/.well-known/carddav"))
2018.06.18 14:56:39:925 : Validation module : debug mode : response text : (new String("<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<d:multistatus xmlns:d=\"DAV:\" xmlns:s=\"http://sabredav.org/ns\" xmlns:card=\"urn:ietf:params:xml:ns:carddav\"><d:response><d:href>/remote.php/carddav/</d:href><d:propstat><d:prop><d:current-user-principal><d:unauthenticated/></d:current-user-principal></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>\n"))
2018.06.18 14:56:39:925 : Validation module : debug mode : response code : (new Number(207))

the response code from the server is successfull but we get <d:unauthenticated/> in the response...

Comment 3

[Philippe VIGNEAU]

and this issue happens only on fresh Thunderbird profile

Comment 4

[Jorg K (CEST = GMT+2)]

The change in comment #1 just avoids dereferencing of a null pointer.

Here are the things that changed between beta 4 and beta 5:
https://hg.mozilla.org/releases/comm-beta/pushloghtml?fromchange=f51daa333cb3&tochange=ec17f661d2d4

What would have affected Cardbook here? And what is the exact issue?

Comment 5

[Philippe VIGNEAU]

seems not related to the changes you listed ... who does change the file HttpBaseChannel.cpp ?

The issue is that it's not possible to connect a remote address book with a fresh Thunderbird profile...

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Philippe VIGNEAU from comment #5)
> seems not related to the changes you listed ... who does change the file
> HttpBaseChannel.cpp ?
That's in Mozilla core, here are the changes on the beta branch:
https://hg.mozilla.org/releases/mozilla-beta/log/tip/netwerk/protocol/http/HttpBaseChannel.cpp
You'd need to look for changes in April, between the 20th (beta 4) and the 27th (beta 5).

I doubt that the changes are in HttpBaseChannel.cpp, most likely there is a change elsewhere which now blocking the access.

All the Mozilla beta changes between those two releases on our Thunderbird release branch are here:
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=481fea2011e6
and more specifically here:
https://hg.mozilla.org/releases/mozilla-beta/rev/3b208a6419c5
where you can also see the change to HttpBaseChannel.cpp.

Can you paste the code that does the connect in Cardbook here or provide a link to that code. Maybe there's something obvious.

Comment 7

[Philippe VIGNEAU]

so much changes !...

I will prepare a simple test case...

Comment 8

[Philippe VIGNEAU]

so it's not simple at all and the problem is (with a fresh profile) that Thunderbird sometimes adds a cookie to the requests... then the requests sometimes return <d:unauthenticated/> or sometimes are OK... when the cookie is not set, then it is always OK... and I cannot determine why and when the cookie is added...

have you already seen such issues ?

Comment 9

[Jorg K (CEST = GMT+2)]

No, and they would be purely in Mozilla core code :-(

Comment 10

[Philippe VIGNEAU]

so I've no idea at all on this issue and what could be wrong on CardBook use of Xmlhttprequest()...

if a dev may have a look on this, I offer some beers :O)

Comment 11

[Sisim Biva]

There might be a similar issue here: https://github.com/nextcloud/server/issues/10134 and https://bugzilla.mozilla.org/show_bug.cgi?id=1468912

Comment 12

[Sisim Biva]

I close this issue to avoid duplicate with https://bugzilla.mozilla.org/show_bug.cgi?id=1468912