Closed Bug 1468943 Opened Last year Closed Last month

Mark confirmed alerts automatically

Categories

(Tree Management :: Perfherder, enhancement, P5)

enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: igoldan, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Priority: -- → P2
Assuming we retriggered/backfilled an alert and then marked it as "confirming", Perfherder should know when to change its state to "confirmed", once all the jobs finish.
Priority: P2 → P3
Comment on attachment 9005194 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3973

I know this is WIP, but I could use your feedback on this, as I'm not really familiar with Celery's way of doing things or New Relic's agent.
Attachment #9005194 - Flags: feedback?(wlachance)
Comment on attachment 9005194 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3973

Left a bit of feedback in the review on some of the details, I'd like to know more about exactly the workflow we're going for / trying to automate. Should we consider automating the confirming process as well?
Attachment #9005194 - Flags: feedback?(wlachance)
(In reply to William Lachance (:wlach) (use needinfo!) from comment #4)
> Comment on attachment 9005194 [details] [review]
> Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3973
> 
> Left a bit of feedback in the review on some of the details, I'd like to
> know more about exactly the workflow we're going for / trying to automate.

The workflow is as follows: when a new alert summary lands, we star a subset with the most relevant alerts. Then we retrigger & backfill them, while also marking them as 'confirming'. After this point, I only know which alerts have been retriggered/backfilled, but not if their jobs finished or not; I need to manually check that.
In this bug, I want to automate only this final check. This way, if all jobs have finished, then the corresponding alert is marked as 'confirmed'.

> Should we consider automating the confirming process as well?

This should be treated as a separate bug. We would need to talk with Joel about this. I recon he has some concerns about automating retriggers & backfills.
Comment on attachment 9005194 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3973

I addressed the review requests and tested only the check_confirming_perf_alerts_status() function locally (not the whole Celery & worker & queue setup) with success.
Attachment #9005194 - Flags: review?(wlachance)
Attachment #9005194 - Flags: review?(emorley)
Attachment #9005194 - Flags: review?(wlachance) → review+
Comment on attachment 9005194 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3973

Left a comment :-)
Attachment #9005194 - Flags: review?(emorley) → review-
Priority: P3 → P5
Assignee: igoldan → nobody
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → WONTFIX

Closed as WONTFIX because we want to get rid of this status. See bug 1582108.

See Also: → 1582108
You need to log in before you can comment on or make changes to this bug.