1582108 - Completely remove 'confirming' state

Status: RESOLVED FIXED

(Tree Management :: Perfherder, task, P1)

Description

[Ionuț Goldan [:igoldan]]

We realized its utility is questionable + increases confusion + messes up UI/UX.

We're better off reverting all work done in bug 1451657.
This bug must also address the problem noted in bug 1536018.

Comment 1

[Octavian Negru]

This needs to be done in three separate steps:

1. Ensure no one can add 'confirming' state from Perfherder
2. Clean the database of confirming state
3. Completely remove any mention of CONFIRMING state via this bug.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5388

Comment 4

[Ionuț Goldan [:igoldan]]

The PR is basically ready, but we're still experiencing the problem 1st reported in bug 1536018.

Trying to better reproduce it, we came to the conclusion there's a race condition on the backend side.
I'll detail more in bug 1536018.
My suggestion is to deploy this bug as it is & reopen bug 1536018.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5496

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5511