improve service worker parent-intercept preference

RESOLVED FIXED in Firefox 62

Status

()

defect
P2
normal
RESOLVED FIXED
Last year
6 months ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

(Blocks 1 bug)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

There are some problems with the current parent-intercept code.  This bug will convert it over to the new StaticPrefList approach and also make it only read once at startup.  Changes won't have any effect while the browser is running.
This patch does two things:

1. Define the sw e10s pref in StaticPrefList.h so that its set consistently at startup.

2. Only reads the value once and then keeps that setting.  So changes are effectively only active on restart.

Note, I tried forcing a read of the pref in InitXPCOM in the different processes, but that seemed too early in some cases.  This lazy init seems to work and should be reasonably reliable.
Attachment #8985705 - Flags: review?(bugmail)
Priority: -- → P2
Attachment #8985705 - Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e32ff604fc6
Define service worker parent intercept pref in StaticPrefList and read it once at startup. r=asuth
https://hg.mozilla.org/mozilla-central/rev/0e32ff604fc6
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.