Closed
Bug 1469024
Opened 6 years ago
Closed 6 years ago
improve service worker parent-intercept preference
Categories
(Core :: DOM: Service Workers, defect, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
There are some problems with the current parent-intercept code. This bug will convert it over to the new StaticPrefList approach and also make it only read once at startup. Changes won't have any effect while the browser is running.
Assignee | ||
Comment 1•6 years ago
|
||
This patch does two things:
1. Define the sw e10s pref in StaticPrefList.h so that its set consistently at startup.
2. Only reads the value once and then keeps that setting. So changes are effectively only active on restart.
Note, I tried forcing a read of the pref in InitXPCOM in the different processes, but that seemed too early in some cases. This lazy init seems to work and should be reasonably reliable.
Attachment #8985705 -
Flags: review?(bugmail)
Updated•6 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Attachment #8985705 -
Flags: review?(bugmail) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e32ff604fc6
Define service worker parent intercept pref in StaticPrefList and read it once at startup. r=asuth
Comment 3•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•