1469048 - Disable service worker propagation logic when e10s pref is enabled

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

We we are running in the mode where interception and SWM all live in the parent then we do not want to propagate anything to the child process.  We should gate all these IPC messages on the pref value and assert that state is not initialized in the child process.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Disable service worker propagation when e10s pref is enabled. r=asuth

Work-in-progress.  I think this actually breaks some tests.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Disable service worker propagation when e10s pref is enabled. r=asuth

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Disable service worker propagation when e10s pref is enabled. r=mrbkap

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8988838 [details] [diff] [review]
Disable service worker propagation when e10s pref is enabled. r=mrbkap

Blake, this patch disables the ServiceWorkerManager propagation between processes when the e10s pref is flipped.  It also adds some DEBUG assertions that ServiceWorkerRegistrationInfo and ServiceWorkerInfo are not created in the child process the pref is flipped.  (Maybe these should be diagnostic asserts in the future.)

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8988838 [details] [diff] [review]
Disable service worker propagation when e10s pref is enabled. r=mrbkap

Review of attachment 8988838 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not going to be able to read enough code to know with 100% certainty that this patch is complete. I'll trust the assertions and try runs that Ben already did. It shouldn't matter too much in the long run, anyway, as we eventually move away from the service worker manager in the child process completely and nuke that code.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a11d459a7f54ecc8b71746ff2810a7bb276692

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/031986327e4b40f543852f82378dde497128a370
Bug 1469048 Disable service worker propagation when e10s pref is enabled. r=mrbkap

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/031986327e4b