Closed Bug 1469048 Opened Last year Closed Last year

Disable service worker propagation logic when e10s pref is enabled

Categories

(Core :: DOM: Service Workers, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bkelly, Assigned: mrbkap)

References

(Blocks 1 open bug)

Details

(Whiteboard: SW-MUST)

Attachments

(1 file, 2 obsolete files)

We we are running in the mode where interception and SWM all live in the parent then we do not want to propagate anything to the child process.  We should gate all these IPC messages on the pref value and assert that state is not initialized in the child process.
Work-in-progress.  I think this actually breaks some tests.
Priority: -- → P2
Whiteboard: SW-MUST
Depends on: 1459209
Comment on attachment 8988838 [details] [diff] [review]
Disable service worker propagation when e10s pref is enabled. r=mrbkap

Blake, this patch disables the ServiceWorkerManager propagation between processes when the e10s pref is flipped.  It also adds some DEBUG assertions that ServiceWorkerRegistrationInfo and ServiceWorkerInfo are not created in the child process the pref is flipped.  (Maybe these should be diagnostic asserts in the future.)
Attachment #8988838 - Flags: review?(mrbkap)
Assignee: ben → mrbkap
Comment on attachment 8988838 [details] [diff] [review]
Disable service worker propagation when e10s pref is enabled. r=mrbkap

Review of attachment 8988838 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not going to be able to read enough code to know with 100% certainty that this patch is complete. I'll trust the assertions and try runs that Ben already did. It shouldn't matter too much in the long run, anyway, as we eventually move away from the service worker manager in the child process completely and nuke that code.
Attachment #8988838 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/031986327e4b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.