1469673 - Make hgmo extension compatible with Mercurial 4.6

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

Comment 1

[Phabricator Automation]

Attachment: hgmo: cat error log files in tests (Bug 1469673) r?gps

When running `hg serve ...`, there is a flag to send error output
to a file. When tests fail, they sometimes display output which
informs you there is an error, but is not useful in actually
fixing the problem (ie 500 Internal with no actual stack trace).
This commit ensures every call to `hg serve` includes an error
output file, and prints the contents of that file as output in
the test. With this patch in place any errors encountered by
the Mercurial server will be included in the test output.

Comment 2

[Phabricator Automation]

Attachment: firefoxreleases: port webcommand to be Mercurial 4.6 compatible (Bug 1469673) r?gps

This 4.6 compatibility change was overlooked in a previous commit
as the command is not actually tested in the firefoxreleases tests.
Instead the hgmo extension indirectly tests this command since the
firefoxreleases extension wraps the changesetentry function, and the
hgmo extension uses the firefoxreleases extension.

Comment 3

[Phabricator Automation]

Attachment: hgmo: enable compatibility with Mercurial 4.6 (Bug 1469673) r?gps

This commit ports the hgmo extension to be compatible with Mercurial
4.6. The main API changes are a change to the webcommand functionality.
Previously webcommand functions had the form `def wc(web, req, tmpl):`
with web being a requestcontext, req being a specific request and tmpl
being a templater object. The new API aggregates the req and tmpl
objects into the web object as web.req, and tmpl being generated
from a function.

WSGI responses are no longer automatically sent when the webcommand
functions return - instead the programmer must manually initiate a
response with the sendresponse method after specifying the body and
other fields.

The `repo[x]` syntax is being deprecated in future releases, in
anticipation of this we switch to using `scmutil.revsingle` in a few
places.

To determine if we are on a 4.6+ release we check for the `sendtemplate`
method on the requestcontext object whenever possible, and look for
`scmutil.revsingle` when this is unavailable.

Comment 4

[Phabricator Automation]

Comment on attachment 8986885 [details]
hgmo: cat error log files in tests (Bug 1469673) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1754

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/4764d9c6f01f
hgmo: cat error log files in tests r=gps

Comment 6

[Phabricator Automation]

Comment on attachment 8986886 [details]
firefoxreleases: port webcommand to be Mercurial 4.6 compatible (Bug 1469673) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1755

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6fc9f7431a52
firefoxreleases: port webcommand to be Mercurial 4.6 compatible r=gps

Comment 8

[Phabricator Automation]

Comment on attachment 8986887 [details]
hgmo: enable compatibility with Mercurial 4.6 (Bug 1469673) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1756

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/46dac5109444
hgmo: enable compatibility with Mercurial 4.6 r=gps

Comment 11

[Connor Sheehan [:sheehan]]

Attachment: hgmo: add more Mercurial 4.6 compatibility changes (Bug 1469673) r?gps

After upgrading the Mercurial version running in the hgmo virtual
environments themselves, several missed API changes were detected.
The value returned from Mercurial's `wireproto.clonebundles` is
now a `bytesresponse` object, and the same data must be parsed
from the `data` attribute. `mercurial.wireproto` no longer exists,
and is therefore wrapped in an `import_module` call where necessary.
Parsing of request headers has moved to a different attribute, and
the need to append "HTTP" to the front of the desired header,
as well as the requirement to change any header "-" to "_" is
gone.

Comment 12

[Phabricator Automation]

Comment on attachment 8996118 [details]
hgmo: add more Mercurial 4.6 compatibility changes (Bug 1469673) r?gps

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D2529

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/77cd613fd335
hgmo: add more Mercurial 4.6 compatibility changes r=gps