Closed
Bug 1469696
Opened 6 years ago
Closed 6 years ago
Support installing official language packs from AMO
Categories
(Firefox :: Settings UI, enhancement, P1)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
(Blocks 2 open bugs)
Details
Attachments
(7 files, 6 obsolete files)
46 bytes,
text/x-phabricator-request
|
aswan
:
review+
jaws
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
zbraniecki
:
review+
jaws
:
review+
aswan
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
jaws
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
flod
:
review+
jaws
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
aswan
:
review+
jaws
:
review+
|
Details | Review |
46 bytes,
text/x-phabricator-request
|
flod
:
review+
jaws
:
review+
|
Details | Review |
145.63 KB,
image/png
|
Details |
In the configure dialog from bug 1469688 a user should be able to see a list of available language packs in a dropdown, populated from AMO. Selecting one of these languages and clicking "Add" should download the language pack and add it to the list for the user to select.
Assignee | ||
Updated•6 years ago
|
Priority: P3 → P1
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Here's a mock response that points to some nightly langpack builds. To test this you'll need to set the following prefs:
intl.multilingual.enabled;true
extensions.langpacks.signatures.required;false
extensions.getAddons.langpacks.url;file:///path/to/language-tools.json
That should allow you to list and install language packs. Note there is an issue currently with the formatting of the ja-JP locale (at least on mac). I will file a bug for that as it appears to be unrelated.
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Updated•6 years ago
|
Attachment #9010373 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9010374 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9010375 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9010376 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9010377 -
Attachment is obsolete: true
Comment 12•6 years ago
|
||
Comment on attachment 9010413 [details]
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki
Zibi Braniecki [:gandalf][:zibi] has approved the revision.
Attachment #9010413 -
Flags: review+
Comment 13•6 years ago
|
||
Michelle, can you confirm if these strings work?
browser-languages-installed-label = Installed languages
browser-languages-available-label = Available languages
See also https://docs.google.com/a/mozilla.com/document/d/1zqBRFVHKVeRI40JJtTNB1X34oE1WlhZyFKMFvQ-n-Ak/edit?disco=uiAAAACIicSq4
Flags: needinfo?(mheubusch)
Comment 14•6 years ago
|
||
Comment on attachment 9010414 [details]
Bug 1469696 - Part 3: Allow searching for languages from dialog r?jaws!
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9010414 -
Flags: review+
Comment 15•6 years ago
|
||
Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9010416 -
Flags: review+
Comment 16•6 years ago
|
||
Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!
Andrew Swan [:aswan] has approved the revision.
Attachment #9010416 -
Flags: review+
Comment 17•6 years ago
|
||
Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!
Jared Wein [:jaws] (please needinfo? me) has been removed from the revision.
Attachment #9010416 -
Flags: review+
Comment 18•6 years ago
|
||
Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9010416 -
Flags: review+
Updated•6 years ago
|
Attachment #9010412 -
Attachment description: Bug 1469696 - Part 1: Use real langpacks in multilingual tests r?aswan → Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan
Comment 19•6 years ago
|
||
Comment on attachment 9010412 [details]
Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan!
Andrew Swan [:aswan] has approved the revision.
Attachment #9010412 -
Flags: review+
Updated•6 years ago
|
Attachment #9010412 -
Attachment description: Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan → Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan!
Updated•6 years ago
|
Attachment #9010413 -
Attachment description: Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan,jaws → Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki
Updated•6 years ago
|
Attachment #9010414 -
Attachment description: Bug 1469696 - Part 3: Allow searching for languages from dialog r?jaws → Bug 1469696 - Part 3: Allow searching for languages from dialog r?jaws!
Updated•6 years ago
|
Attachment #9010415 -
Attachment description: Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws → Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws!
Updated•6 years ago
|
Attachment #9010416 -
Attachment description: Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws → Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!
Comment 20•6 years ago
|
||
Comment on attachment 9010415 [details]
Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws!
Francesco Lodolo [:flod] has approved the revision.
Attachment #9010415 -
Flags: review+
Comment 21•6 years ago
|
||
Comment on attachment 9010412 [details]
Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan!
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9010412 -
Flags: review+
Comment 22•6 years ago
|
||
Comment on attachment 9010413 [details]
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9010413 -
Flags: review+
Comment 23•6 years ago
|
||
Comment on attachment 9010415 [details]
Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws!
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9010415 -
Flags: review+
Comment 24•6 years ago
|
||
Comment on attachment 9010413 [details]
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki
Andrew Swan [:aswan] has approved the revision.
Attachment #9010413 -
Flags: review+
Assignee | ||
Comment 25•6 years ago
|
||
Assignee | ||
Comment 26•6 years ago
|
||
Here's a screenshot with the updated error message.
Comment 27•6 years ago
|
||
Comment on attachment 9012996 [details]
Bug 1469696 - Part 6: Update warning message, limit width r?jaws!
Francesco Lodolo [:flod] has approved the revision.
Attachment #9012996 -
Flags: review+
Comment 28•6 years ago
|
||
Comment on attachment 9012996 [details]
Bug 1469696 - Part 6: Update warning message, limit width r?jaws!
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #9012996 -
Flags: review+
Comment 29•6 years ago
|
||
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/263bd17c558e
Part 1: Use stub langpacks in multilingual tests r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/31c94d7845b7
Part 2: Allow installing langpacks from AMO in prefs r=flod,aswan,zbraniecki,jaws
https://hg.mozilla.org/integration/autoland/rev/10b8ab80417d
Part 3: Allow searching for languages from dialog r=jaws
https://hg.mozilla.org/integration/autoland/rev/4973d5d699c5
Part 4: Separate installed and available langpacks r=flod,jaws
https://hg.mozilla.org/integration/autoland/rev/54abaf608a60
Part 5: Test listing and installing AMO langpacks r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/5b0ef00bdd7c
Part 6: Update warning message, limit width r=flod,jaws
Comment 30•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/263bd17c558e
https://hg.mozilla.org/mozilla-central/rev/31c94d7845b7
https://hg.mozilla.org/mozilla-central/rev/10b8ab80417d
https://hg.mozilla.org/mozilla-central/rev/4973d5d699c5
https://hg.mozilla.org/mozilla-central/rev/54abaf608a60
https://hg.mozilla.org/mozilla-central/rev/5b0ef00bdd7c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Assignee | ||
Comment 31•6 years ago
|
||
I've setup a test server that can be used to test this on Nightly. It will use the most recent l10n build it can find so the langpack that it installs _should_ (hopefully, maybe) work just fine.
You can test this by setting the following prefs:
intl.multilingual.enabled=true
extensions.langpacks.signatures.required=false
extensions.getAddons.langpacks.url=https://mock-amo-language-tools.glitch.me/
Flags: needinfo?(mheubusch)
Assignee | ||
Updated•6 years ago
|
Attachment #9010385 -
Attachment is obsolete: true
Comment 32•6 years ago
|
||
Any particular reason why your using a "smart" quote here?
https://hg.mozilla.org/mozilla-central/rev/5b0ef00bdd7c#l3.14
"can’t"
Flags: needinfo?(mstriemer)
Comment 33•6 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #32)
> Any particular reason why your using a "smart" quote here?
> https://hg.mozilla.org/mozilla-central/rev/5b0ef00bdd7c#l3.14
> "can’t"
Unless I'm misunderstanding "smart quote": that's a proper apostrophe, and that's how they're supposed to be written across Firefox messages, to the point that there are tests enforcing them.
https://searchfox.org/mozilla-central/source/browser/base/content/test/static/browser_misused_characters_in_strings.js
Flags: needinfo?(mstriemer)
Comment 34•6 years ago
|
||
Hmm, I don't even have that "proper apostrophe" on my keyboard :-( - Looks like you have some catching up to do then:
https://searchfox.org/mozilla-central/search?q=don%27t&case=false®exp=false&path=*.ftl
https://searchfox.org/mozilla-central/search?q=don%27t&case=false®exp=false&path=*.dtd (mostly comments)
https://searchfox.org/mozilla-central/search?q=can%27t&case=false®exp=false&path=*.dtd
Comment 35•6 years ago
|
||
> .label = Don't Autoplay
That's (sadly) a side effect of not having those tests for Fluent files, and it should be fixed. Comments are not relevant, they can use straight quotes (single or double).
You need to log in
before you can comment on or make changes to this bug.
Description
•