1469696 - Support installing official language packs from AMO

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

In the configure dialog from bug 1469688 a user should be able to see a list of available language packs in a dropdown, populated from AMO. Selecting one of these languages and clicking "Add" should download the language pack and add it to the list for the user to select.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 1: Use real langpacks in multilingual tests r?aswan

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan,jaws

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 3: Allow searching for languages from dialog r?jaws

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: language-tools.json

Here's a mock response that points to some nightly langpack builds. To test this you'll need to set the following prefs:

  intl.multilingual.enabled;true
  extensions.langpacks.signatures.required;false
  extensions.getAddons.langpacks.url;file:///path/to/language-tools.json

That should allow you to list and install language packs. Note there is an issue currently with the formatting of the ja-JP locale (at least on mac). I will file a bug for that as it appears to be unrelated.

Comment 7

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan!

Comment 8

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki

Comment 9

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 3: Allow searching for languages from dialog r?jaws!

Comment 10

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws!

Comment 11

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9010413 [details]
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki

Zibi Braniecki [:gandalf][:zibi] has approved the revision.

Comment 13

[Francesco Lodolo [:flod]]

Michelle, can you confirm if these strings work?

browser-languages-installed-label = Installed languages
browser-languages-available-label = Available languages

See also https://docs.google.com/a/mozilla.com/document/d/1zqBRFVHKVeRI40JJtTNB1X34oE1WlhZyFKMFvQ-n-Ak/edit?disco=uiAAAACIicSq4

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010414 [details]
Bug 1469696 - Part 3: Allow searching for languages from dialog r?jaws!

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 16

[Andrew Swan [:aswan]]

Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!

Andrew Swan [:aswan] has approved the revision.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!

Jared Wein [:jaws] (please needinfo? me) has been removed from the revision.

Comment 18

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010416 [details]
Bug 1469696 - Part 5: Test listing and installing AMO langpacks r?aswan,jaws!

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 19

[Andrew Swan [:aswan]]

Comment on attachment 9010412 [details]
Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan!

Andrew Swan [:aswan] has approved the revision.

Comment 20

[Francesco Lodolo [:flod]]

Comment on attachment 9010415 [details]
Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws!

Francesco Lodolo [:flod] has approved the revision.

Comment 21

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010412 [details]
Bug 1469696 - Part 1: Use stub langpacks in multilingual tests r?aswan!

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 22

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010413 [details]
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 23

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9010415 [details]
Bug 1469696 - Part 4: Separate installed and available langpacks r?jaws!

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 24

[Andrew Swan [:aswan]]

Comment on attachment 9010413 [details]
Bug 1469696 - Part 2: Allow installing langpacks from AMO in prefs r?aswan!,jaws!,zbraniecki

Andrew Swan [:aswan] has approved the revision.

Comment 25

[Mark Striemer [:mstriemer]]

Attachment: Bug 1469696 - Part 6: Update warning message, limit width r?jaws!

Comment 26

[Mark Striemer [:mstriemer]]

Attachment: Screenshot 2018-09-28 12.53.33.png

Here's a screenshot with the updated error message.

Comment 27

[Francesco Lodolo [:flod]]

Comment on attachment 9012996 [details]
Bug 1469696 - Part 6: Update warning message, limit width r?jaws!

Francesco Lodolo [:flod] has approved the revision.

Comment 28

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9012996 [details]
Bug 1469696 - Part 6: Update warning message, limit width r?jaws!

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/263bd17c558e
Part 1: Use stub langpacks in multilingual tests r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/31c94d7845b7
Part 2: Allow installing langpacks from AMO in prefs r=flod,aswan,zbraniecki,jaws
https://hg.mozilla.org/integration/autoland/rev/10b8ab80417d
Part 3: Allow searching for languages from dialog r=jaws
https://hg.mozilla.org/integration/autoland/rev/4973d5d699c5
Part 4: Separate installed and available langpacks r=flod,jaws
https://hg.mozilla.org/integration/autoland/rev/54abaf608a60
Part 5: Test listing and installing AMO langpacks r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/5b0ef00bdd7c
Part 6: Update warning message, limit width r=flod,jaws

Comment 30

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/263bd17c558e
https://hg.mozilla.org/mozilla-central/rev/31c94d7845b7
https://hg.mozilla.org/mozilla-central/rev/10b8ab80417d
https://hg.mozilla.org/mozilla-central/rev/4973d5d699c5
https://hg.mozilla.org/mozilla-central/rev/54abaf608a60
https://hg.mozilla.org/mozilla-central/rev/5b0ef00bdd7c

Comment 31

[Mark Striemer [:mstriemer]]

I've setup a test server that can be used to test this on Nightly. It will use the most recent l10n build it can find so the langpack that it installs _should_ (hopefully, maybe) work just fine.

You can test this by setting the following prefs:

  intl.multilingual.enabled=true
  extensions.langpacks.signatures.required=false
  extensions.getAddons.langpacks.url=https://mock-amo-language-tools.glitch.me/

Comment 32

[Jorg K (CEST = GMT+2)]

Any particular reason why your using a "smart" quote here?
https://hg.mozilla.org/mozilla-central/rev/5b0ef00bdd7c#l3.14
  "can’t"

Comment 33

[Francesco Lodolo [:flod]]

(In reply to Jorg K (GMT+1) from comment #32)
> Any particular reason why your using a "smart" quote here?
> https://hg.mozilla.org/mozilla-central/rev/5b0ef00bdd7c#l3.14
>   "can’t"

Unless I'm misunderstanding "smart quote": that's a proper apostrophe, and that's how they're supposed to be written across Firefox messages, to the point that there are tests enforcing them.
https://searchfox.org/mozilla-central/source/browser/base/content/test/static/browser_misused_characters_in_strings.js

Comment 34

[Jorg K (CEST = GMT+2)]

Hmm, I don't even have that "proper apostrophe" on my keyboard :-( - Looks like you have some catching up to do then:

https://searchfox.org/mozilla-central/search?q=don%27t&case=false&regexp=false&path=*.ftl
https://searchfox.org/mozilla-central/search?q=don%27t&case=false&regexp=false&path=*.dtd (mostly comments)
https://searchfox.org/mozilla-central/search?q=can%27t&case=false&regexp=false&path=*.dtd

Comment 35

[Francesco Lodolo [:flod]]

> .label = Don't Autoplay

That's (sadly) a side effect of not having those tests for Fluent files, and it should be fixed. Comments are not relevant, they can use straight quotes (single or double).