Stop spewing "Cannot set transparency mode on non-popup windows"
Categories
(Core :: Widget: Gtk, enhancement)
Tracking
()
People
(Reporter: hiro, Assigned: karlt)
References
(Regression)
Details
(Keywords: regression)
Attachments
(5 files, 1 obsolete file)
When I run ./mach run --layoutdebug, there are lots of "Cannot set transparency mode on non-popup windows". A call site (all of them?) is nsContainerFrame::SyncWindowProperties [1], and eTransparencyTransparent comes from here[2]. [1] https://searchfox.org/mozilla-central/rev/d0a41d2e7770fc00df7844d5f840067cc35ba26f/layout/generic/nsContainerFrame.cpp#652 [2] https://searchfox.org/mozilla-central/rev/f822a0b61631cbb38901569e69b4967176314aa8/layout/base/nsLayoutUtils.cpp#7269
|
Assignee | |
Comment 1•5 years ago
|
||
I'm seeing these warnings with mHasAlphaVisual == false and mTransparencyBitmapForTitlebar == true so I guess the warnings started for me with https://hg.mozilla.org/mozilla-central/rev/7d768598fee79819797f560acc4cff7f5b0a18a8#l2.76
mIsTransparent was first set during Create() in https://hg.mozilla.org/mozilla-central/rev/7b006f2910ccabc207dd3a6c6e861406b5d18fb7#l2.38
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
The early return for non-popup windows was to workaround
https://bugzilla.mozilla.org/show_bug.cgi?id=1344839 which involved problems
with CleanLayerManagerRecursive(). In cases where layer manager configuration
does not change, there is no need to clean the layer manager and so no need to
return early.
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38b37dfa1f33 allow transparency mode to be set appropriately according to whether drawing a titlebar r=stransky
|
Reporter | |
Comment 4•5 years ago
|
||
\o/
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Backed out for causing Bug 1572116
backout: https://hg.mozilla.org/mozilla-central/rev/9229fd85bc05af4c33c8cb8f5e489eca1043722d
|
||
Comment 8•5 years ago
|
||
It's also on the integration branches (autoland, mozilla-inbound), e.g. https://hg.mozilla.org/integration/autoland/rev/9229fd85bc05af4c33c8cb8f5e489eca1043722d
When something gets backed out on central, it usually gets merged to integration branches directly after it. Pulsebot won't comment for merges.
A backout on central can make sense if an issue shall be fixed quickly for all developers or in CI.
|
||
Comment 9•5 years ago
•
|
||
After backout 9229fd85bc05af4c33c8cb8f5e489eca1043722d:
== Change summary for alert #22501 (as of Fri, 16 Aug 2019 15:58:42 GMT) ==
Improvements:
12% ts_paint linux64-shippable-qr opt e10s stylo 304.71 -> 268.92
10% ts_paint_webext linux64-shippable-qr opt e10s stylo 305.08 -> 275.33
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22501
| Comment hidden (spam) |
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 11•5 years ago
|
||
Just for people's reference, I also saw this warning messages during the local |make mozmill| test suite run of
C-C TB (Full DEBUG version).
My local copy of M-C was updated a few days ago. C-C was updated a day or so ago.
E.g.:
TEST-START | /NREF-COMM-CENTRAL/mozilla/comm/mail/test/mozmill/content-tabs/test-addons-mgr.js | test_addon_prefs
[31740, Main Thread] WARNING: Cannot set transparency mode on non-popup windows.: file /NREF-COMM-CENTRAL/mozilla/widget/gtk/nsWindow.cpp, line 4456
[31740, Main Thread] WARNING: Cannot set transparency mode on non-popup windows.: file /NREF-COMM-CENTRAL/mozilla/widget/gtk/nsWindow.cpp, line 4456
TEST-START | /NREF-COMM-CENTRAL/mozilla/comm/mail/test/mozmill/content-tabs/test-addons-mgr.js | teardownModule
When I ran the |make mozmill| test under valgrind, I get more such errors. I am not sure what goes on there.
|
|
Assignee | |
Comment 12•5 years ago
|
||
These identifiers can be compared with messages from logging from nsWindow.
Also clarify that this log is not intended to indicate each draw.
|
|
Assignee | |
Comment 13•5 years ago
|
||
for change in rectangle output from
https://hg.mozilla.org/mozilla-central/rev/f5120348a27f02067b4ea070bc429fe5377686f6#l22.166
Depends on D53387
|
|
Assignee | |
Comment 14•5 years ago
|
||
Depends on D53388
|
|
Assignee | |
Comment 15•5 years ago
|
||
Depends on D53389
|
|
Assignee | |
Comment 16•5 years ago
|
||
Depends on D53390
|
|
||
Updated•5 years ago
|
|
||
Comment 17•5 years ago
|
||
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dafab8054c07 provide identifying handles in CreateWindowSurface() log messages r=rhunt https://hg.mozilla.org/integration/autoland/rev/19252343b776 add log messages for SetTransparencyMode r=stransky https://hg.mozilla.org/integration/autoland/rev/e55213821970 SetTransparentMode: only clear out popup window layer manager if a different kind is needed r=stransky https://hg.mozilla.org/integration/autoland/rev/79821df17239 SetTransparentMode: warn only when requesting translucency without support r=stransky
|
||
Comment 18•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dafab8054c07
https://hg.mozilla.org/mozilla-central/rev/19252343b776
https://hg.mozilla.org/mozilla-central/rev/e55213821970
https://hg.mozilla.org/mozilla-central/rev/79821df17239
|
|
||
Comment 19•5 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
|
|
||
Updated•5 years ago
|
|
||
Comment 20•5 years ago
|
||
I am terribly sorry, I don't know how I managed to push a change to this changeset o_O (I didn't even knew it was possible)
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Comment 21•5 years ago
|
||
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30c6394b8be7 update expose event rectangle log message r=mattwoodrow
|
||
Comment 22•5 years ago
|
||
| bugherder | ||
|
|
||
Updated•2 years ago
|
Description
•