[Titlebar] Use Window manager decorations on GNOME again

VERIFIED FIXED in Firefox 66

Status

()

VERIFIED FIXED
29 days ago
7 days ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 verified, firefox67 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

29 days ago

In Bug 1521012 we switched from Window manager decorations to client side decorations on gnome to apply the shape mask.

Looks like when the shape mask setup it carefully configured we don't need the client side decorations and we can switch back to window manager mode.

This should fix various regression from Bug 1521012 on gnome although they will stay on desktops where we use CSD titlebar mode (MATE for instance).

(Assignee)

Comment 1

29 days ago

This patch enables the shape mask in CSD and Window manager decorations mode
when we're runnin on composited screen and mozilla.widget.use-argb-visuals is not set.

Also don't use shape mask with Wayland and GL backend. When shape mask is set,
advertise toplevel window transparency but don't advertise it
as alpha to GtkCompositorWidget.

(Assignee)

Updated

29 days ago
status-firefox66: --- → affected
(Assignee)

Updated

28 days ago
Keywords: checkin-needed

Comment 3

28 days ago

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d768598fee7
[Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

Keywords: checkin-needed

Comment 4

27 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 27 days ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Updated

25 days ago
Depends on: 1530252

Updated

25 days ago
Blocks: 1525233

Updated

25 days ago
Blocks: 1526217

Updated

24 days ago
Blocks: 1525850
status-firefox66: affected → wontfix

Liz: this (and bug 1530625) is new in 66, we shouldn't ship with this in 66 and then roll it back in 67, see also bug 1490344 comment 14.

Flags: needinfo?(lhenry)

Oh, let's uplift then. Thanks for pointing that out.
Martin can you request uplift here?

status-firefox66: wontfix → affected
Flags: needinfo?(lhenry) → needinfo?(stransky)
(Assignee)

Comment 8

21 days ago

Comment on attachment 9045762 [details]
Bug 1529713 - [Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1521012
  • User impact if declined: We're recently use client side decorations on Firefox 66 which causes various regressions (https://bugzilla.mozilla.org/show_bug.cgi?id=1525850, https://bugzilla.mozilla.org/show_bug.cgi?id=1527837). This patch switches back to window manager decorations used in Firefox 65.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Please verify that Bug 1525850 is fixed on Gnome / Firefox 66, reproduction steps are included there.
  • List of other uplifts needed: Bug 1525874
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Linux/Gtk+, verified in nightly. We're reverting the decoration rendering to state we used in Firefox 65.
  • String changes made/needed: none
Flags: needinfo?(stransky)
Attachment #9045762 - Flags: approval-mozilla-beta?

Comment on attachment 9045762 [details]
Bug 1529713 - [Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

GTK only issue; OK for beta uplift.

Attachment #9045762 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 10

20 days ago
bugherderuplift
status-firefox66: affected → fixed

Updated

18 days ago
Blocks: 1523560

I verified that Window manager decorations is used again. First I reproduced the issue from Bug 1525850 on Firefox Nightly 67.0a1 (2019-02-07) under Ubuntu 18.04 (x64).

The issue from Bug 1525850 is fixed on latest Nightly 67.0a1 (2019-03-04) and Firefox Beta 66.0b13 under Ubuntu 18.04 (x64).

Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified
status-firefox67: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.