1529713 - [Titlebar] Use Window manager decorations on GNOME again

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

In Bug 1521012 we switched from Window manager decorations to client side decorations on gnome to apply the shape mask.

Looks like when the shape mask setup it carefully configured we don't need the client side decorations and we can switch back to window manager mode.

This should fix various regression from Bug 1521012 on gnome although they will stay on desktops where we use CSD titlebar mode (MATE for instance).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1529713 - [Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

This patch enables the shape mask in CSD and Window manager decorations mode
when we're runnin on composited screen and mozilla.widget.use-argb-visuals is not set.

Also don't use shape mask with Wayland and GL backend. When shape mask is set,
advertise toplevel window transparency but don't advertise it
as alpha to GtkCompositorWidget.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71cb878d390de266dcae895c662150550bc839e0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d768598fee7
[Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7d768598fee7

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7d768598fee7

Comment 6

[Julien Cristau [:jcristau]]

Liz: this (and bug 1530625) is new in 66, we shouldn't ship with this in 66 and then roll it back in 67, see also bug 1490344 comment 14.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Oh, let's uplift then. Thanks for pointing that out.
Martin can you request uplift here?

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9045762 [details]
Bug 1529713 - [Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1521012
• User impact if declined: We're recently use client side decorations on Firefox 66 which causes various regressions (https://bugzilla.mozilla.org/show_bug.cgi?id=1525850, https://bugzilla.mozilla.org/show_bug.cgi?id=1527837). This patch switches back to window manager decorations used in Firefox 65.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please verify that Bug 1525850 is fixed on Gnome / Firefox 66, reproduction steps are included there.
• List of other uplifts needed: Bug 1525874
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Gtk+, verified in nightly. We're reverting the decoration rendering to state we used in Firefox 65.
• String changes made/needed: none

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9045762 [details]
Bug 1529713 - [Titlebar] Use Window manager decorations on GNOME again, r=lsalzman

GTK only issue; OK for beta uplift.

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e91e23e30d4b

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I verified that Window manager decorations is used again. First I reproduced the issue from Bug 1525850 on Firefox Nightly 67.0a1 (2019-02-07) under Ubuntu 18.04 (x64).

The issue from Bug 1525850 is fixed on latest Nightly 67.0a1 (2019-03-04) and Firefox Beta 66.0b13 under Ubuntu 18.04 (x64).