1469755 - Add new mappings for Treeherder android hardware platform map

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Bob Clary [:bc] (inactive)]

Bug 1426586 changes Android test platform names for emulators to begin with the prefix android-em while introducing new test platform names for android hardware beginning with android-hw.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3022625d05cd75be098d970a227a969cd3afff6&filter-tier=1&filter-tier=2&filter-tier=3 is a try run for bug 1426586 but without an updated Treeherder platform map.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3682

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8986367 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3682

Stealing review since Cameron is away the rest of this week.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a6b1b283e9ca9dbc6c7bade3f1ca1ac6d69e5e81
Bug 1469755 - Add new mappings for android hardware platform (#3682)

Comment 4

[Ed Morley [:emorley]]

This will auto-deploy to stage within ~15 minutes. The prod push might not be until next week, since there were some regressions on master that are hopefully fixed but need further testing before the next deploy.

Comment 5

[Bob Clary [:bc] (inactive)]

Thanks!

Comment 6

[Ed Morley [:emorley]]

The stage deploy hasn't yet completed, since it's waiting on a long running migration, but should occur within an hour or two.

Comment 7

[Bob Clary [:bc] (inactive)]

Looks like I didn't get it right after all:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=176d8c0698f3488c6033dc1076dc4e3f80c3a4c1&filter-tier=1&filter-tier=2&filter-tier=3

Comment 8

[Bob Clary [:bc] (inactive)]

I had thought that it had been working this morning, but checking my try pushes again they don't show the new descriptions.

Ed: Was this backed out of master? Or is my patch just broken?

Comment 9

[Ed Morley [:emorley]]

Sorry for the confusion - today's prod deploy was rolled back due more regressions:
bug 1470532 comment 5
https://mozilla.logbot.info/treeherder/20180622#c14923020
https://groups.google.com/forum/#!topic/mozilla.tools.treeherder/Yal8GxNJwJE

Comment 10

[Bob Clary [:bc] (inactive)]

np. staging appears ok with the exception of android-em-4-2-x86.

Comment 11

[Geoff Brown [:gbrown]]

And *I* am sorry, for not paying attention here earlier, but now I'm puzzled. Why are we adding

android-em-4-4-armv7-api16
android-em-5-0-armv8-api16
android-em-6-0-armv8-api16
android-em-7-1-armv8-api15
android-em-7-1-armv8-api16

?

I think we never have had such emulator platforms -- weren't those added earlier for autophone?

I am only planning android-em-7-0-x86-api16 for packet.net.

Comment 12

[Bob Clary [:bc] (inactive)]

Geoff: Thanks. I totally forgot about autophone's influence in this file which is ironic to say the least. I'm not sure about the need for legacy stuff in this file going forward but it is clear these android-em versions for autophone won't be needed. I'll double back when we get the full deploy to production and will remove them if I have additional changes to make.