Closed
Bug 1472206
Opened 7 years ago
Closed 7 years ago
Add mapping for android-em-4-2-x86 Treeherder android hardware platform map
Categories
(Tree Management :: Treeherder: Frontend, enhancement)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file, 1 obsolete file)
bug 1469755 added maps for most but apparently not all platform maps. It missed android-em-4-2-x86.
Also bug 1469755 comment 11 mentioned that some of the maps I added for android-em were actually for OG Autophone and were superfluous.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bob
|
||
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Looked good on my dev instance.
Attachment #8988754 -
Flags: review?(gbrown)
Attachment #8988754 -
Flags: review?(emorley)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8988754 [details] [review]
https://github.com/mozilla/treeherder/pull/3736
doh.
Attachment #8988754 -
Attachment is obsolete: true
Attachment #8988754 -
Flags: review?(gbrown)
Attachment #8988754 -
Flags: review?(emorley)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8988753 -
Flags: review?(gbrown)
Attachment #8988753 -
Flags: review?(emorley)
|
||
Updated•7 years ago
|
Attachment #8988753 -
Flags: review?(gbrown) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
emorley: gbrown requested I add 'android-em-7-0-x86': 'Android 7.0 x86'. Should I just add another commit to my branch and push to my repo again? Not sure how to handle updating the pull request.
Flags: needinfo?(emorley)
|
||
Comment 5•7 years ago
|
||
Pushing another commit is fine - I can use the GitHub "squash and merge" commit feature to combine them :-)
Flags: needinfo?(emorley)
|
|
Assignee | |
Comment 6•7 years ago
|
||
|
|
||
Comment 7•7 years ago
|
||
Comment on attachment 8988753 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3736
Many thanks :-)
Attachment #8988753 -
Flags: review?(emorley) → review+
|
||
Comment 8•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/e4bbcb42502c9d1fb719e6baf024fe63bbeb02d2
Bug 1472206 - Update android-em-* platform mappings (#3736)
|
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•