1469764 - Can't send to device from a WebExtension panel (and potential other issues)

Status: NEW

(WebExtensions :: Frontend, defect, P3)

Description

[Mark Banner (:standard8)]

It is unclear if this is meant to work or not, I found this whilst looking in detail at bug 1452645 and bug 1469763.

STR:

1) Enable Firefox Sync.
2) Install an add-on that loads pages in the sidebar, e.g. Side View.
3) Load a web page in the sidebar.
4) Right click and inspect the context menu.

=> Send Page to Device is not listed.

In the source code, the issue is that gSync.init() (defined in browser-sync.js) isn't being called.

In the browser window, this is done as part of scheduled tasks after opening the window:

https://searchfox.org/mozilla-central/rev/f822a0b61631cbb38901569e69b4967176314aa8/browser/base/content/browser.js#1745-1748

However, in the sidebar this never gets called (note: it appears to not be called in the current web-panels.xul window either).

It appears that if this functionality is desired, then a call needs to be added to gSync.init(). However, it might be a good idea to review all the context menu code to ensure it is functioning as expected for WebExtension sidebar panels.

This could also help explain bug 1457432.


Also, please be aware bug 1452645 is removing getPanelBrowser() from:

https://searchfox.org/mozilla-central/rev/f822a0b61631cbb38901569e69b4967176314aa8/browser/base/content/browser-context.inc#271

That line is currently wrong anyway, as webext-panels.js defines a stub implementation for gBrowser - which is what will likely need to be updated.

Comment 1

[Gyula Palko[:gpalko]]

Setting the component as the same from the dependent bug.

Comment 2

[YUKI "Piro" Hiroshi]

Does this bug cover any proposal for new WbExtensions API required to imitate a native command "Send Tab to Device" by addons? If not, I want to file a new bug for it because it is required to imitate tab context menu by addons. See also the bug 1280347.