1469941 - trigger service worker navigation update check when e10s pref is flipped

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently we trigger our navigation update check from DOMContentLoaded in nsDocument by talking straight to the local process SWM.  We need to make this send a message to the parent instead.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Note DOMContentLoaded on the ClientSource and trigger service worker update in appropriate process. r=mrbkap

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8986521 [details] [diff] [review]
Note DOMContentLoaded on the ClientSource and trigger service worker update in appropriate process. r=mrbkap

Blake, the service worker spec requires that the browser schedule an update check after every non-subresource load that results in a controlled client.  By convention we do this some time period after the page loads.  Chrome uses the load event to start and we have been using DOMContentLoaded.

Our code that triggers this update check currently calls the local SWM directly from nsDocument.cpp when DOMContentLoaded is dispatched.  Of course, this does not work properly in our new e10s architecture.

This patch makes us send a message on the ClientSource when we reach DOMContentLoaded.  We then trigger the SWM update call in the appropriate process based on how the pref is set.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f78c17a1cea
Note DOMContentLoaded on the ClientSource and trigger service worker update in appropriate process. r=mrbkap

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3f78c17a1cea