1469988 - fix service worker performance-timeline.https.html test to not timeout if bufferfull event is not supported

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently we don't dispatch bufferfull events on worker threads.  This causes the performance-timeline.https.html WPT test to completely timeout.  Lets make this test detect this as a failure instead so we can get the rest of the test coverage to run.

I need this test to be at least partly working in order to check the new e10s configuration for service workers.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix performance-timeline.https.html to not timeout if bufferfull event is not fired in service worker. r=mrbkap

Blake, this test is timing out because we do not fire the bufferfull event in any worker thread context.  I'd like to be able to get the coverage from the other test cases here, though.

So this patch makes the test detect the missing event without timing out the entire WPT file.  It does this by racing the event dispatch against another fetch request.  Since the API must record new resource requests as they occur, it seems reasonable that it should fire the event before another request can be processed.  This seems better to me than a setTimeout with an arbitrary delay, etc.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c74adc90978c
Fix performance-timeline.https.html to not timeout if bufferfull event is not fired in service worker. r=mrbkap

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11639 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c74adc90978c

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged