Closed Bug 1469988 Opened 4 years ago Closed 4 years ago

fix service worker performance-timeline.https.html test to not timeout if bufferfull event is not supported

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

Currently we don't dispatch bufferfull events on worker threads.  This causes the performance-timeline.https.html WPT test to completely timeout.  Lets make this test detect this as a failure instead so we can get the rest of the test coverage to run.

I need this test to be at least partly working in order to check the new e10s configuration for service workers.
Blake, this test is timing out because we do not fire the bufferfull event in any worker thread context.  I'd like to be able to get the coverage from the other test cases here, though.

So this patch makes the test detect the missing event without timing out the entire WPT file.  It does this by racing the event dispatch against another fetch request.  Since the API must record new resource requests as they occur, it seems reasonable that it should fire the event before another request can be processed.  This seems better to me than a setTimeout with an arbitrary delay, etc.
Attachment #8986577 - Flags: review?(mrbkap)
Attachment #8986577 - Flags: review?(mrbkap) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c74adc90978c
Fix performance-timeline.https.html to not timeout if bufferfull event is not fired in service worker. r=mrbkap
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11639 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/c74adc90978c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.