Closed
Bug 1470047
Opened 6 years ago
Closed 6 years ago
[Wayland] Should handle all key modifiers
Categories
(Core :: Widget: Gtk, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ashie, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
From bug1468670 Most of key modifiers aren't handled on Wayland since nsGtkKeyUtils::InitBySystemSettingsWayland() in widget/gtk/nsGtkKeyUtils.cpp isn't implemented yet. To make it better as well as nsGtkKeyUtils::InitBySystemSettingsX11(), it should be implemented by using wl_keyboard & xkb (maybe).
Reporter | ||
Updated•6 years ago
|
Summary: [Wayland] Should handle all modifier keys → [Wayland] Should handle all key modifiers
Assignee | ||
Comment 1•6 years ago
|
||
I wonder if we can use GdkKeymap for that.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → stransky
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8991058 [details] Bug 1470047 - Implement InitBySystemSettingsWayland() and get key modifiers on Wayland, https://reviewboard.mozilla.org/r/256050/#review262900 ::: widget/gtk/nsGtkKeyUtils.cpp:524 (Diff revision 1) > + enum xkb_keymap_format, enum xkb_keymap_compile_flags)) > + dlsym(RTLD_DEFAULT, "xkb_keymap_new_from_string"); > + > + struct xkb_context *xkb_context = sXkbContextNew(XKB_CONTEXT_NO_FLAGS); > + struct xkb_keymap *keymap = > + sXkbKeymapNewFromString(xkb_context, hm, wrong indent here.
Reporter | ||
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8991058 [details] Bug 1470047 - Implement InitBySystemSettingsWayland() and get key modifiers on Wayland, https://reviewboard.mozilla.org/r/256050/#review263342 ::: widget/gtk/nsGtkKeyUtils.cpp:460 (Diff revision 1) > + static auto sXkbKeymapModGetIndex = > + (xkb_mod_index_t (*)(struct xkb_keymap *, const char *)) > + dlsym(RTLD_DEFAULT, "xkb_keymap_mod_get_index"); > + > + mModifierMasks[aModifierIndex] = > + (1 << sXkbKeymapModGetIndex(aKeymap, aModifierName)); I'm not sure but since xkb_keymap_mod_get_index() can return XKB_MOD_INVALID(0xffffffff), it may cause unexpected result.
Attachment #8991058 -
Flags: review?(ashie) → review+
Comment hidden (mozreview-request) |
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/5e46c8d0ed58 Implement InitBySystemSettingsWayland() and get key modifiers on Wayland, r=ashie
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5e46c8d0ed58
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
This patch seems to cause issues on wlroots-based compositors. I'm not entirely sure what is going wrong (or if it is an issue in firefox (although I asked in the #sway irc channel on freenode, and they seemed to think it was a firefox bug)), but I'll try to attach a WAYLAND_DEBUG log. Let me know if you need more information, or if I should open up a separate bug.
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to aidan from comment #8) > This patch seems to cause issues on wlroots-based compositors. I'm not > entirely sure what is going wrong (or if it is an issue in firefox (although > I asked in the #sway irc channel on freenode, and they seemed to think it > was a firefox bug)), but I'll try to attach a WAYLAND_DEBUG log. Let me > know if you need more information, or if I should open up a separate bug. What issues exactly? Can you file a new bug for it please?
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(aidan)
Comment 11•6 years ago
|
||
Sorry about that. Thought I included more information. Anyways, I added a new bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1475802 Thanks.
Flags: needinfo?(aidan)
Updated•6 years ago
|
status-firefox62:
affected → ---
Depends on: 1475802
Assignee | ||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•