Closed
Bug 1470100
Opened 7 years ago
Closed 7 years ago
Stop hardcoding the length of the initial prefs list
Categories
(Testing :: geckodriver, enhancement, P1)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
Details
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
Details |
This is a footgun for people trying to just modify this list, and it shouldn't be necessary to manually track the length of the list.
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Attachment #8986728 -
Flags: review?(hskupin) → review?(ato)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8986728 [details]
Bug 1470100 - use a vector instead of an array for the list of prefs,
https://reviewboard.mozilla.org/r/252024/#review258442
Thanks for the patch! I didn’t expect you to fix this, but much
appreciated.
Attachment #8986728 -
Flags: review?(ato) → review+
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Comment 3•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s ea823a7acea1d8ec9019a518f9aca5d1ec6650aa -d e95567b7138d: rebasing 469372:ea823a7acea1 "Bug 1470100 - use a vector instead of an array for the list of prefs, r=ato" (tip)
merging testing/geckodriver/src/prefs.rs
warning: conflicts while merging testing/geckodriver/src/prefs.rs! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
|
|
||
Updated•7 years ago
|
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•7 years ago
|
||
Comment on attachment 8986728 [details]
Bug 1470100 - use a vector instead of an array for the list of prefs,
Ugh, repushing this after rebasing was a bad idea...
Attachment #8986728 -
Flags: review?(hskupin)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fec9f43850d3
use a vector instead of an array for the list of prefs, r=ato
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•