Closed Bug 1470106 Opened 2 years ago Closed 2 years ago

geckodriver doesn't want to be recompiled when changed

Categories

(Testing :: geckodriver, defect)

Version 3
Unspecified
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: Gijs, Unassigned)

Details

I changed geckodriver/prefs.rs by removing the first line of the definition of the prefs array. This should *definitely* cause a compile error, as the braces now don't match and whatever else.

Here's terminal output:

ranger:mozilla-unified gkruitbosch$ cat $MOZCONFIG
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../builds/opt

ac_add_options --enable-warnings-as-errors

ranger:mozilla-unified gkruitbosch$ ./mach build testing/geckodriver/
 0:00.42 /usr/bin/make -C /Users/gkruitbosch/dev/builds/opt -j8 -s backend
 0:00.67 /usr/bin/make -j8 -s testing
 0:00.91 /usr/bin/make -j8 -s testing/geckodriver
 0:01.14 302 compiler warnings present.
 0:01.20 Your build was successful!

ranger:mozilla-unified gkruitbosch$ ./mach build binaries
 0:00.42 /usr/bin/make -C /Users/gkruitbosch/dev/builds/opt -j8 -s backend
 0:00.67 /usr/bin/make -j8 -s binaries
 0:01.51 Elapsed: 0.36s; From dist/include: Kept 5288 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.85 force-cargo-library-build
 0:02.86     Finished release [optimized] target(s) in 0.1 secs
 0:04.64 302 compiler warnings present.
 0:04.70 Overall system resources - Wall time: 4s; CPU: 71%; Read bytes: 323584; Write bytes: 1138688; Read time: 15; Write time: 162
 0:04.70 Swap in/out (MB): 0/0
 0:04.70 Your build was successful!
To view resource usage of the build, run |mach resource-usage|.

ranger:mozilla-unified gkruitbosch$ ./mach build
 0:00.48 Clobber not needed.
 0:00.49 Adding make options from /Users/gkruitbosch/dev/configs/opt
    MOZ_OBJDIR=/Users/gkruitbosch/dev/builds/opt
    OBJDIR=/Users/gkruitbosch/dev/builds/opt
    FOUND_MOZCONFIG=/Users/gkruitbosch/dev/configs/opt
    export FOUND_MOZCONFIG
 0:00.50 /usr/bin/make -f client.mk -s
 0:01.31 Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.32 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.32 Elapsed: 0.00s; From dist/xpi-stage: Kept 7 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.46 Elapsed: 0.14s; From _tests: Kept 1065 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.56 Elapsed: 0.25s; From dist/bin: Kept 2386 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.71 Elapsed: 0.39s; From dist/include: Kept 5288 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:02.73 force-cargo-library-build
 0:03.82     Finished release [optimized] target(s) in 0.1 secs
 0:15.02   adding: install.rdf (deflated 53%)
 0:15.02   adding: plugins/Test.plugin/Contents/MacOS/libnptest.dylib (deflated 67%)
 0:15.02   adding: plugins/Test.plugin/Contents/Info.plist (deflated 54%)
 0:15.03   adding: plugins/SecondTest.plugin/Contents/MacOS/libnpsecondtest.dylib (deflated 67%)
 0:15.03   adding: plugins/SecondTest.plugin/Contents/Info.plist (deflated 59%)
 0:15.03   adding: plugins/ThirdTest.plugin/Contents/MacOS/libnpthirdtest.dylib (deflated 67%)
 0:15.03   adding: plugins/ThirdTest.plugin/Contents/Info.plist (deflated 59%)
 0:15.03   adding: plugins/npswftest.plugin/Contents/MacOS/libnpswftest.dylib (deflated 67%)
 0:15.03   adding: plugins/npswftest.plugin/Contents/Info.plist (deflated 59%)
 0:27.04 Packaging specialpowers@mozilla.org.xpi...
 0:27.24 Packaging quitter@mozilla.org.xpi...
 0:33.02 Packaging mozscreenshots@mozilla.org.xpi...
 0:33.19 302 compiler warnings present.
 0:33.25 Overall system resources - Wall time: 33s; CPU: 29%; Read bytes: 69054464; Write bytes: 84832256; Read time: 3654; Write time: 1304
 0:33.25 Swap in/out (MB): 0/0
 0:33.26 Your build was successful!
To view resource usage of the build, run |mach resource-usage|.
To take your build for a test drive, run: |mach run|
For more information on what to do now, see https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox


At least one of these commands should have errored (ideally all 3). I don't understand how to force the build system to recompile these bits.
Summary: geckodriver isn't being built → geckodriver doesn't want to be recompiled when changed
OS: Unspecified → Mac OS X
No longer blocks: 1470100
For geckodriver to be included in a local build you need "ac_add_options
--enable-geckodriver" in your mozconfig.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
I cannot find a place where this is documented. So reopening the bug for documentation.  Maybe somewhere next to:

https://firefox-source-docs.mozilla.org/testing/geckodriver/geckodriver/Releasing.html
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Actually the documentation in how to build is hidden in the not human-readable README.md file, which then gets only published to Github, and ends-up at:

https://github.com/mozilla/geckodriver/#building

I would propose that we move that part of the doc to the internal documenation.

Andreas, are you fine with this proposal?
Flags: needinfo?(ato)
Yes of course the firefox-source-docs.m.o documentation can be
improved, but I don’t feel we should remove the reference from the
README.
Flags: needinfo?(ato)
I feel that fixing the documentation in this bug is not the right
thing to do, so I filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1473054 to follow up
on improving the build documentation on firefox-source-docs.m.o.
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.