1470307 - Fix Lightning preference pane and mozmill test

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Replace open_pref_window() with open_pref_tab() in calendar/test/mozmill/shared-modules/test-calendar-utils.js an adjust tests accordingly.

In bug 1465061 we moved all preferences to a tab and fixed the related tests here:
https://hg.mozilla.org/comm-central/rev/4111f577309c
Since Calender UI and MozMill are currently not working, we couldn't update the Calendar tests.

Geoff this one is for you ;-)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1470307-test-prefs-tab-1.diff

Well, now I know how some mozmill stuff works.

This test still isn't actually run, so I'm just going to leave it here for now.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1470307-prefs-tab-1.diff

This patch moves the overlays' <script> tags higher in the hierarchy so they're picked up by the overlay loader, and performs some actions that would've happened if this code was around when page load completed.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1470307-test-prefs-tab-2.diff

Same as the earlier patch, except now that we have a new overlay loader, we need to wait until things are ready before beginning.

Comment 4

[Geoff Lankow (:darktrojan)]

Sigh, we have two different objects called "Preferences". Get one when you're expecting the other and you're going to have a bad time.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1470307-prefs-tab-2.diff

This stops polluting the preferences tab window with a Preferences object, fixing the fonts subdialog. Also, I fixed the bit that remembers which preferences subtab we're on.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8992512 [details] [diff] [review]
1470307-prefs-tab-2.diff

Review of attachment 8992512 [details] [diff] [review]:
-----------------------------------------------------------------

wat? There is a thing called |Preferences| that is not Preferences.jsm? Can we rename the other Preferences thing so that it is Preferences.jsm regardless?

Comment 7

[Geoff Lankow (:darktrojan)]

It appears to be an important part of the Firefox preference UI. I'd rather not be arguing with them about it.

Comment 8

[Geoff Lankow (:darktrojan)]

Looks like they've already had that discussion in bug 1379338 and done nothing about it.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8992512 [details] [diff] [review]
1470307-prefs-tab-2.diff

Review of attachment 8992512 [details] [diff] [review]:
-----------------------------------------------------------------

Very well then, r=philipp

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ca94a7325ca9
Fix Lightning preference UI to work with new overlays; r=philipp
https://hg.mozilla.org/comm-central/rev/630c57d2b412
Replace open_pref_window() with open_pref_tab() in test-calendar-utils.js; r=philipp

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 8992287 [details] [diff] [review]
1470307-test-prefs-tab-2.diff

Needed for TB 62 beta, Cal 6.4.

Comment 12

[Jorg K (CEST = GMT+2)]

Beta (TB 62, Cal 6.4):
https://hg.mozilla.org/releases/comm-beta/rev/5c9762db30bdfde5a68dcdeb4a9a905627cc08e0
https://hg.mozilla.org/releases/comm-beta/rev/96ecd38678b53dc56f2665be7091ceb7a492ebc7