Closed Bug 1470307 Opened 3 years ago Closed 3 years ago

Fix Lightning preference pane and mozmill test

Categories

(Calendar :: General, enhancement)

Lightning 6.2
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

References

Details

Attachments

(2 files, 2 obsolete files)

Replace open_pref_window() with open_pref_tab() in calendar/test/mozmill/shared-modules/test-calendar-utils.js an adjust tests accordingly.

In bug 1465061 we moved all preferences to a tab and fixed the related tests here:
https://hg.mozilla.org/comm-central/rev/4111f577309c
Since Calender UI and MozMill are currently not working, we couldn't update the Calendar tests.

Geoff this one is for you ;-)
Flags: needinfo?(geoff)
Attached patch 1470307-test-prefs-tab-1.diff (obsolete) β€” β€” Splinter Review
Well, now I know how some mozmill stuff works.

This test still isn't actually run, so I'm just going to leave it here for now.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Blocks: 1473244
Attachment #8989131 - Flags: review?(philipp)
Attachment #8989131 - Flags: review?(philipp) → review+
Attached patch 1470307-prefs-tab-1.diff (obsolete) β€” β€” Splinter Review
This patch moves the overlays' <script> tags higher in the hierarchy so they're picked up by the overlay loader, and performs some actions that would've happened if this code was around when page load completed.
Attachment #8992286 - Flags: review?(philipp)
Same as the earlier patch, except now that we have a new overlay loader, we need to wait until things are ready before beginning.
Attachment #8989131 - Attachment is obsolete: true
Attachment #8992287 - Flags: review?(philipp)
Summary: Replace open_pref_window() with open_pref_tab() in test-calendar-utils.js → Fix Lightning preference pane and mozmill test
Attachment #8992286 - Flags: review?(philipp) → review+
Attachment #8992287 - Flags: review?(philipp) → review+
Sigh, we have two different objects called "Preferences". Get one when you're expecting the other and you're going to have a bad time.
Attached patch 1470307-prefs-tab-2.diff β€” β€” Splinter Review
This stops polluting the preferences tab window with a Preferences object, fixing the fonts subdialog. Also, I fixed the bit that remembers which preferences subtab we're on.
Attachment #8992286 - Attachment is obsolete: true
Attachment #8992512 - Flags: review?(philipp)
Comment on attachment 8992512 [details] [diff] [review]
1470307-prefs-tab-2.diff

Review of attachment 8992512 [details] [diff] [review]:
-----------------------------------------------------------------

wat? There is a thing called |Preferences| that is not Preferences.jsm? Can we rename the other Preferences thing so that it is Preferences.jsm regardless?
It appears to be an important part of the Firefox preference UI. I'd rather not be arguing with them about it.
Looks like they've already had that discussion in bug 1379338 and done nothing about it.
Comment on attachment 8992512 [details] [diff] [review]
1470307-prefs-tab-2.diff

Review of attachment 8992512 [details] [diff] [review]:
-----------------------------------------------------------------

Very well then, r=philipp
Attachment #8992512 - Flags: review?(philipp) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ca94a7325ca9
Fix Lightning preference UI to work with new overlays; r=philipp
https://hg.mozilla.org/comm-central/rev/630c57d2b412
Replace open_pref_window() with open_pref_tab() in test-calendar-utils.js; r=philipp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 6.5
Comment on attachment 8992287 [details] [diff] [review]
1470307-test-prefs-tab-2.diff

Needed for TB 62 beta, Cal 6.4.
Attachment #8992287 - Flags: approval-calendar-beta+
Attachment #8992512 - Flags: approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.