1470361 - Remove non-override stylesheet support for nsIEditorStyleSheets.

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Nobody uses them (c-c nor bluegriffon), and they add complexity because they're doc stylesheets but they're not owned by the document.

This bug will only remove support from editor, style system simplifications will come in a followup bug.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470361: Remove nsIEditorStyleSheets.addStyleSheet / removeStyleSheet / replaceStyleSheet.

These are effectively equivalent to appending a <link> element to the body, are
not unused, and bring in a fair amount of complexity because even though they're
owned by the document and stored in the document's mStyleSheets, they're not
owned by it per se, which causes confusion.

Unless I've missed something, both bluegriffon and common-central use the
*Override APIs, which this patch leaves untouched.

Review commit: https://reviewboard.mozilla.org/r/252200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252200/

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8986965 [details]
Bug 1470361: Remove nsIEditorStyleSheets.addStyleSheet / removeStyleSheet / replaceStyleSheet.

https://reviewboard.mozilla.org/r/252200/#review258678

Is editor/libeditor/tests/test_bug468353.html still necessary?  This test calls removeStyleSheet method.  It is OK if removing this test.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

You're right, I missed that one. I removed the test. Thanks!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8986965 [details]
Bug 1470361: Remove nsIEditorStyleSheets.addStyleSheet / removeStyleSheet / replaceStyleSheet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252200/diff/1-2/

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8986965 [details]
Bug 1470361: Remove nsIEditorStyleSheets.addStyleSheet / removeStyleSheet / replaceStyleSheet.

https://reviewboard.mozilla.org/r/252200/#review259072

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/913161ea522e
Remove nsIEditorStyleSheets.addStyleSheet / removeStyleSheet / replaceStyleSheet. r=m_kato

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/913161ea522e