1471111 - Port | Bug 1449522 - Remove nsIEditorStyleSheets | to comm-central

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P3)

Description

[Takanori MATSUURA]

+++ This bug was initially created as a clone of Bug #1449522 +++

nsIEditorStyleSheets will be removed from m-c.
https://searchfox.org/comm-central/search?q=nsIEditorStyleSheets&case=false&regexp=false&path=

Comment 1

[Emilio Cobos Álvarez (:emilio)]

We haven't removed nsIEditorStyleSheets, only some of the APIs which, afaik, aren't used by comm-central.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

(That being said, if you removed nsIEditorStyleSheets usage from comm-central, it'd certainly be nice!)

Comment 3

[Jorg K (CEST = GMT+2)]

Looks like there are only two uses:
https://dxr.mozilla.org/comm-central/search?q=nsIEditorStyleSheets&redirect=false

editor/ui/composer/content/editor.js
276 editor.QueryInterface(nsIEditorStyleSheets);
1900 editor.QueryInterface(nsIEditorStyleSheets);

mail/components/compose/content/MsgComposeCommands.js
3038 var editorStyle = editor.QueryInterface(Ci.nsIEditorStyleSheets);
6790 editor.QueryInterface(nsIEditorStyleSheets);

We use it to add style sheets. Is there a replacement or a better way to do it?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I don't mind to move necessary methods to nsIHTMLEditor or somewhere if there is no equivalent but we can get rid of an interface.

Comment 5

[Wayne Mery (:wsmwk)]

To what extent was this completed in bug 1449522 ?

Comment 6

[Magnus Melin [:mkmelin]]

This was all fixed by bug 1449522, thx.