1470494 - Set up indexer and "mark occurrences" prefs appropriately when generating Eclipse CDT project

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, defect)

Description

[Botond Ballo [:botond]]

From bug 1001175 comment 3:
> The "Mark occurrences" setting (Preferences -> C/C++ -> Editor -> Mark
> Occurrences" is not enabled by default.

From bug 1001175 comment 4:
> The "Automatically update the index" and "Update index immediately after
> every file-save" settings (Preferences -> C/C++ -> Indexer -> Indexing
> strategy) are not enabled by default. These settings are critical to get
> accurate parsing as you're editing code. For example, if you add a new field
> to a class in a header file, and then write code in the cpp file that uses
> the new field, if these settings aren't enabled then Eclipse won't know
> about the new field until a full reindex.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1470494 - Configure indexer in generated Eclipse CDT project to automatically update the index.

Review commit: https://reviewboard.mozilla.org/r/252390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252390/

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1470494 - Configure 'mark occurrences' preferences in generated Eclipse CDT project.

Review commit: https://reviewboard.mozilla.org/r/252392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252392/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8987160 [details]
Bug 1470494 - Configure indexer in generated Eclipse CDT project to automatically update the index.

https://reviewboard.mozilla.org/r/252390/#review258872

rubber-stamping

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8987161 [details]
Bug 1470494 - Configure 'mark occurrences' preferences in generated Eclipse CDT project.

https://reviewboard.mozilla.org/r/252392/#review258874

ditto

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/009ea74a5c3e
Configure indexer in generated Eclipse CDT project to automatically update the index. r=kats
https://hg.mozilla.org/integration/autoland/rev/38d06add95db
Configure 'mark occurrences' preferences in generated Eclipse CDT project. r=kats

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/009ea74a5c3e
https://hg.mozilla.org/mozilla-central/rev/38d06add95db

Comment 7

[Jonathan Watt [:jwatt]]

Botond, does the addition of the indexer.updatePolicy=0 actually work for you? If I remove the eclipse output dir and regenerate the project, indexing does not happen for me when I open it.

Annoyingly I haven't been able to figure out a way to have both the _import_project step not index, and have the project index the first time it's opened by the user after mach build-backend -b CppEclipse.

Comment 8

[Botond Ballo [:botond]]

(In reply to Jonathan Watt [:jwatt] from comment #7)

Botond, does the addition of the indexer.updatePolicy=0 actually work for you? If I remove the eclipse output dir and regenerate the project, indexing does not happen for me when I open it.

For me, indexing does happen when I open the project (as far as I can remember).

indexer.updatePolicy is about whether incremental indexing happens automatically in response to file changes (so e.g. whether an edit to a header file will trigger an index update so that the .cpp file reflects the change).

Now that you mention it, the addition of indexer.updatePolicy=0 has not been having the intended effect for me, but I haven't had time to investigate why.