1470557 - Intermittent Failures View not scrolling

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Geoff Brown [:gbrown]]

This seemed to start just recently (I noticed it yesterday).

Most IFV pages are not scrolling for me: There's one screen of data, but nothing more. For example,

https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2018-06-15&endday=2018-06-22&tree=trunk&bug=1411358

I know there's a big list of failures for that bug, but I can only see one.

Comment 1

[Ed Morley [:emorley]]

(In reply to Geoff Brown [:gbrown] from comment #0)
> This seemed to start just recently (I noticed it yesterday).

Was the yesterday occurrence locally, or on production? If production, that excludes anything that was deployed today (which is the last 50+ commits).

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3707

Comment 3

[Sarah Clements [:sclements]]

I think this might've been caused by a recent global CSS style change.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8987193 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3707

I'll defer this review to Cameron (who is back Monday), since:
* it may be this + the perfherder fixup means the initial change to the global CSS file should be reverted.
* today's prod deploy was reverted, so this bug no longer occurs in production

Comment 5

[Ed Morley [:emorley]]

> * today's prod deploy was reverted, so this bug no longer occurs in production

(...and so it's fine to wait until Monday)

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8987193 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3707

Shoot, so sorry I broke your page!  But, tbh, I'd rather have each app take control of its own scrolling, if that's cool with everybody.  Scrolling has been tricky with some of the changes I've been making, and this way there's less chance I'll break another app in the future.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/706cd31edb9f8b3824eb0cdbf5edf46666bc2422
Bug 1470557 - fix IFV scrolling (#3707)