1450022 - Convert the rest of the details panel to ReactJS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Description

[Cameron Dawson [:camd]]

Part of the overall conversion to ReactJS.

Estimated difficulty of 8

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3621

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8983604 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3621

OK, so this is huge, I know.  It's large enough that it might even make sense just to review it all as new code in the ``/job-view/details/`` folder and forget the diff for the most part.

I'm not sure if there is too much separation of commits I could do.  That was part of the difficulty with this.  It was all so intertwined.  I can split out the quote changes from " to ' and the param changes like ``is_staff`` to ``isStaff`` and ``isLoggedIn`` and such.  Not sure if that would help much, though.

Please let me know if there's anything I can do to make reviewing this easier.  I apologize it's a monster...

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8983604 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3621

Have left some comments :-)

Comment 4

[Sarah Clements [:sclements]]

Comment on attachment 8983604 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3621

Also left a few comments :)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/15721f009c325256b754bd3f8ce29c16041478af
Bug 1450022 - Convert the rest of Details Panel to ReactJS (#3621)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/12e819dc19c5ee5e390069b6a7dc273f847fb90c
Bug 1450022 - Fix backfilling unavailable (#3681)

This was due to ``currentRepo`` not getting passed to the DetailsPanel, and it fell back
to the default value every time.  Also cleaned up a few props to make them required
without defaults.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3692

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3694

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/48b8979cc727636161859368c42357aef43dd000
Bug 1450022 - Remove unused focusMe directive (#3692)

Its last usage was in `ui/partials/main/thPinboardPanel.html`.

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/40a1a18841265280bb7a573df7bff3147b7af884
Bug 1450022 - Fix error with backfilling (#3694)