1470677 - Undo duplication in browser_multiselect_tabs_mute_unmute.js test file by moving browser_audioTabIcon.js to /browser/base/content/test/tabs directory.

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Abdoulaye O. LY]

A follow-up of bug 1458039 (see https://reviewboard.mozilla.org/r/251550/#review258210).

There are duplication of some function in https://searchfox.org/mozilla-central/source/browser/base/content/test/tabs/browser_multiselect_tabs_mute_unmute.js from https://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser_audioTabIcon.js that could be undone by moving the latter into the directory where the former is located. Duplicated functions could then be moved to https://searchfox.org/mozilla-central/source/browser/base/content/test/tabs/head.js.

Comment 1

[Abdoulaye O. LY]

Attachment: Bug 1470677 - Undo duplication in browser_multiselect_tabs_mute_unmute.js test file by moving browser_audioTabIcon.js to /browser/base/content/test/tabs directory.

Review commit: https://reviewboard.mozilla.org/r/253342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253342/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8988079 [details]
Bug 1470677 - Undo duplication in browser_multiselect_tabs_mute_unmute.js test file by moving browser_audioTabIcon.js to /browser/base/content/test/tabs directory.

https://reviewboard.mozilla.org/r/253342/#review260018

::: browser/base/content/test/tabs/browser.ini:12
(Diff revision 1)
>  
>  [browser_abandonment_telemetry.js]
>  [browser_accessibility_indicator.js]
>  skip-if = (verify && debug && (os == 'linux'))
>  [browser_allow_process_switches_despite_related_browser.js]
> +[browser_audioTabIcon.js]

This should still have the `tags = audiochannel` below it.

::: browser/base/content/test/tabs/head.js:160
(Diff revision 1)
> +  if (isAudioPlaying) {
> +    await wait_for_tab_playing_event(tab, !expectMuted);
> +  }
> +
> +  return mutedPromise;
> +}

Can you please put a newline at the end of this file?

Comment 3

[Abdoulaye O. LY]

Comment on attachment 8988079 [details]
Bug 1470677 - Undo duplication in browser_multiselect_tabs_mute_unmute.js test file by moving browser_audioTabIcon.js to /browser/base/content/test/tabs directory.

https://reviewboard.mozilla.org/r/253342/#review260018

> Can you please put a newline at the end of this file?

Yes, I think we already have an new line at the end. Though I don't know why it's not showing here.

Comment 4

[Abdoulaye O. LY]

Comment on attachment 8988079 [details]
Bug 1470677 - Undo duplication in browser_multiselect_tabs_mute_unmute.js test file by moving browser_audioTabIcon.js to /browser/base/content/test/tabs directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253342/diff/1-2/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Abdoulaye O. LY from comment #3)
> Comment on attachment 8988079 [details]
> Bug 1470677 - Undo duplication in browser_multiselect_tabs_mute_unmute.js
> test file by moving browser_audioTabIcon.js to
> /browser/base/content/test/tabs directory.
> 
> https://reviewboard.mozilla.org/r/253342/#review260018
> 
> > Can you please put a newline at the end of this file?
> 
> Yes, I think we already have an new line at the end. Though I don't know why
> it's not showing here.

Okay thanks for checking. Yeah, MozReview might not show it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd9f6f1e04d2
Undo duplication in browser_multiselect_tabs_mute_unmute.js test file by moving browser_audioTabIcon.js to /browser/base/content/test/tabs directory. r=jaws

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cd9f6f1e04d2