1470684 - [RTL] Mirror the "Undo Close Tab" button icon on the All Tabs popup

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Itiel]

Attachment: Undo Close Tab icon on RTL

On RTL locales this arrow should point to the right.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1470684 - Flip undo close tab icon for RTL in all tabs menu

Review commit: https://reviewboard.mozilla.org/r/252800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252800/

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: icon-flipped.png

Comment 3

[Itiel]

(In reply to Mark Striemer [:mstriemer] (on PTO through 06/29) from comment #2)
> Created attachment 8987579 [details]
> icon-flipped.png

LGTM.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8987555 [details]
Bug 1470684 - Flip undo close tab icon for RTL in all tabs menu

https://reviewboard.mozilla.org/r/252800/#review259376

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df03281b89a5
Flip undo close tab icon for RTL in all tabs menu r=dao

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/df03281b89a5

Comment 7

[CosminB]

Attachment: 1470684.png

This issue is verified as fixed on Firefox 63.0a1 (20180627100027) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.

Comment 8

[Mark Striemer [:mstriemer]]

Comment on attachment 8987555 [details]
Bug 1470684 - Flip undo close tab icon for RTL in all tabs menu

Approval Request Comment
[Feature/Bug causing the regression]: bug 1446101
[User impact if declined]: Undo close tab icon points the wrong direction in RTL languages
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple CSS change for RTL icon
[String changes made/needed]: No

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8987555 [details]
Bug 1470684 - Flip undo close tab icon for RTL in all tabs menu

CSS fix for RTL icons, let's uplift for 62 beta 7.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Didn't land this on beta because AS bug 1470170 should also land but failed to apply.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Ignore comment 10, that was for bug 1472297.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bfdba69be345

Comment 13

[CosminB]

Attachment: Beta1470684.png

This issue is verified as fixed on Firefox 62.0b7 (20180709172241) under Win 7 64-bit and Mac OS X 10.13.3.