1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Comment 1

[Ursula Sarracini (:ursula)]

This will need to be uplifted to Beta 62

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4223

Comment 3

[Ursula Sarracini (:ursula)]

[Tracking Requested - why for this release]: We do not want to show the old onboarding experience for users who are in the experiment cohort that is seeing the new simplified onboarding experience, or else it may skew the experiment data. The experiment will run in 62.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e91d80c762c53c078df1b29b7fdf3eb094c48876
Fix Bug 1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort

https://github.com/mozilla/activity-stream/commit/e10832e38d2c4f8590a3ce93d4f9438d309c0928
Merge pull request #4223 from sarracini/bug_1472297

Fix Bug 1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Let's verify the fix too.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/0ef1451e9411

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly (63.0a1, 20180701220749) on Windows 10 x64, Mac 10.13.5 and Arch Linux x64. 
The existing onboarding experience is no longer shown if "browser.newtabpage.activity-stream.asrouterOnboardingCohort" is set to a value above "0".

Comment 8

[Ed Lee :Mardak]

Attachment: Bug 1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort.

Review commit: https://reviewboard.mozilla.org/r/254330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254330/

Comment 9

[Ed Lee :Mardak]

Comment on attachment 8989277 [details]
Bug 1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort.

This was previously reviewed by k88hudson in comment 4.

ursula, please request beta approval.

Comment 10

[Ursula Sarracini (:ursula)]

Comment on attachment 8989277 [details]
Bug 1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort.

Approval Request Comment
[Feature/Bug causing the regression]: Existing onboarding button is seen on newtab even when new onboarding experience is on
[User impact if declined]: The user will be able to access the old onboarding tour which may skew the data for the simplified onboarding experiment
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes (63.0a1, 20180701220749)
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just some css to hide an element on newtab
[String changes made/needed]: None

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8989277 [details]
Bug 1472297 - Hide the existing onboarding button for users in the new simplified onboarding experience cohort.

CSS only fix for UI issue, let's uplift for beta 7.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/eac62098b0f6

Comment 13

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Beta built (62.0b7, Build ID 20180709172241) on Windows 10 x64, Mac 10.13.6 and Arch Linux x64.