1470964 - Make confirmation hint panel blue instead of green

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Background of new bookmark confirmation doorhanger/panelUI should be blue (not green) to be consistent with Photon colors, which are mostly blue themed, while green looks kinda out of place, at least for me.

Comment 1

[Tim Nguyen :ntim]

It's the same color as the Copy link or Send Tab to Device notification which was there since 57.

Comment 2

[Marco Bonardo [:mak]]

the prototype states it should be blue
https://mozilla.invisionapp.com/redirect?url=https%3A%2F%2Fdrive.google.com%2Fopen%3Fid%3D1FR_a-NlS6NwNqzjfyvHXxk0nwDpW4ido
But I agree with comment 1 that it's unclear, we need UX confirmation about what it should be.

Comment 3

[joshuaglennrussell]

Actually, it shouldn't exist at all.  How do I get rid of it?...

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Tim Nguyen :ntim from comment #1)
> It's the same color as the Copy link or Send Tab to Device notification
> which was there since 57.

I didn't know, as I don't use these features, but if so, these notifications should also be blue, as it's main Photon style color.

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: is.png

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: should be.png

few seconds in Paint - I just grabbed blue color of bookmark star and pasted it on green background of bookmark confirmation doorhanger/panelUI (ignore still green borders etc.)

Comment 7

[Mike Taylor [:miketaylr]]

(In reply to Tim Nguyen :ntim from comment #1)
> It's the same color as the Copy link or Send Tab to Device notification
> which was there since 57.

This doesn't sound like we need to track as a regression.

Comment 8

[Aaron Benson]

Yeah, these should be blue. There are blue 'positive' indicators along the flow of creating a bookmark (the save button in the panel and the blue bookmark star) that the green looks out of place. We'll file a separate bug to update the Copy URL confirm hint to blue as well.

Comment 9

[Dão Gottwald [:dao]]

(In reply to Aaron Benson from comment #8)
> We'll file a separate bug to update the Copy URL confirm hint to blue as well.

No need, they use the same panel.

Comment 10

[Tim Nguyen :ntim]

Those 2 colors https://searchfox.org/mozilla-central/rev/88199de427d3c5762b7f3c2a4860c10734abd867/browser/themes/shared/customizableui/panelUI.inc.css#223-224 

should be set to: #0060df

Comment 11

[Bharat Raghunathan]

Attachment: Bug 1470964 - Make confirmation hint panel blue instead of green

Review commit: https://reviewboard.mozilla.org/r/258444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258444/

Comment 12

[Bharat Raghunathan]

Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

Is this the only panel whose colour has to be changed? Is there any other panel affected? (I haven't rebuilt the Nightly yet, so couldn't see the change)

Comment 13

[Tim Nguyen :ntim]

Yep, this is only the panel to change, thanks!

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

https://reviewboard.mozilla.org/r/258444/#review265470

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

I checked that the border color should not be darker than the background color. This matches the spec at https://mozilla.invisionapp.com/share/7XG2P3JSY46#/screens

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aefd790bff28
Make confirmation hint panel blue instead of green r=jaws

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aefd790bff28

Comment 18

[Dão Gottwald [:dao]]

This is not a regression.

Comment 19

[Tim Nguyen :ntim]

Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

Approval Request Comment
[Feature/Bug causing the regression]: new bookmark confirmation hint
[User impact if declined]: color between bookmark animation and bookmark confirmation hint is inconsistent
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: 
[Needs manual test from QE? If yes, steps to reproduce]: yes, bookmark a website, dismiss the popup, see the confirmation hint appear on the library button
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css variable change
[String changes made/needed]: n/a

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

Minor color fix for consistency, let's uplift.

Comment 21

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0d79a96597a0

Comment 22

[Dão Gottwald [:dao]]

Sylvestre, as previously mentioned, this confirmation panel existed prior to bug 1459907 for the Copy Link and Send Tab to Device features and it has always been green.

Comment 23

[Sylvestre Ledru [:Sylvestre]]

sorry, this is automated...

Comment 24

[joshuaglennrussell]

Ok, it's blue now.  But how can I disable it?....

Comment 25

[Bharat Raghunathan]

May I ask for try access (or Level 1 commit access)?
I have also resolved bug 1393453 and bug 1343827

Comment 26

[Maria Berlinger [:mberlinger], Services QA]

I have managed to reproduce this bug on an affected build: 63.0a1 (20180717220130) using the STR from comment 19. 

This is verified fixed on Nightly 63.0a1 (20180723220051) and Beta 62.0b11 (20180723144101) on the following OSes: Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13, Windows 7 x64.

Comment 27

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Bharat Raghunathan from comment #25)
> May I ask for try access (or Level 1 commit access)?
> I have also resolved bug 1393453 and bug 1343827

Hi Bharat, please follow the steps under Procedure at https://www.mozilla.org/en-US/about/governance/policies/commit/ to get commit level 1 access.

Comment 28

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

As OP, I'm also confirming that bug is fixed, starting in Mozilla Firefox Nightly 63.0a1 (2018-07-27) and as well in Mozilla Firefox Beta 62. Thank you very much. \o/

Comment 29

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(Virtual_ManPL [:Virtual] wrote in comment #28)
> starting in Mozilla Firefox Nightly 63.0a1 (2018-07-21)
fixed