Closed Bug 1470964 Opened 4 years ago Closed 4 years ago

Make confirmation hint panel blue instead of green

Categories

(Firefox :: Theme, defect, P3)

x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: Virtual, Assigned: bharatraghunthan9767, Mentored)

References

Details

(Keywords: good-first-bug, nightly-community, Whiteboard: [fxsearch])

Attachments

(3 files)

Background of new bookmark confirmation doorhanger/panelUI should be blue (not green) to be consistent with Photon colors, which are mostly blue themed, while green looks kinda out of place, at least for me.
Has Regression Range: --- → yes
Has STR: --- → irrelevant
It's the same color as the Copy link or Send Tab to Device notification which was there since 57.
the prototype states it should be blue
https://mozilla.invisionapp.com/redirect?url=https%3A%2F%2Fdrive.google.com%2Fopen%3Fid%3D1FR_a-NlS6NwNqzjfyvHXxk0nwDpW4ido
But I agree with comment 1 that it's unclear, we need UX confirmation about what it should be.
Severity: major → normal
Flags: needinfo?(abenson)
Priority: -- → P2
Whiteboard: [fxsearch]
(In reply to Tim Nguyen :ntim from comment #1)
> It's the same color as the Copy link or Send Tab to Device notification
> which was there since 57.

I didn't know, as I don't use these features, but if so, these notifications should also be blue, as it's main Photon style color.
Attached image should be.png
few seconds in Paint - I just grabbed blue color of bookmark star and pasted it on green background of bookmark confirmation doorhanger/panelUI (ignore still green borders etc.)
(In reply to Tim Nguyen :ntim from comment #1)
> It's the same color as the Copy link or Send Tab to Device notification
> which was there since 57.

This doesn't sound like we need to track as a regression.
Keywords: regression
Component: Bookmarks & History → Theme
Keywords: uiwanted
Priority: P2 → P5
Summary: Background of new bookmark confirmation doorhanger/panelUI should be blue (not green) → Make confirmation hint panel blue instead of green
Yeah, these should be blue. There are blue 'positive' indicators along the flow of creating a bookmark (the save button in the panel and the blue bookmark star) that the green looks out of place. We'll file a separate bug to update the Copy URL confirm hint to blue as well.
Flags: needinfo?(abenson)
(In reply to Aaron Benson from comment #8)
> We'll file a separate bug to update the Copy URL confirm hint to blue as well.

No need, they use the same panel.
Priority: P5 → P3
Mentor: ntim.bugs
Keywords: good-first-bug
Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

Is this the only panel whose colour has to be changed? Is there any other panel affected? (I haven't rebuilt the Nightly yet, so couldn't see the change)
Flags: needinfo?(ntim.bugs)
Attachment #8993735 - Flags: review?(ntim.bugs)
Yep, this is only the panel to change, thanks!
Flags: needinfo?(ntim.bugs)
Assignee: nobody → bharatraghunthan9767
Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

https://reviewboard.mozilla.org/r/258444/#review265470
Attachment #8993735 - Flags: review+
I checked that the border color should not be darker than the background color. This matches the spec at https://mozilla.invisionapp.com/share/7XG2P3JSY46#/screens
Attachment #8993735 - Flags: review?(ntim.bugs)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aefd790bff28
Make confirmation hint panel blue instead of green r=jaws
https://hg.mozilla.org/mozilla-central/rev/aefd790bff28
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
This is not a regression.
Keywords: regression, uiwanted
Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

Approval Request Comment
[Feature/Bug causing the regression]: new bookmark confirmation hint
[User impact if declined]: color between bookmark animation and bookmark confirmation hint is inconsistent
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: 
[Needs manual test from QE? If yes, steps to reproduce]: yes, bookmark a website, dismiss the popup, see the confirmation hint appear on the library button
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: css variable change
[String changes made/needed]: n/a
Attachment #8993735 - Flags: approval-mozilla-beta?
Comment on attachment 8993735 [details]
Bug 1470964 - Make confirmation hint panel blue instead of green

Minor color fix for consistency, let's uplift.
Attachment #8993735 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Sylvestre, as previously mentioned, this confirmation panel existed prior to bug 1459907 for the Copy Link and Send Tab to Device features and it has always been green.
Keywords: regression
Status: RESOLVED → REOPENED
Keywords: regression
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
sorry, this is automated...
Has Regression Range: yes → irrelevant
Ok, it's blue now.  But how can I disable it?....
May I ask for try access (or Level 1 commit access)?
I have also resolved bug 1393453 and bug 1343827
Flags: needinfo?(ntim.bugs)
I have managed to reproduce this bug on an affected build: 63.0a1 (20180717220130) using the STR from comment 19. 

This is verified fixed on Nightly 63.0a1 (20180723220051) and Beta 62.0b11 (20180723144101) on the following OSes: Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13, Windows 7 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
(In reply to Bharat Raghunathan from comment #25)
> May I ask for try access (or Level 1 commit access)?
> I have also resolved bug 1393453 and bug 1343827

Hi Bharat, please follow the steps under Procedure at https://www.mozilla.org/en-US/about/governance/policies/commit/ to get commit level 1 access.
Flags: needinfo?(ntim.bugs)
As OP, I'm also confirming that bug is fixed, starting in Mozilla Firefox Nightly 63.0a1 (2018-07-27) and as well in Mozilla Firefox Beta 62. Thank you very much. \o/
(Virtual_ManPL [:Virtual] wrote in comment #28)
> starting in Mozilla Firefox Nightly 63.0a1 (2018-07-21)
fixed
You need to log in before you can comment on or make changes to this bug.