1470993 - Fix reflect mingw clang compilation

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jacek Caban]

As discussed in bug 1390583, win64 assembly function should not have stdcall decorations (stdcall is not a thing in win64; it works on GCC because it still supports applying stdcall name fixup there) and .scl directive should mark them as external.

Comment 1

[Jacek Caban]

Attachment: Bug 1470993 - Fix reflect mingw clang compilation

Review commit: https://reviewboard.mozilla.org/r/252854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252854/

Comment 2

[Jacek Caban]

Comment on attachment 8987630 [details]
Bug 1470993 - Fix reflect mingw clang compilation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252854/diff/1-2/

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8987630 [details]
Bug 1470993 - Fix reflect mingw clang compilation

https://reviewboard.mozilla.org/r/252854/#review259492

I am not the right person to review this... dmajor, are you?

Comment 4

[(Away)]

Comment on attachment 8987630 [details]
Bug 1470993 - Fix reflect mingw clang compilation

https://reviewboard.mozilla.org/r/252854/#review259506

It's reasonable not to include the stdcall decorators for Win64... if the compiler is happy with this, it seems fine to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e0221491bf7
Fix reflect mingw clang compilation r=dmajor

Comment 6

[Tom Ritter [:tjr]]

Comment on attachment 8987630 [details]
Bug 1470993 - Fix reflect mingw clang compilation

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit affects all configurations; but if it were broken the browser would crash often and loudly.

Comment 7

[(Away)]

(In reply to Tom Ritter [:tjr] from comment #6)
> This commit affects all configurations; but if it were broken the browser
> would crash often and loudly.

The affected files are under ...win...gnu.cpp so it ought to be mingw-specific.

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1e0221491bf7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8987630 [details]
Bug 1470993 - Fix reflect mingw clang compilation

Makes downstream maintenance easier for Tor. Approved for ESR 60.2.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/c97eb25fa314