1491856 - Fix reflect mingw clang x86 compilation by changing .scl 3 -> 2

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Same change as Bug 1470993 except for x86

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

As in Bug 1390583 and Bug 1470993, this will correct them to be external symbols

Comment 2

[(Away)]

Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

David Major [:dmajor] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb92888e989b
Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/eb92888e989b

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to fix the mingw-clang build for esr60

User impact if declined: Tor will have to carry this patch themselves, and we won't be able to run mingw-clang in automation.

Fix Landed on Version: 64.0a1 / 20180918075510

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The same fix was applied in esr60 in Bug 1470993 for x64 and had no problems.

String or UUID changes made by this patch:

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

Low risk, useful for build automation, let's take this for ESR60.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/1325a6954b87