Closed Bug 1491856 Opened 1 year ago Closed 1 year ago

Fix reflect mingw clang x86 compilation by changing .scl 3 -> 2

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox-esr60 64+ fixed
firefox64 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

Component: General: Unsupported Platforms → XPCOM
Product: Firefox Build System → Core
Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

David Major [:dmajor] has approved the revision.
Attachment #9009634 - Flags: review+
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb92888e989b
Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/eb92888e989b
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to fix the mingw-clang build for esr60

User impact if declined: Tor will have to carry this patch themselves, and we won't be able to run mingw-clang in automation.

Fix Landed on Version: 64.0a1 / 20180918075510

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The same fix was applied in esr60 in Bug 1470993 for x64 and had no problems.

String or UUID changes made by this patch:
Attachment #9009634 - Flags: approval-mozilla-esr60?
Comment on attachment 9009634 [details]
Bug 1491856 Change .scl 3 -> .scl 2 in the reflect assembly r=dmajor

Low risk, useful for build automation, let's take this for ESR60.
Attachment #9009634 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.