Closed Bug 1471261 Opened 2 years ago Closed 2 years ago

Fix FreeType race conditions with OMTP enabled

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

There are some crashes mentioned in bug 1432531 that are caused by race conditions in our freetype and cairo-ft code.
Here's a green try run with OMTP enabled on linux with some patches lsalzman wrote.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a839483173552e4852624d6e6f86429657775d8e
Comment on attachment 8987922 [details]
Bug 1471261 - Fix race condition in cairo-ft when checking whether face is being used.

https://reviewboard.mozilla.org/r/253204/#review259776
Attachment #8987922 - Flags: review?(lsalzman) → review+
Comment on attachment 8987923 [details]
Bug 1471261 - Add global locking around FT_Load_Glyph to work around postscript hinter global data.

https://reviewboard.mozilla.org/r/253206/#review259778
Attachment #8987923 - Flags: review?(lsalzman) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1163e09adf4e
Fix race condition in cairo-ft when checking whether face is being used. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3a0360cf74
Add global locking around FT_Load_Glyph to work around postscript hinter global data. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/1163e09adf4e
https://hg.mozilla.org/mozilla-central/rev/bb3a0360cf74
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.