Open Bug 1471301 Opened 2 years ago Updated 1 year ago

Consider supporting theme previews for static webextension themes

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

People

(Reporter: ntim, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

This isn't too hard to do, and theme previews can be useful in the customize mode, or even AMO.
Please tell more about this.
How can I work on this?
Flags: needinfo?(ntim.bugs)
This probably isn't trivial until we actually remove lightweight theme support.
Flags: needinfo?(ntim.bugs)
(In reply to Tim Nguyen :ntim from comment #0)
> This isn't too hard to do,

Can you elaborate?  We would need to download the whole xpi, then be sure to delete it (which is chock full of corner cases).
AMO would also have to do work to enable previews which I believe they explicitly decided not to do.
Without a more detailed explanation of how we could do this easily, this is probably WONTFIX.
Flags: needinfo?(ntim.bugs)
(In reply to Andrew Swan [:aswan] from comment #3)
> (In reply to Tim Nguyen :ntim from comment #0)
> > This isn't too hard to do,
> 
> Can you elaborate?  We would need to download the whole xpi, then be sure to
> delete it (which is chock full of corner cases).
> AMO would also have to do work to enable previews which I believe they
> explicitly decided not to do.
> Without a more detailed explanation of how we could do this easily, this is
> probably WONTFIX.

I was thinking about customization mode previews more than AMO previews.

Since the add-ons would already be available locally, you'd get the manifest, then temporarily render it using LWTConsumer.jsm.

I'm fine with WONTFIX if this is also what UX wants for the customization mode (in addition to AMO).
Flags: needinfo?(ntim.bugs)
> I'm fine with WONTFIX if this is also what UX wants for the customization
> mode (in addition to AMO).

what = removing previews
Ah, Addons Manager isn't the right component for this then
Component: Themes → Toolbars and Customization
Product: WebExtensions → Firefox
Depends on: 1451402
Priority: -- → P3
Blocks: 1530293
Priority: P3 → P5
You need to log in before you can comment on or make changes to this bug.