1471301 - Consider supporting theme previews for static webextension themes

Status: NEW

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Tim Nguyen :ntim]

This isn't too hard to do, and theme previews can be useful in the customize mode, or even AMO.

Comment 1

[Manish [:manishkk]]

Please tell more about this.
How can I work on this?

Comment 2

[Tim Nguyen :ntim]

This probably isn't trivial until we actually remove lightweight theme support.

Comment 3

[Andrew Swan [:aswan]]

(In reply to Tim Nguyen :ntim from comment #0)
> This isn't too hard to do,

Can you elaborate?  We would need to download the whole xpi, then be sure to delete it (which is chock full of corner cases).
AMO would also have to do work to enable previews which I believe they explicitly decided not to do.
Without a more detailed explanation of how we could do this easily, this is probably WONTFIX.

Comment 4

[Tim Nguyen :ntim]

(In reply to Andrew Swan [:aswan] from comment #3)
> (In reply to Tim Nguyen :ntim from comment #0)
> > This isn't too hard to do,
> 
> Can you elaborate?  We would need to download the whole xpi, then be sure to
> delete it (which is chock full of corner cases).
> AMO would also have to do work to enable previews which I believe they
> explicitly decided not to do.
> Without a more detailed explanation of how we could do this easily, this is
> probably WONTFIX.

I was thinking about customization mode previews more than AMO previews.

Since the add-ons would already be available locally, you'd get the manifest, then temporarily render it using LWTConsumer.jsm.

I'm fine with WONTFIX if this is also what UX wants for the customization mode (in addition to AMO).

Comment 5

[Tim Nguyen :ntim]

> I'm fine with WONTFIX if this is also what UX wants for the customization
> mode (in addition to AMO).

what = removing previews

Comment 6

[Andrew Swan [:aswan]]

Ah, Addons Manager isn't the right component for this then