1471340 - Unable to scroll after watching fullscreen video

Status: RESOLVED INVALID

(GeckoView :: Media, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

STR

1) Go to youtube.com and start a video in fullscreen mode
2) Exit fullscreen by hitting back. In Focus this erroneously causes a navigation, which may be an important detail.
3) Try to scroll. Only the urlbar moves (in Focus, at least).

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Randall reports that Firefox Reality has this bug as well

Comment 3

[Chris Peterson [:cpeterson]]

Susheel, James says this scrolling bug happens in Focus but not the geckoview_example test app. Can a Focus engineer investigate if this is a Focus bug?

Randall says Firefox Reality has this bug, too, so either Firefox Reality has the same app-side bug or this is a GV bug.

Comment 4

[:sdaswani]

Chris the fact that FR has this bug too leans towards it being a GV bug (unless FR using the Focus code base?), but I filed an issue and it will come up in the next triage meeting.

https://github.com/mozilla-mobile/focus-android/issues/2852

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Randall, leaving a NI for when you're back, is this something you could drive/own?

Comment 6

[Chris Peterson [:cpeterson]]

[geckoview:klar:p1] because this bug is a Focus+GV blocker.

Comment 7

[Randall Barker [:rbarker]]

Firefox Reality had this issue. I was able to fix the issue by checking before calling GeckoSession.goBack() if it was currently in fullscreen and exiting fullscreen instead of calling goBack. GeckoView should probably not get into a bad state from calling goBack when in fullscreen, but there is at least a workaround.

Comment 8

[Chris Peterson [:cpeterson]]

P2 because the app should be handling the back button and telling GV to exit fullscreen. This bug is asking for GV to exit fullscreen itself for apps that don't handle the back button properly themselves.

Comment 9

[Matt Brubeck (:mbrubeck)]

I can work on this.

What exactly is the desired behavior?  When `GeckoSession::goBack` is called while the app is full-screen, should it automatically exit full screen instead of navigating back, so that each app doesn't need to implement this behavior?  Or should we fix the scrolling bug and allow history navigation during full-screen, in case some apps have a use case for it?

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Matt Brubeck (:mbrubeck) from comment #9)
> I can work on this.
> 
> What exactly is the desired behavior?  When `GeckoSession::goBack` is called
> while the app is full-screen, should it automatically exit full screen
> instead of navigating back, so that each app doesn't need to implement this
> behavior?  Or should we fix the scrolling bug and allow history navigation
> during full-screen, in case some apps have a use case for it?

I think according to spec Gecko should exit fullscreen when beginning a navigation. I'm pretty sure this used to work, so we just need to find out why it's not and fix it.

Comment 11

[Matt Brubeck (:mbrubeck)]

Some notes for myself:

1. `nsIDocument::OnPageHide` should be called when navigating away from a page.
2. This calls `nsIDocument::ExitFullscreenInDocTree` which should exit full screen.
3. That creates a `ExitFullscreenScriptRunnable` which dispatches "MozDOMFullscreen:Exited" to chrome.
4. `GeckoViewContent` listens for this event, sends some messages, and should ultimately call `windowUtils.remoteFrameFullscreenReverted()`.

Comment 12

[Matt Brubeck (:mbrubeck)]

Adding some logging to GeckoViewContent, it never seems to receive the "MozDOMFullscreen:Exited" message, either in the content or chrome side.

Comment 13

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This should probably block Fenix

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e) from comment #13)

This should probably block Fenix

OK. Adding [geckoview:fenix:m5] whiteboard tag to track for Fenix MVP.

Comment 15

[Chris Peterson [:cpeterson]]

67=wontfix. Fenix MVP will use GeckoView 68, so we don't need to uplift this fix to 67 Beta unless it also affects Fennec 67.

Comment 17

[Chris Peterson [:cpeterson]]

Closing as INVALID because snorp says this bug should be fixed in Fenix app code, not GV. Fenix needs to handle Back button navigation and exit full screen mode.

OTOH, when Fenix, FxR, and Focus+GV all have the exact same bug, perhaps GV needs to do more to help app developers handle this situation.

Comment 18

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.