Closed
Bug 1471387
Opened 6 years ago
Closed 6 years ago
When running in-process webrequest sees data: uri requests from about:newtab
Categories
(WebExtensions :: Request Handling, enhancement, P2)
WebExtensions
Request Handling
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mossop, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
No description provided.
Comment 1•6 years ago
|
||
Our handling of ContentPolicy listeners is kind of a disaster, at this point. We should probably just rip out all of the stuff that was there for legacy extension support, and just rewrite most of it.
Updated•6 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mixedpuppy
Assignee | ||
Comment 3•6 years ago
|
||
This is a fix rather than a re-write, but also removing a bunch of stuff that should have been removed with bug 1393909.
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8997592 [details] Bug 1471387 fix calling onBeforeRequest for data/etc urls, https://reviewboard.mozilla.org/r/261286/#review268448 Yay, deleted code!
Attachment #8997592 -
Flags: review?(kmaglione+bmo) → review+
But what's with the ids[1][2]? [1] https://searchfox.org/mozilla-central/rev/3fdc491e118c5cdfbaf6e2d52f3466d2b27ad1de/toolkit/modules/addons/WebRequestContent.js#174 [2] https://searchfox.org/mozilla-central/rev/3fdc491e118c5cdfbaf6e2d52f3466d2b27ad1de/toolkit/modules/addons/WebRequest.jsm#257
Flags: needinfo?(mixedpuppy)
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to kernp25 from comment #5) > But what's with the ids[1][2]? good catch, that is unnecessary now.
Flags: needinfo?(mixedpuppy)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 8997592 [details] Bug 1471387 fix calling onBeforeRequest for data/etc urls, Additional changes, though small, asking a refresh on r+
Attachment #8997592 -
Flags: review+ → review?(kmaglione+bmo)
Updated•6 years ago
|
Attachment #8997592 -
Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5a51b1f6d4f9 fix calling onBeforeRequest for data/etc urls, r=kmag
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5a51b1f6d4f9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 11•6 years ago
|
||
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
Flags: needinfo?(mixedpuppy)
Assignee | ||
Comment 12•6 years ago
|
||
since everything runs OOP now there's no chance this would happen anyway (it was an in-process issue), and existing tests verify the change doesn't break anything.
Flags: needinfo?(mixedpuppy) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•