Closed Bug 1471387 Opened 3 years ago Closed 3 years ago

When running in-process webrequest sees data: uri requests from about:newtab


(WebExtensions :: Request Handling, enhancement, P2)



(firefox63 fixed)

Tracking Status
firefox63 --- fixed


(Reporter: mossop, Assigned: mixedpuppy)




(1 file)

No description provided.
Our handling of ContentPolicy listeners is kind of a disaster, at this point. We should probably just rip out all of the stuff that was there for legacy extension support, and just rewrite most of it.
Priority: -- → P2
Assignee: nobody → mixedpuppy
This is a fix rather than a re-write, but also removing a bunch of stuff that should have been removed with bug 1393909.
Comment on attachment 8997592 [details]
Bug 1471387 fix calling onBeforeRequest for data/etc urls,

Yay, deleted code!
Attachment #8997592 - Flags: review?(kmaglione+bmo) → review+
(In reply to kernp25 from comment #5)
> But what's with the ids[1][2]?

good catch, that is unnecessary now.
Flags: needinfo?(mixedpuppy)
Comment on attachment 8997592 [details]
Bug 1471387 fix calling onBeforeRequest for data/etc urls,

Additional changes, though small, asking a refresh on r+
Attachment #8997592 - Flags: review+ → review?(kmaglione+bmo)
Attachment #8997592 - Flags: review?(kmaglione+bmo) → review+
Pushed by
fix calling onBeforeRequest for data/etc urls, r=kmag
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
Flags: needinfo?(mixedpuppy)
since everything runs OOP now there's no chance this would happen anyway (it was an in-process issue), and existing tests verify the change doesn't break anything.
Flags: needinfo?(mixedpuppy) → qe-verify-
See Also: → 1631933
You need to log in before you can comment on or make changes to this bug.