59 bytes, text/x-review-board-request
No description provided.
Our handling of ContentPolicy listeners is kind of a disaster, at this point. We should probably just rip out all of the stuff that was there for legacy extension support, and just rewrite most of it.
This is a fix rather than a re-write, but also removing a bunch of stuff that should have been removed with bug 1393909.
Comment on attachment 8997592 [details] Bug 1471387 fix calling onBeforeRequest for data/etc urls, https://reviewboard.mozilla.org/r/261286/#review268448 Yay, deleted code!
But what's with the ids?  https://searchfox.org/mozilla-central/rev/3fdc491e118c5cdfbaf6e2d52f3466d2b27ad1de/toolkit/modules/addons/WebRequestContent.js#174  https://searchfox.org/mozilla-central/rev/3fdc491e118c5cdfbaf6e2d52f3466d2b27ad1de/toolkit/modules/addons/WebRequest.jsm#257
(In reply to kernp25 from comment #5) > But what's with the ids? good catch, that is unnecessary now.
Comment on attachment 8997592 [details] Bug 1471387 fix calling onBeforeRequest for data/etc urls, Additional changes, though small, asking a refresh on r+
Attachment #8997592 - Flags: review+ → review?(kmaglione+bmo)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5a51b1f6d4f9 fix calling onBeforeRequest for data/etc urls, r=kmag
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
since everything runs OOP now there's no chance this would happen anyway (it was an in-process issue), and existing tests verify the change doesn't break anything.
Flags: needinfo?(mixedpuppy) → qe-verify-
You need to log in before you can comment on or make changes to this bug.