When running in-process webrequest sees data: uri requests from about:newtab

RESOLVED FIXED in Firefox 63

Status

enhancement
P2
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: mossop, Assigned: mixedpuppy)

Tracking

unspecified
mozilla63
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

No description provided.
Our handling of ContentPolicy listeners is kind of a disaster, at this point. We should probably just rip out all of the stuff that was there for legacy extension support, and just rewrite most of it.
Priority: -- → P2
Assignee: nobody → mixedpuppy
This is a fix rather than a re-write, but also removing a bunch of stuff that should have been removed with bug 1393909.
Comment on attachment 8997592 [details]
Bug 1471387 fix calling onBeforeRequest for data/etc urls,

https://reviewboard.mozilla.org/r/261286/#review268448

Yay, deleted code!
Attachment #8997592 - Flags: review?(kmaglione+bmo) → review+
(In reply to kernp25 from comment #5)
> But what's with the ids[1][2]?

good catch, that is unnecessary now.
Flags: needinfo?(mixedpuppy)
Comment on attachment 8997592 [details]
Bug 1471387 fix calling onBeforeRequest for data/etc urls,

Additional changes, though small, asking a refresh on r+
Attachment #8997592 - Flags: review+ → review?(kmaglione+bmo)
Attachment #8997592 - Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5a51b1f6d4f9
fix calling onBeforeRequest for data/etc urls, r=kmag
https://hg.mozilla.org/mozilla-central/rev/5a51b1f6d4f9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
Flags: needinfo?(mixedpuppy)
since everything runs OOP now there's no chance this would happen anyway (it was an in-process issue), and existing tests verify the change doesn't break anything.
Flags: needinfo?(mixedpuppy) → qe-verify-
You need to log in before you can comment on or make changes to this bug.