Closed
Bug 1471408
Opened 7 years ago
Closed 7 years ago
Multiple top level Java classes inside .java files
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: u614270, Assigned: gabriel-v)
References
Details
Attachments
(1 file)
There are two Java files in the tree that contain multiple top level classes:
- mobile/android/base/java/org/mozilla/gecko/mdns/MulticastDNSManager.java
- mobile/android/base/java/org/mozilla/gecko/RemotePresentationService.java
All other top level classes are contained in Java files with the same name.
Due to a bug in JaCoCo (https://github.com/jacoco/jacoco/issues/701), we will need to have these files split as to have each class in its own file.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tvijiala
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8988009 [details]
Bug 1471408 - Move all top level Java classes into their own file.
https://reviewboard.mozilla.org/r/253268/#review260036
Attachment #8988009 -
Flags: review?(snorp) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f02de3ec24e3
Move all top level Java classes into their own file r=snorp
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/6041c0307804
Backed out changeset f02de3ec24e3 for causing Android build bustages on VirtualPresentation.java. r=backout
Comment 6•7 years ago
|
||
Backed out changeset f02de3ec24e3 (bug 1471408) for causing Android build bustages on VirtualPresentation.java. r=backout
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=db455160668df68ba5d12c20d9364aa2a4c4c167&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=185332421
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185332421&repo=mozilla-central
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=6041c030780420b6205cf2d6640513606609884c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable
Status: RESOLVED → REOPENED
status-firefox63:
fixed → ---
Flags: needinfo?(tvijiala)
Resolution: FIXED → ---
Target Milestone: Firefox 63 → ---
Assignee | ||
Comment 7•7 years ago
|
||
Omitted to exclude VisualPresentatio.java from all the places where RemotePresentationService.java was excluded.
Checked for the same problem with MulticastDNSManager.java.
Flags: needinfo?(tvijiala)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 9•7 years ago
|
||
Confirmed with :snorp, he's keeping the r+.
The failing BnoGPS build is now passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a74309db308dd794b27b9b550846c52e92098da3
Comment 10•7 years ago
|
||
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0259570da98e
Move all top level Java classes into their own file. r=snorp
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•