Multiple top level Java classes inside .java files

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: u614270, Assigned: gabriel-v)

Tracking

unspecified
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
There are two Java files in the tree that contain multiple top level classes:

- mobile/android/base/java/org/mozilla/gecko/mdns/MulticastDNSManager.java
- mobile/android/base/java/org/mozilla/gecko/RemotePresentationService.java

All other top level classes are contained in Java files with the same name.
 
Due to a bug in JaCoCo (https://github.com/jacoco/jacoco/issues/701), we will need to have these files split as to have each class in its own file.
(Assignee)

Updated

9 months ago
Assignee: nobody → tvijiala
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment hidden (mozreview-request)
Comment on attachment 8988009 [details]
Bug 1471408 - Move all top level Java classes into their own file.

https://reviewboard.mozilla.org/r/253268/#review260036
Attachment #8988009 - Flags: review?(snorp) → review+
(Assignee)

Updated

9 months ago
Keywords: checkin-needed
(Assignee)

Updated

9 months ago
Blocks: 1471646
(Assignee)

Updated

9 months ago
Blocks: 1471660

Comment 3

9 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f02de3ec24e3
Move all top level Java classes into their own file r=snorp
Keywords: checkin-needed

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f02de3ec24e3
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

Comment 5

9 months ago
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/6041c0307804
Backed out changeset f02de3ec24e3 for causing Android build bustages on VirtualPresentation.java. r=backout
(Assignee)

Comment 7

9 months ago
Omitted to exclude VisualPresentatio.java from all the places where RemotePresentationService.java was excluded.

Checked for the same problem with MulticastDNSManager.java.
Flags: needinfo?(tvijiala)
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Keywords: checkin-needed
(Assignee)

Comment 9

9 months ago
Confirmed with :snorp, he's keeping the r+.

The failing BnoGPS build is now passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a74309db308dd794b27b9b550846c52e92098da3

Comment 10

9 months ago
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0259570da98e
Move all top level Java classes into their own file. r=snorp
Keywords: checkin-needed

Comment 11

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0259570da98e
Status: REOPENED → RESOLVED
Last Resolved: 9 months ago9 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.