1471408 - Multiple top level Java classes inside .java files

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u614270]

There are two Java files in the tree that contain multiple top level classes:

- mobile/android/base/java/org/mozilla/gecko/mdns/MulticastDNSManager.java
- mobile/android/base/java/org/mozilla/gecko/RemotePresentationService.java

All other top level classes are contained in Java files with the same name.
 
Due to a bug in JaCoCo (https://github.com/jacoco/jacoco/issues/701), we will need to have these files split as to have each class in its own file.

Comment 1

[Gabriel Vîjială [:gabriel-v]]

Attachment: Bug 1471408 - Move all top level Java classes into their own file.

Review commit: https://reviewboard.mozilla.org/r/253268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253268/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8988009 [details]
Bug 1471408 - Move all top level Java classes into their own file.

https://reviewboard.mozilla.org/r/253268/#review260036

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f02de3ec24e3
Move all top level Java classes into their own file r=snorp

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f02de3ec24e3

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/6041c0307804
Backed out changeset f02de3ec24e3 for causing Android build bustages on VirtualPresentation.java. r=backout

Comment 6

[Eliza Balazs [:ebalazs_]]

Backed out changeset f02de3ec24e3 (bug 1471408) for causing Android build bustages on VirtualPresentation.java. r=backout

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=db455160668df68ba5d12c20d9364aa2a4c4c167&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=185332421

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185332421&repo=mozilla-central

Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=6041c030780420b6205cf2d6640513606609884c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable

Comment 7

[Gabriel Vîjială [:gabriel-v]]

Omitted to exclude VisualPresentatio.java from all the places where RemotePresentationService.java was excluded.

Checked for the same problem with MulticastDNSManager.java.

Comment 8

[Gabriel Vîjială [:gabriel-v]]

Comment on attachment 8988009 [details]
Bug 1471408 - Move all top level Java classes into their own file.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253268/diff/1-2/

Comment 9

[Gabriel Vîjială [:gabriel-v]]

Confirmed with :snorp, he's keeping the r+.

The failing BnoGPS build is now passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a74309db308dd794b27b9b550846c52e92098da3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0259570da98e
Move all top level Java classes into their own file. r=snorp

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/0259570da98e