Closed
Bug 1471576
Opened 6 years ago
Closed 6 years ago
Reset gcov counters before every test and dump them before shutdown in per-test coverage mode on Windows too
Categories
(Testing :: Code Coverage, enhancement)
Testing
Code Coverage
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
This depends on https://reviews.llvm.org/D48538.
|
|
Assignee | |
Comment 2•6 years ago
|
||
This should be fixed by bug 1498637.
Assignee: nobody → mcastelluccio
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•6 years ago
|
||
Actually, we still have to remove this `is_linux` check: https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/mozharness/mozilla/testing/codecoverage.py#258.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 4•6 years ago
|
||
https://reviews.llvm.org/D51974 (which fixes https://bugs.llvm.org/show_bug.cgi?id=39520) is needed for the GCOV part.
See Also: → https://bugs.llvm.org/show_bug.cgi?id=39520
|
|
Assignee | |
Comment 5•6 years ago
|
||
I will land this after bug 1504073 and bug 1504074 are fixed.
Attachment #9021988 -
Flags: review?(jmaher)
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9021988 [details] [diff] [review] Patch Review of attachment 9021988 [details] [diff] [review]: ----------------------------------------------------------------- this will be for windows and osx, correct?
Attachment #9021988 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
Yes, OS X should work too, although I haven't tested it, as the OS X build is currently broken. We should have enabled it by default sooner :(
|
|
Assignee | |
Comment 8•6 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #4) > https://reviews.llvm.org/D51974 (which fixes > https://bugs.llvm.org/show_bug.cgi?id=39520) is needed for the GCOV part. The right link is https://reviews.llvm.org/D53988...
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a316d6c87b3b Use reset/dump of coverage counters on Windows too. r=jmaher
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a316d6c87b3b
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•