1471576 - Reset gcov counters before every test and dump them before shutdown in per-test coverage mode on Windows too

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Comment 1

[Marco Castelluccio [:marco]]

This depends on https://reviews.llvm.org/D48538.

Comment 2

[Marco Castelluccio [:marco]]

This should be fixed by bug 1498637.

Comment 3

[Marco Castelluccio [:marco]]

Actually, we still have to remove this `is_linux` check: https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/mozharness/mozilla/testing/codecoverage.py#258.

Comment 4

[Marco Castelluccio [:marco]]

https://reviews.llvm.org/D51974 (which fixes https://bugs.llvm.org/show_bug.cgi?id=39520) is needed for the GCOV part.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch

I will land this after bug 1504073 and bug 1504074 are fixed.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9021988 [details] [diff] [review]
Patch

Review of attachment 9021988 [details] [diff] [review]:
-----------------------------------------------------------------

this will be for windows and osx, correct?

Comment 7

[Marco Castelluccio [:marco]]

Yes, OS X should work too, although I haven't tested it, as the OS X build is currently broken. We should have enabled it by default sooner :(

Comment 8

[Marco Castelluccio [:marco]]

(In reply to Marco Castelluccio [:marco] from comment #4)
> https://reviews.llvm.org/D51974 (which fixes
> https://bugs.llvm.org/show_bug.cgi?id=39520) is needed for the GCOV part.

The right link is https://reviews.llvm.org/D53988...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a316d6c87b3b
Use reset/dump of coverage counters on Windows too. r=jmaher

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a316d6c87b3b