1471976 - Port bug 1466335 to TB: Automatically enable the dark theme in macOS 10.14 dark mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1470910 implements, that FX uses the dark theme automatically when the dark OS theme under macOS 10.14 is used. And they plan to do this for Windows too.

For us this is a simple one liner.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: ApplyDarkTheme.patch

This is a simple port of https://hg.mozilla.org/mozilla-central/rev/760705f94da446d77749544cd5bd8602cb7367a9#l1.12

Jörg, I know you have no macOS, but this patch is so simple and you can check that it doesn't regress on Windows.

Comment 2

[Richard Marti (:Paenglab)]

FX changes the theme already on macOS 10.13 when the OS titlebar is set to black. I tested this TB and it didn't work, maybe because we haven't set the DARK_THEME_ID constant. But where should I set this?

I think, also with not working theme change, we should follow to stay this file in sync .

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8988572 [details] [diff] [review]
ApplyDarkTheme.patch

Looks good.

Comment 4

[Jorg K (CEST = GMT+2)]

Looks like you confused two bugs here. Here we're porting bug 1466335.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3122f5e25eb5
Port bug 1466335 to TB: Automatically apply the dark theme on startup if the OS is in dark mode. r=jorgk

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #2)
> FX changes the theme already on macOS 10.13 when the OS titlebar is set to
> black. I tested this TB and it didn't work, maybe because we haven't set the
> DARK_THEME_ID constant. But where should I set this?
Sorry, I missed that comment. So does is work at least for macOS 10.14?

In general we'd have to see where FF gets the OS theme and selects its theme based on that. Then see how to make that work in TB.

Comment 7

[Richard Marti (:Paenglab)]

I have no 10.14 beta. Actually it works on 10.13 too for FX but not TB.

The change in https://hg.mozilla.org/mozilla-central/rev/24fe98c45aae#l3.12 sets "[e-mail]" and this doesn't work with our ID of "[e-mail]".

Stephen, could this be changed or overwritten somehow or do we need to rename our theme?

Comment 8

[Stephen A Pohl [:spohl]]

(In reply to Richard Marti (:Paenglab) from comment #7)
> I have no 10.14 beta. Actually it works on 10.13 too for FX but not TB.

This was an oversight and is fixed by bug 1471950.

> The change in https://hg.mozilla.org/mozilla-central/rev/24fe98c45aae#l3.12
> sets "[e-mail]" and this doesn't work with our ID of
> "[e-mail]".
> 
> Stephen, could this be changed or overwritten somehow or do we need to
> rename our theme?

Does TB use any kind of compile-time defines? If so, we could define DARK_THEME_ID accordingly. Renaming the theme is another option. I'm not sure how this kind of problem is typically solved by TB but happy to help!

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks for your answer. Yes, we can use compile-time defines. But you'd have to introduce that facility first, so we can then override it. I'm not so keen on giving the TB theme a FF name.